1
0
mirror of https://github.com/samba-team/samba.git synced 2025-10-26 23:33:15 +03:00
Files
samba-mirror/source
Corinna Vinschen 373a23d48f Tiny memory leak in lib/version.c
Hi,

while implementing the extra_info version stuff, it occured to me that
samba_version_string() potentially allocates memory which is unused but
never free'd.

If SAMBA_VERSION_VENDOR_PATCH is defined, a second call to asprintf
takes place.  The result is stored in tmp_version.  Afterwards,
samba_version is set to tmp_version without free'ing samba_version
first.  Looks like a simple free(samba_version) is missing.  Patch
against 3.2-test below.

Ok, this only happens once over the lifetime of the application, so it's
no big deal, but I though it doesn't hurt to mention it.

Corinna

	* lib/version.c (samba_version_string): Free samba_version
	before setting to tmp_version.
2008-01-19 19:30:16 +01:00
..
2008-01-19 16:19:28 +01:00
2008-01-19 19:30:16 +01:00
2008-01-10 01:04:47 +01:00
2008-01-16 12:42:26 +03:00
2008-01-15 10:43:43 +01:00
2008-01-15 17:30:29 +01:00
2007-12-21 09:58:21 +01:00