mirror of
https://github.com/samba-team/samba.git
synced 2024-12-30 13:18:05 +03:00
7bee3ef684
Zero length EA's only delete an EA, never store. Proves we should never return zero-length EA's even if they have been set on the POSIX side. ntvfs server doesn't implement the FULL_EA_INFORMATION setinfo call, so add to selftest/knownfail. Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: David Disseldorp <ddiss@suse.de>
411 lines
14 KiB
C
411 lines
14 KiB
C
/*
|
|
Unix SMB/CIFS implementation.
|
|
|
|
SMB2 setinfo individual test suite
|
|
|
|
Copyright (C) Andrew Tridgell 2005
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "includes.h"
|
|
#include "system/time.h"
|
|
#include "libcli/smb2/smb2.h"
|
|
#include "libcli/smb2/smb2_calls.h"
|
|
|
|
#include "torture/torture.h"
|
|
#include "torture/smb2/proto.h"
|
|
|
|
#include "libcli/security/security.h"
|
|
#include "librpc/gen_ndr/ndr_security.h"
|
|
|
|
static bool find_returned_ea(union smb_fileinfo *finfo2,
|
|
const char *eaname,
|
|
const char *eavalue)
|
|
{
|
|
unsigned int i;
|
|
unsigned int num_eas = finfo2->all_eas.out.num_eas;
|
|
struct ea_struct *eas = finfo2->all_eas.out.eas;
|
|
|
|
for (i = 0; i < num_eas; i++) {
|
|
if (eas[i].name.s == NULL) {
|
|
continue;
|
|
}
|
|
/* Windows capitalizes returned EA names. */
|
|
if (strcasecmp_m(eas[i].name.s, eaname)) {
|
|
continue;
|
|
}
|
|
if (eavalue == NULL && eas[i].value.length == 0) {
|
|
/* Null value, found it ! */
|
|
return true;
|
|
}
|
|
if (eas[i].value.length == strlen(eavalue) &&
|
|
memcmp(eas[i].value.data,
|
|
eavalue,
|
|
strlen(eavalue)) == 0) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
#define BASEDIR ""
|
|
|
|
#define FAIL_UNLESS(__cond) \
|
|
do { \
|
|
if (__cond) {} else { \
|
|
torture_result(tctx, TORTURE_FAIL, "%s) condition violated: %s\n", \
|
|
__location__, #__cond); \
|
|
ret = false; goto done; \
|
|
} \
|
|
} while(0)
|
|
|
|
/* basic testing of all SMB2 setinfo calls
|
|
for each call we test that it succeeds, and where possible test
|
|
for consistency between the calls.
|
|
*/
|
|
bool torture_smb2_setinfo(struct torture_context *tctx)
|
|
{
|
|
struct smb2_tree *tree;
|
|
bool ret = true;
|
|
struct smb2_handle handle;
|
|
char *fname;
|
|
union smb_fileinfo finfo2;
|
|
union smb_setfileinfo sfinfo;
|
|
struct security_ace ace;
|
|
struct security_descriptor *sd;
|
|
struct dom_sid *test_sid;
|
|
NTSTATUS status, status2=NT_STATUS_OK;
|
|
const char *call_name;
|
|
time_t basetime = (time(NULL) - 86400) & ~1;
|
|
int n = time(NULL) % 100;
|
|
struct ea_struct ea;
|
|
|
|
ZERO_STRUCT(handle);
|
|
|
|
fname = talloc_asprintf(tctx, BASEDIR "fnum_test_%d.txt", n);
|
|
|
|
if (!torture_smb2_connection(tctx, &tree)) {
|
|
return false;
|
|
}
|
|
|
|
#define RECREATE_FILE(fname) do { \
|
|
smb2_util_close(tree, handle); \
|
|
status = smb2_create_complex_file(tree, fname, &handle); \
|
|
if (!NT_STATUS_IS_OK(status)) { \
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) ERROR: open of %s failed (%s)\n", \
|
|
__location__, fname, nt_errstr(status)); \
|
|
ret = false; \
|
|
goto done; \
|
|
}} while (0)
|
|
|
|
#define RECREATE_BOTH do { \
|
|
RECREATE_FILE(fname); \
|
|
} while (0)
|
|
|
|
RECREATE_BOTH;
|
|
|
|
#define CHECK_CALL(call, rightstatus) do { \
|
|
call_name = #call; \
|
|
sfinfo.generic.level = RAW_SFILEINFO_ ## call; \
|
|
sfinfo.generic.in.file.handle = handle; \
|
|
status = smb2_setinfo_file(tree, &sfinfo); \
|
|
if (!NT_STATUS_EQUAL(status, rightstatus)) { \
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) %s - %s (should be %s)\n", __location__, #call, \
|
|
nt_errstr(status), nt_errstr(rightstatus)); \
|
|
ret = false; \
|
|
goto done; \
|
|
} \
|
|
} while (0)
|
|
|
|
#define CHECK1(call) \
|
|
do { if (NT_STATUS_IS_OK(status)) { \
|
|
finfo2.generic.level = RAW_FILEINFO_ ## call; \
|
|
finfo2.generic.in.file.handle = handle; \
|
|
status2 = smb2_getinfo_file(tree, tctx, &finfo2); \
|
|
if (!NT_STATUS_IS_OK(status2)) { \
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) %s - %s\n", __location__, #call, nt_errstr(status2)); \
|
|
ret = false; \
|
|
goto done; \
|
|
} \
|
|
}} while (0)
|
|
|
|
#define CHECK_VALUE(call, stype, field, value) do { \
|
|
CHECK1(call); \
|
|
if (NT_STATUS_IS_OK(status) && NT_STATUS_IS_OK(status2) && finfo2.stype.out.field != value) { \
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) %s - %s/%s should be 0x%x - 0x%x\n", __location__, \
|
|
call_name, #stype, #field, \
|
|
(unsigned int)value, (unsigned int)finfo2.stype.out.field); \
|
|
torture_smb2_all_info(tree, handle); \
|
|
ret = false; \
|
|
goto done; \
|
|
}} while (0)
|
|
|
|
#define CHECK_TIME(call, stype, field, value) do { \
|
|
CHECK1(call); \
|
|
if (NT_STATUS_IS_OK(status) && NT_STATUS_IS_OK(status2) && nt_time_to_unix(finfo2.stype.out.field) != value) { \
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) %s - %s/%s should be 0x%x - 0x%x\n", __location__, \
|
|
call_name, #stype, #field, \
|
|
(unsigned int)value, \
|
|
(unsigned int)nt_time_to_unix(finfo2.stype.out.field)); \
|
|
torture_warning(tctx, "\t%s", timestring(tctx, value)); \
|
|
torture_warning(tctx, "\t%s\n", nt_time_string(tctx, finfo2.stype.out.field)); \
|
|
torture_smb2_all_info(tree, handle); \
|
|
ret = false; \
|
|
goto done; \
|
|
}} while (0)
|
|
|
|
#define CHECK_STATUS(status, correct) do { \
|
|
if (!NT_STATUS_EQUAL(status, correct)) { \
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) Incorrect status %s - should be %s\n", \
|
|
__location__, nt_errstr(status), nt_errstr(correct)); \
|
|
ret = false; \
|
|
goto done; \
|
|
}} while (0)
|
|
|
|
torture_smb2_all_info(tree, handle);
|
|
|
|
torture_comment(tctx, "Test basic_information level\n");
|
|
basetime += 86400;
|
|
unix_to_nt_time(&sfinfo.basic_info.in.create_time, basetime + 100);
|
|
unix_to_nt_time(&sfinfo.basic_info.in.access_time, basetime + 200);
|
|
unix_to_nt_time(&sfinfo.basic_info.in.write_time, basetime + 300);
|
|
unix_to_nt_time(&sfinfo.basic_info.in.change_time, basetime + 400);
|
|
sfinfo.basic_info.in.attrib = FILE_ATTRIBUTE_READONLY;
|
|
CHECK_CALL(BASIC_INFORMATION, NT_STATUS_OK);
|
|
CHECK_TIME(SMB2_ALL_INFORMATION, all_info2, create_time, basetime + 100);
|
|
CHECK_TIME(SMB2_ALL_INFORMATION, all_info2, access_time, basetime + 200);
|
|
CHECK_TIME(SMB2_ALL_INFORMATION, all_info2, write_time, basetime + 300);
|
|
CHECK_TIME(SMB2_ALL_INFORMATION, all_info2, change_time, basetime + 400);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, attrib, FILE_ATTRIBUTE_READONLY);
|
|
|
|
torture_comment(tctx, "a zero time means don't change\n");
|
|
unix_to_nt_time(&sfinfo.basic_info.in.create_time, 0);
|
|
unix_to_nt_time(&sfinfo.basic_info.in.access_time, 0);
|
|
unix_to_nt_time(&sfinfo.basic_info.in.write_time, 0);
|
|
unix_to_nt_time(&sfinfo.basic_info.in.change_time, 0);
|
|
sfinfo.basic_info.in.attrib = FILE_ATTRIBUTE_NORMAL;
|
|
CHECK_CALL(BASIC_INFORMATION, NT_STATUS_OK);
|
|
CHECK_TIME(SMB2_ALL_INFORMATION, all_info2, create_time, basetime + 100);
|
|
CHECK_TIME(SMB2_ALL_INFORMATION, all_info2, access_time, basetime + 200);
|
|
CHECK_TIME(SMB2_ALL_INFORMATION, all_info2, write_time, basetime + 300);
|
|
CHECK_TIME(SMB2_ALL_INFORMATION, all_info2, change_time, basetime + 400);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, attrib, FILE_ATTRIBUTE_NORMAL);
|
|
|
|
torture_comment(tctx, "change the attribute\n");
|
|
sfinfo.basic_info.in.attrib = FILE_ATTRIBUTE_HIDDEN;
|
|
CHECK_CALL(BASIC_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, attrib, FILE_ATTRIBUTE_HIDDEN);
|
|
|
|
torture_comment(tctx, "zero attrib means don't change\n");
|
|
sfinfo.basic_info.in.attrib = 0;
|
|
CHECK_CALL(BASIC_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, attrib, FILE_ATTRIBUTE_HIDDEN);
|
|
|
|
torture_comment(tctx, "can't change a file to a directory\n");
|
|
sfinfo.basic_info.in.attrib = FILE_ATTRIBUTE_DIRECTORY;
|
|
CHECK_CALL(BASIC_INFORMATION, NT_STATUS_INVALID_PARAMETER);
|
|
|
|
torture_comment(tctx, "restore attribute\n");
|
|
sfinfo.basic_info.in.attrib = FILE_ATTRIBUTE_NORMAL;
|
|
CHECK_CALL(BASIC_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, attrib, FILE_ATTRIBUTE_NORMAL);
|
|
|
|
torture_comment(tctx, "Test disposition_information level\n");
|
|
sfinfo.disposition_info.in.delete_on_close = 1;
|
|
CHECK_CALL(DISPOSITION_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, delete_pending, 1);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, nlink, 0);
|
|
|
|
sfinfo.disposition_info.in.delete_on_close = 0;
|
|
CHECK_CALL(DISPOSITION_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, delete_pending, 0);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, nlink, 1);
|
|
|
|
torture_comment(tctx, "Test allocation_information level\n");
|
|
sfinfo.allocation_info.in.alloc_size = 0;
|
|
CHECK_CALL(ALLOCATION_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, size, 0);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, alloc_size, 0);
|
|
|
|
sfinfo.allocation_info.in.alloc_size = 4096;
|
|
CHECK_CALL(ALLOCATION_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, alloc_size, 4096);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, size, 0);
|
|
|
|
torture_comment(tctx, "Test end_of_file_info level\n");
|
|
sfinfo.end_of_file_info.in.size = 37;
|
|
CHECK_CALL(END_OF_FILE_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, size, 37);
|
|
|
|
sfinfo.end_of_file_info.in.size = 7;
|
|
CHECK_CALL(END_OF_FILE_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, size, 7);
|
|
|
|
torture_comment(tctx, "Test position_information level\n");
|
|
sfinfo.position_information.in.position = 123456;
|
|
CHECK_CALL(POSITION_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(POSITION_INFORMATION, position_information, position, 123456);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, position, 123456);
|
|
|
|
torture_comment(tctx, "Test mode_information level\n");
|
|
sfinfo.mode_information.in.mode = 2;
|
|
CHECK_CALL(MODE_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(MODE_INFORMATION, mode_information, mode, 2);
|
|
CHECK_VALUE(SMB2_ALL_INFORMATION, all_info2, mode, 2);
|
|
|
|
sfinfo.mode_information.in.mode = 1;
|
|
CHECK_CALL(MODE_INFORMATION, NT_STATUS_INVALID_PARAMETER);
|
|
|
|
sfinfo.mode_information.in.mode = 0;
|
|
CHECK_CALL(MODE_INFORMATION, NT_STATUS_OK);
|
|
CHECK_VALUE(MODE_INFORMATION, mode_information, mode, 0);
|
|
|
|
torture_comment(tctx, "Test sec_desc level\n");
|
|
ZERO_STRUCT(finfo2);
|
|
finfo2.query_secdesc.in.secinfo_flags =
|
|
SECINFO_OWNER |
|
|
SECINFO_GROUP |
|
|
SECINFO_DACL;
|
|
CHECK1(SEC_DESC);
|
|
sd = finfo2.query_secdesc.out.sd;
|
|
|
|
test_sid = dom_sid_parse_talloc(tctx, SID_NT_AUTHENTICATED_USERS);
|
|
ZERO_STRUCT(ace);
|
|
ace.type = SEC_ACE_TYPE_ACCESS_ALLOWED;
|
|
ace.flags = 0;
|
|
ace.access_mask = SEC_STD_ALL;
|
|
ace.trustee = *test_sid;
|
|
status = security_descriptor_dacl_add(sd, &ace);
|
|
CHECK_STATUS(status, NT_STATUS_OK);
|
|
|
|
torture_comment(tctx, "add a new ACE to the DACL\n");
|
|
|
|
sfinfo.set_secdesc.in.secinfo_flags = finfo2.query_secdesc.in.secinfo_flags;
|
|
sfinfo.set_secdesc.in.sd = sd;
|
|
CHECK_CALL(SEC_DESC, NT_STATUS_OK);
|
|
FAIL_UNLESS(smb2_util_verify_sd(tctx, tree, handle, sd));
|
|
|
|
torture_comment(tctx, "remove it again\n");
|
|
|
|
status = security_descriptor_dacl_del(sd, test_sid);
|
|
CHECK_STATUS(status, NT_STATUS_OK);
|
|
|
|
sfinfo.set_secdesc.in.secinfo_flags = finfo2.query_secdesc.in.secinfo_flags;
|
|
sfinfo.set_secdesc.in.sd = sd;
|
|
CHECK_CALL(SEC_DESC, NT_STATUS_OK);
|
|
FAIL_UNLESS(smb2_util_verify_sd(tctx, tree, handle, sd));
|
|
|
|
torture_comment(tctx, "Check zero length EA's behavior\n");
|
|
|
|
/* Set a new EA. */
|
|
sfinfo.full_ea_information.in.eas.num_eas = 1;
|
|
ea.flags = 0;
|
|
ea.name.private_length = 6;
|
|
ea.name.s = "NewEA";
|
|
ea.value = data_blob_string_const("testme");
|
|
sfinfo.full_ea_information.in.eas.eas = &ea;
|
|
CHECK_CALL(FULL_EA_INFORMATION, NT_STATUS_OK);
|
|
|
|
/* Does it still exist ? */
|
|
finfo2.generic.level = RAW_FILEINFO_SMB2_ALL_EAS;
|
|
finfo2.generic.in.file.handle = handle;
|
|
finfo2.all_eas.in.continue_flags = 1;
|
|
status2 = smb2_getinfo_file(tree, tctx, &finfo2);
|
|
if (!NT_STATUS_IS_OK(status2)) {
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) %s - %s\n", __location__,
|
|
"SMB2_ALL_EAS", nt_errstr(status2));
|
|
ret = false;
|
|
goto done;
|
|
}
|
|
|
|
/* Note on Windows EA name is returned capitalized. */
|
|
if (!find_returned_ea(&finfo2, "NewEA", "testme")) {
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) Missing EA 'NewEA'\n", __location__);
|
|
ret = false;
|
|
}
|
|
|
|
/* Now zero it out (should delete it) */
|
|
sfinfo.full_ea_information.in.eas.num_eas = 1;
|
|
ea.flags = 0;
|
|
ea.name.private_length = 6;
|
|
ea.name.s = "NewEA";
|
|
ea.value = data_blob_null;
|
|
sfinfo.full_ea_information.in.eas.eas = &ea;
|
|
CHECK_CALL(FULL_EA_INFORMATION, NT_STATUS_OK);
|
|
|
|
/* Does it still exist ? */
|
|
finfo2.generic.level = RAW_FILEINFO_SMB2_ALL_EAS;
|
|
finfo2.generic.in.file.handle = handle;
|
|
finfo2.all_eas.in.continue_flags = 1;
|
|
status2 = smb2_getinfo_file(tree, tctx, &finfo2);
|
|
if (!NT_STATUS_IS_OK(status2)) {
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) %s - %s\n", __location__,
|
|
"SMB2_ALL_EAS", nt_errstr(status2));
|
|
ret = false;
|
|
goto done;
|
|
}
|
|
|
|
if (find_returned_ea(&finfo2, "NewEA", NULL)) {
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) EA 'NewEA' should be deleted\n", __location__);
|
|
ret = false;
|
|
}
|
|
|
|
/* Set a zero length EA. */
|
|
sfinfo.full_ea_information.in.eas.num_eas = 1;
|
|
ea.flags = 0;
|
|
ea.name.private_length = 6;
|
|
ea.name.s = "ZeroEA";
|
|
ea.value = data_blob_null;
|
|
sfinfo.full_ea_information.in.eas.eas = &ea;
|
|
CHECK_CALL(FULL_EA_INFORMATION, NT_STATUS_OK);
|
|
|
|
/* Does it still exist ? */
|
|
finfo2.generic.level = RAW_FILEINFO_SMB2_ALL_EAS;
|
|
finfo2.generic.in.file.handle = handle;
|
|
finfo2.all_eas.in.continue_flags = 1;
|
|
status2 = smb2_getinfo_file(tree, tctx, &finfo2);
|
|
if (!NT_STATUS_IS_OK(status2)) {
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) %s - %s\n", __location__,
|
|
"SMB2_ALL_EAS", nt_errstr(status2));
|
|
ret = false;
|
|
goto done;
|
|
}
|
|
|
|
/* Over SMB2 ZeroEA should not exist. */
|
|
if (!find_returned_ea(&finfo2, "EAONE", "VALUE1")) {
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) Missing EA 'EAONE'\n", __location__);
|
|
ret = false;
|
|
}
|
|
if (!find_returned_ea(&finfo2, "SECONDEA", "ValueTwo")) {
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) Missing EA 'SECONDEA'\n", __location__);
|
|
ret = false;
|
|
}
|
|
if (find_returned_ea(&finfo2, "ZeroEA", NULL)) {
|
|
torture_result(tctx, TORTURE_FAIL, "(%s) Found null EA 'ZeroEA'\n", __location__);
|
|
ret = false;
|
|
}
|
|
|
|
done:
|
|
status = smb2_util_close(tree, handle);
|
|
if (NT_STATUS_IS_ERR(status)) {
|
|
torture_warning(tctx, "Failed to delete %s - %s\n", fname, nt_errstr(status));
|
|
}
|
|
smb2_util_unlink(tree, fname);
|
|
|
|
return ret;
|
|
}
|
|
|
|
|