mirror of
https://github.com/samba-team/samba.git
synced 2025-01-14 19:24:43 +03:00
3c0d80d0c3
We display warnings if a target object is missing but it's still OK to continue the replication. Currently we need to check the target twice - once to verify it when we first receive it, and once when we actually commit it (we can't skip the 2nd check altogether because in the join case, they could occur quite far apart). One annoying side-effect is we get the same warning message coming out twice in these special cases. In the cases where we're checking the dsdb_repl_flags, we can actually just bypass the verification checks for the target object (if it doesn't exist we still continue anyway). This may save us a tiny bit of unnecessary work. For cross-partition links, we can limit logging these warnings to when the objects are actually being committed. This avoids spurious warnings in the join case (i.e. we receive the link before we receive the target object's partition, but we have received all partitions by the time we actually commit the objects). Signed-off-by: Tim Beale <timbeale@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=12972 Reviewed-by: Garming Sam <garming@catalyst.net.nz>