1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
samba-mirror/lib/util/tests/str.c
Douglas Bagnall 50047588c0 torture: talloc_string_sub tests for utf-8 brevity
If we allow overly long UTF-8 sequences (in the tests, encoding '\0'
as 2, 3, or 4 bytes), it might be possible for bad strings to slip
through.

We fail. But wait for the next commit.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14684

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
2021-06-18 03:39:28 +00:00

181 lines
5.1 KiB
C

/*
Unix SMB/CIFS implementation.
util_str testing
Copyright (C) Jelmer Vernooij <jelmer@samba.org> 2007
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "includes.h"
#include "torture/torture.h"
#include "torture/local/proto.h"
static bool test_string_sub_simple(struct torture_context *tctx)
{
char tmp[100];
strlcpy(tmp, "foobar", sizeof(tmp));
string_sub(tmp, "foo", "bar", sizeof(tmp));
torture_assert_str_equal(tctx, tmp, "barbar", "invalid sub");
return true;
}
static bool test_string_sub_multiple(struct torture_context *tctx)
{
char tmp[100];
strlcpy(tmp, "fooblafoo", sizeof(tmp));
string_sub(tmp, "foo", "bar", sizeof(tmp));
torture_assert_str_equal(tctx, tmp, "barblabar", "invalid sub");
return true;
}
static bool test_string_sub_longer(struct torture_context *tctx)
{
char tmp[100];
strlcpy(tmp, "foobla", sizeof(tmp));
string_sub(tmp, "foo", "blie", sizeof(tmp));
torture_assert_str_equal(tctx, tmp, "bliebla", "invalid sub");
return true;
}
static bool test_string_sub_shorter(struct torture_context *tctx)
{
char tmp[100];
strlcpy(tmp, "foobla", sizeof(tmp));
string_sub(tmp, "foo", "bl", sizeof(tmp));
torture_assert_str_equal(tctx, tmp, "blbla", "invalid sub");
return true;
}
static bool test_string_sub_special_char(struct torture_context *tctx)
{
char tmp[100];
strlcpy(tmp, "foobla", sizeof(tmp));
string_sub(tmp, "foo", "%b;l", sizeof(tmp));
torture_assert_str_equal(tctx, tmp, "_b_lbla", "invalid sub");
return true;
}
static bool test_talloc_string_sub_simple(struct torture_context *tctx)
{
char *t;
t = talloc_string_sub(tctx, "foobla", "foo", "bl");
torture_assert_str_equal(tctx, t, "blbla", "invalid sub");
return true;
}
static bool test_talloc_string_sub_multiple(struct torture_context *tctx)
{
char *t;
t = talloc_string_sub(tctx, "fooblafoo", "foo", "aapnootmies");
torture_assert_str_equal(tctx, t, "aapnootmiesblaaapnootmies",
"invalid sub");
return true;
}
/*
* with these next three tests, the failure is that the pattern looks like
* "+++" because the \x.. bytes encode a zero byte in UTF-8. If we are not
* careful with these strings we will see crashes instead of failures.
*/
static bool test_talloc_string_sub_tricky_utf8_4(struct torture_context *tctx)
{
const char string[] = "++++--\xD8\xBB";
const char pattern[] = "+++\xF0\x80\x80\x80++";
const char replace[] = "...";
char *t = talloc_string_sub(tctx, string, pattern, replace);
torture_assert_str_equal(tctx, t, string,
"should reject 4 byte NUL char");
talloc_free(t);
return true;
}
static bool test_talloc_string_sub_tricky_utf8_3(struct torture_context *tctx)
{
const char string[] = "++++--\xD8\xBB";
const char pattern[] = "+++\xE0\x80\x80++";
const char replace[] = "...";
char *t = talloc_string_sub(tctx, string, pattern, replace);
torture_assert_str_equal(tctx, t, string,
"should reject 3 byte NUL char");
talloc_free(t);
return true;
}
static bool test_talloc_string_sub_tricky_utf8_2(struct torture_context *tctx)
{
const char string[] = "++++--\xD8\xBB";
const char pattern[] = "+++\xC0\x80++";
const char replace[] = "...";
char *t = talloc_string_sub(tctx, string, pattern, replace);
torture_assert_str_equal(tctx, t, string,
"should reject 2 byte NUL char");
talloc_free(t);
return true;
}
struct torture_suite *torture_local_util_str(TALLOC_CTX *mem_ctx)
{
struct torture_suite *suite = torture_suite_create(mem_ctx, "str");
torture_suite_add_simple_test(suite, "string_sub_simple",
test_string_sub_simple);
torture_suite_add_simple_test(suite, "string_sub_multiple",
test_string_sub_multiple);
torture_suite_add_simple_test(suite, "string_sub_shorter",
test_string_sub_shorter);
torture_suite_add_simple_test(suite, "string_sub_longer",
test_string_sub_longer);
torture_suite_add_simple_test(suite, "string_sub_special_chars",
test_string_sub_special_char);
torture_suite_add_simple_test(suite, "talloc_string_sub_simple",
test_talloc_string_sub_simple);
torture_suite_add_simple_test(suite, "string_sub_talloc_multiple",
test_talloc_string_sub_multiple);
torture_suite_add_simple_test(suite,
"test_talloc_string_sub_tricky_utf8_4",
test_talloc_string_sub_tricky_utf8_4);
torture_suite_add_simple_test(suite,
"test_talloc_string_sub_tricky_utf8_3",
test_talloc_string_sub_tricky_utf8_3);
torture_suite_add_simple_test(suite,
"test_talloc_string_sub_tricky_utf8_2",
test_talloc_string_sub_tricky_utf8_2);
return suite;
}