Ralph Boehme 3e6621fe58 CVE-2018-1057: s4/dsdb: correctly detect password resets ... This change ensures we correctly treat the following LDIF dn: cn=testuser,cn=users,... changetype: modify delete: userPassword add: userPassword userPassword: thatsAcomplPASS1 as a password reset. Because delete and add element counts are both one, the ACL module wrongly treated this as a password change request. For a password change we need at least one value to delete and one value to add. This patch ensures we correctly check attributes and their values. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13272 Signed-off-by: Ralph Boehme <slow@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org>		2018-03-13 10:24:27 +01:00
..
tests	dsdb/encrypted_secrets: remove dependency to libnettle and use our own aes_gcm_128_*()	2018-02-23 12:47:25 +01:00
acl_read.c	dsdb: Remember the last ACL we read during a search and what it expanded to	2017-06-16 07:39:24 +02:00
acl_util.c	dsdb-descriptor: Spell out security descriptor flags as constants	2013-02-22 09:19:41 +01:00
acl.c	CVE-2018-1057: s4/dsdb: correctly detect password resets	2018-03-13 10:24:27 +01:00
anr.c
descriptor.c	dsdb: Improve debugging during SD recursion failure	2016-07-13 02:59:25 +02:00
dirsync.c	dsdb: Remove a self-assignment	2014-11-24 18:52:05 +01:00
dns_notify.c	Correct "notifiying" typos.	2017-02-22 08:26:22 +01:00
dsdb_notification.c	dsdb: Correctly call ldb_module_done in dsdb_notification	2017-06-15 01:24:25 +02:00
encrypted_secrets.c	dsdb/encrypted_secrets: remove dependency to libnettle and use our own aes_gcm_128_*()	2018-02-23 12:47:25 +01:00
extended_dn_in.c	ldb-samba: Reenable recursive search	2016-01-18 04:42:21 +01:00
extended_dn_out.c	dsdb: Avoid ldb_dn_validate() call on trusted input when not required	2016-09-27 20:47:34 +02:00
extended_dn_store.c	dsdb:extended_dn_store: implement DSDB_CONTROL_DBCHECK_FIX_DUPLICATE_LINKS control	2017-11-24 15:50:16 +01:00
instancetype.c	dsdb: Permit creation of partitions of type INSTANCE_TYPE_UNINSTANT	2014-09-01 00:36:42 +02:00
lazy_commit.c
linked_attributes.c	s4:samdb: Add FALL_THROUGH statements in linked_attributes.c	2018-03-01 04:37:42 +01:00
local_password.c	samdb: Fix CID 241968 Uninitialized pointer read	2013-11-11 21:04:09 +01:00
netlogon.c	s4-cldap/netlogon: Match Windows 2012R2 and return NETLOGON_NT_VERSION_5 when version unspecified	2017-07-28 00:25:15 +02:00
new_partition.c
objectclass_attrs.c	objectclass_attrs: Restrict systemOnly attributes	2017-03-13 05:10:12 +01:00
objectclass.c	objectclass: Ensure that backlinks are not replicated	2017-12-14 08:20:15 +01:00
objectguid.c
operational.c	dsdb: Fix use-after-free of parent_dn in operational module	2016-06-27 00:18:17 +02:00
partition_init.c	partition: Allow a different backend store from @PARTITION	2018-03-05 20:50:16 +01:00
partition_metadata.c	partition: Use a transaction to write and a read lock to read the LDB_METADATA_SEQ_NUM	2018-03-05 20:50:14 +01:00
partition.c	partition: Leave metadata.tdb unlocking until last	2018-03-05 20:50:14 +01:00
partition.h	partition: Allow a different backend store from @PARTITION	2018-03-05 20:50:16 +01:00
password_hash.c	CVE-2018-1057: s4:dsdb/password_hash: add a helper variable for passwordAttr->num_values	2018-03-13 10:24:26 +01:00
password_modules.h
proxy.c
ranged_results.c	s4: ldb: Ignore case of "range" in sscanf as we've already checked for its presence.	2016-06-29 23:09:17 +02:00
repl_meta_data.c	repl_md: avoid returning LDB_SUCCESS on failure	2018-02-24 10:54:07 +01:00
resolve_oids.c	s4:dsdb: Fix warnings about not set / set but unused / shadowed variables	2013-04-19 13:15:40 +02:00
ridalloc.c	objectclass_attrs: Restrict systemOnly attributes	2017-03-13 05:10:12 +01:00
rootdse.c	schema: Allow schemaUpdateNow to refresh schema during a transaction	2017-12-14 08:20:15 +01:00
samba3sam.c	dsdb: Add a dummy module to replace show_deleted	2017-06-30 02:12:22 +02:00
samba3sid.c
samba_dsdb.c	provision: Changes to support encrypted_secrets module	2017-12-18 00:10:17 +01:00
samba_secrets.c
samldb.c	subnet: Avoid a segfault when renaming subnet objects	2018-02-19 19:17:12 +01:00
schema_data.c	dsdb: Improve debug messages	2017-06-15 01:24:25 +02:00
schema_load.c	dsdb: The schema should be reloaded during the transaction	2018-03-05 20:50:15 +01:00
schema_util.c	s4:dsdb/schema: don't change schema->schema_info on originating schema changes.	2016-08-11 00:49:14 +02:00
secrets_tdb_sync.c	dlist: remove unneeded type argument from DLIST_ADD_END()	2016-02-06 21:48:17 +01:00
show_deleted.c	show-deleted: Rename attr_filter to exclude_filter for clarity	2017-06-30 06:23:39 +02:00
simple_dn.c	dsdb: Fix CID 1034743 Dereference after null check	2015-06-23 22:12:09 +02:00
simple_ldap_map.c	Fix entryCSN format	2013-09-23 20:42:18 -07:00
subtree_delete.c	s4:dsdb/subtree_delete: delete from the leafs to the root (bug #7711)	2012-11-30 17:17:21 +01:00
subtree_rename.c	dsdb/subtree_rename: Rename the base before we rename children	2016-06-01 10:27:19 +02:00
tombstone_reanimate.c	Revert "dsdb: Disable tombstone_reanimation module until we isolate what causes flaky tests"	2016-07-09 15:06:19 +02:00
unique_object_sids.c	source4 dsdb modules: Add new module "unique_object_sids"	2017-12-10 00:47:29 +01:00
update_keytab.c	dlist: remove unneeded type argument from DLIST_ADD_END()	2016-02-06 21:48:17 +01:00
util.c	dsdb: Fix dsdb_next_callback to correctly use ldb_module_done() etc	2017-08-01 07:52:38 +02:00
util.h	dsdb: Ensure replication of renames works in schema partition	2017-06-15 01:24:25 +02:00
vlv_pagination.c	s4:samdb: Fix building Samba with -O3	2017-08-09 09:49:08 +02:00
wscript	dsdb/encrypted_secrets: remove dependency to libnettle and use our own aes_gcm_128_*()	2018-02-23 12:47:25 +01:00
wscript_build	dsdb/encrypted_secrets: remove dependency to libnettle and use our own aes_gcm_128_*()	2018-02-23 12:47:25 +01:00
wscript_build_server	dsdb/encrypted_secrets: remove dependency to libnettle and use our own aes_gcm_128_*()	2018-02-23 12:47:25 +01:00