1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
samba-mirror/source3
Volker Lendecke 49adb5ac8f winbind: Fix a race between the sigchld and 0-sized socket read
Fix a bug when a child dies when a request is pending in the child. If the
signal handler fires before epoll finds out the other end of the parent-child
socket is closed, we close the socket on our side without taking care of the
pending request. This causes two problems: First, that one pending request
never is replied to properly, and secondly, we might end up with EPOLL_DEL on a
wrong file descriptor. This causes all sorts of trouble if we hit an active
one.

The fix for this problem is not to close the socket in winbind_child_died().
This however stops an idle child that dies hard from being properly cleaned up.
The fix for that is to add the child->monitor_fde that is set pending only when
no child request is active. This way we can remove the close(sock) in the
signal handler.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13309

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2018-03-01 09:53:46 +01:00
..
auth s3:auth: Add FALL_THROUGH statements in pampass.c 2018-03-01 04:37:42 +01:00
build
client util/rfc1738_unescape(): return end pointer or NULL on error 2018-02-22 01:04:18 +01:00
exports
groupdb Correct "errror" typos. 2017-02-22 08:26:22 +01:00
include s3:smb_macros.h: add IS_AD_DC as addition to IS_DC 2018-02-23 12:47:25 +01:00
intl lib: Give util_paths.c its own header 2017-06-24 01:21:10 +02:00
lib s3:lib: Add FALL_THROUGH statements in util_sd.c 2018-03-01 04:37:42 +01:00
libads libads: Fix the build --without-ads 2018-02-06 02:47:43 +01:00
libgpo/gpext gpo: fix the building of gpext to only once 2017-11-20 21:41:14 +01:00
libnet s3:libnet: Add FALL_THROUGH statements in libnet_join.c 2018-03-01 04:37:43 +01:00
librpc smbd: remove "id" from share_mode_entry 2018-02-13 05:01:38 +01:00
libsmb libsmb: Remove incorrect fall through comment in trusts_util.c 2018-03-01 09:52:37 +01:00
locale pam_winbind: initial Turkish translation 2017-11-15 13:52:05 +01:00
locking smbd: remove "id" from share_mode_entry 2018-02-13 05:01:38 +01:00
modules s3:modules: Add FALL_THROUGH statements in getdate.c 2018-03-01 04:37:43 +01:00
nmbd libnmb: Move "read_packet" to nmbd 2018-01-24 05:48:19 +01:00
param s3/smbd: fix handling of delete-on-close on directories 2018-02-03 23:42:16 +01:00
passdb pdb: Fix CID 1427620 Resource leak 2018-01-17 19:24:11 +01:00
printing lib: Remove unused serverid.tdb 2017-12-05 04:58:26 +01:00
profile s3-profile: reduce dependencies of smbprofile.h 2016-03-28 20:45:16 +02:00
registry s3-rpc_cli: add winreg_add_core_driver() 2017-05-09 16:43:13 +02:00
rpc_client s3:cli_lsarpc: use talloc_zero_array() in dcerpc_lsa_lookup_names_generic() 2018-02-21 14:19:17 +01:00
rpc_server s3:spoolss: Remove incorrect fall through comment in srv_spoolss_nt.c 2018-03-01 04:37:44 +01:00
rpcclient s3:rpcclient: Add FALL_THROUGH statements in rpcclient.c 2018-03-01 04:37:43 +01:00
script Remove some bashisms from the test scripts 2018-02-19 07:36:23 +01:00
selftest s3:selftest: Run the smbtorture3 TLDAP test 2018-02-24 10:54:07 +01:00
services srcctl3: Improve debug messages 2018-01-16 02:43:03 +01:00
smbd s3:smbd: Add FALL_THROUGH statements in reply.c 2018-03-01 04:37:43 +01:00
torture s3:auth: Pass mem_ctx to init_guest_session_info() 2018-02-20 21:55:13 +01:00
utils s3:utils: Add FALL_THROUGH statements in ntlm_auth.c 2018-03-01 04:37:43 +01:00
web
winbindd winbind: Fix a race between the sigchld and 0-sized socket read 2018-03-01 09:53:46 +01:00
.clang_complete
.dmallocrc
.indent.pro
Doxyfile
mainpage.dox
smbadduser.in
wscript build: fix libceph-common detection 2018-02-22 19:30:12 +01:00
wscript_build tests: Add tests for parsing LDAPv3 and LDAPv2 filter strings 2018-02-19 23:47:08 +01:00
wscript_configure_system_ncurses