Martin Schwenke 4b01f54041 ctdb-recoverd: Drop unnecessary and broken code ... update_flags() has already updated the recovery master's canonical node map, based on the flags from each remote node, and pushed out these flags to all nodes. If i == j then the node map has already been updated from this remote node's flags, so simply drop this case. Although update_flags() has updated flags for all nodes, it did not update each node map in remote_nodemaps[] to reflect this. This means that remote_nodemaps[] may contain inconsistent flags for some nodes so it should not be used to check consistency when i != j. Further, a meaningful difference in flags can only really occur if update_flags() failed. In that case this code is never reached. These observations combine to imply that this whole loop should be dropped. This leaves potential sub-second inconsistencies due to out-of-band healthy/unhealthy flag changes pushed via CTDB_SRVID_PUSH_NODE_FLAGS. These updates could be dropped (takeover run asks each node for available IPs rather than making centralised decisions based on node flags) but for now they will be fixed in the next iteration of main_loop(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=14513 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>		2020-10-06 03:12:35 +00:00
..
ctdb_banning.c	ctdb-daemon: Drop unused function ctdb_local_node_got_banned()	2019-08-20 07:15:41 +00:00
ctdb_call.c	ctdb-daemon: Fix sorting of hot keys	2020-05-22 06:41:45 +00:00
ctdb_client.c	ctdb-recoverd: Move ctdb_ctrl_modflags() to ctdb_recoverd.c	2020-07-24 04:41:25 +00:00
ctdb_cluster_mutex.c	ctdb-mutex: Drop dependency on ctdb_set_helper	2019-07-26 03:34:17 +00:00
ctdb_cluster_mutex.h	ctdb-cluster-mutex: Fix #endif decoration	2016-06-08 04:52:18 +02:00
ctdb_config.c	ctdb-config: Switch tunable DisableIPFailover to a config option	2018-08-24 10:59:21 +02:00
ctdb_config.h	ctdb-config: Switch tunable DisableIPFailover to a config option	2018-08-24 10:59:21 +02:00
ctdb_control.c	ctdb-daemon: Drop implementation of old-style database pull/push controls	2020-09-11 06:29:32 +00:00
ctdb_daemon.c	ctdb-daemon: Fork when not interactive and test mode is enabled	2020-02-10 04:07:39 +00:00
ctdb_fork.c	ctdb-daemon: Add ctdb_vfork_exec()	2016-12-05 08:09:23 +01:00
ctdb_freeze.c	ctdb-daemon: Add implementation of VACUUM_FETCH control	2019-10-24 04:06:42 +00:00
ctdb_keepalive.c	ctdb-daemon: Fix signed/unsigned comparisons by declaring as unsigned	2019-07-05 05:03:23 +00:00
ctdb_lock_helper.c	ctdb-daemon: Fix signed/unsigned comparisons by declaring as unsigned	2019-07-05 05:03:23 +00:00
ctdb_lock.c	ctdb-daemon: Check for lock count underflow	2020-02-18 02:56:38 +00:00
ctdb_logging.c	ctdb-daemon: Drop unused function ctdb_vfork_with_logging()	2019-07-05 05:03:24 +00:00
ctdb_ltdb_server.c	ctdb-daemon: Add extra logging of hot keys	2020-05-22 06:41:45 +00:00
ctdb_monitor.c	ctdb-daemon: Only stop monitoring if it has been initialised	2020-01-28 09:57:32 +00:00
ctdb_mutex_fcntl_helper.c	lib: relicense smb_strtoul(l) under LGPLv3	2020-08-03 22:21:02 +00:00
ctdb_persistent.c	ctdb-daemon: Fix signed/unsigned comparisons by declaring as unsigned	2019-07-05 05:03:23 +00:00
ctdb_recover.c	ctdb-daemon: Drop implementation of old-style database pull/push controls	2020-09-11 06:29:32 +00:00
ctdb_recoverd.c	ctdb-recoverd: Drop unnecessary and broken code	2020-10-06 03:12:35 +00:00
ctdb_recovery_helper.c	ctdb-recovery: Simplify database push function names	2020-09-11 05:06:42 +00:00
ctdb_server.c	ctdb-daemon: more logical whitespace, debug modernisation	2020-03-12 03:47:30 +00:00
ctdb_statistics.c	ctdb-server: Replace ctdb_logging.h with common/logging.h	2015-11-16 00:46:15 +01:00
ctdb_takeover_helper.c	ctdb-daemon: Drop unused values assigned to variable	2019-07-05 05:03:23 +00:00
ctdb_takeover.c	Spelling fixes s/ dont / don't /	2019-09-01 22:21:27 +00:00
ctdb_traverse.c	ctdb-daemon: Fix signed/unsigned comparisons by declaring as unsigned	2019-07-05 05:03:23 +00:00
ctdb_tunables.c	ctdb-daemon: Use refactored tunable code	2016-07-25 21:29:46 +02:00
ctdb_tunnel.c	ctdb-daemon: Add code to process ctdb_req_tunnel packets	2017-10-10 11:45:19 +02:00
ctdb_update_record.c	ctdb-daemon: Fix signed/unsigned comparisons by declaring as unsigned	2019-07-05 05:03:23 +00:00
ctdb_uptime.c	ctdb-server: Replace ctdb_logging.h with common/logging.h	2015-11-16 00:46:15 +01:00
ctdb_vacuum.c	ctdb-vacuum: Reschedule vacuum event if VacuumInterval has increased	2020-04-07 03:04:57 +00:00
ctdbd.c	ctdb-daemon: Pass more information to ctdb_start_daemon()	2020-02-10 04:07:38 +00:00
eventscript.c	ctdb-daemon: Fix signed/unsigned comparisons by declaring as unsigned	2019-07-05 05:03:23 +00:00
ipalloc_common.c	ctdb-ipalloc: Avoid -1 as a PNN, use CTDB_UNKNOWN_PNN instead	2019-06-05 10:25:50 +00:00
ipalloc_deterministic.c	ctdb-takeover: IPAllocAlgorithm replaces LCP2PublicIPs, DeterministicIPs	2016-12-19 04:07:08 +01:00
ipalloc_lcp2.c	ctdb-ipalloc: Fix warning about unused value assigned to srcimbl	2019-06-05 10:25:50 +00:00
ipalloc_nondeterministic.c	ctdb-ipalloc: Avoid -1 as a PNN, use CTDB_UNKNOWN_PNN instead	2019-06-05 10:25:50 +00:00
ipalloc_private.h	ctdb-ipalloc: Fix signed/unsigned comparisons by declaring as unsigned	2019-06-05 10:25:50 +00:00
ipalloc.c	ctdb-ipalloc: Avoid -1 as a PNN, use CTDB_UNKNOWN_PNN instead	2019-06-05 10:25:50 +00:00
ipalloc.h	ctdb-daemon: Drop the noiphost "node flags" bitmap	2018-07-11 11:48:38 +02:00
legacy_conf.c	ctdb-config: Change option "no realtime" option to "realtime scheduling"	2018-08-24 10:59:20 +02:00
legacy_conf.h	ctdb-config: Change option "no realtime" option to "realtime scheduling"	2018-08-24 10:59:20 +02:00