1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
samba-mirror/source3/param
Uri Simchoni d4c2395e64 smbd: do not disable "store dos attributes" on-the-fly
Smbd would disable "store dos attributes" on-the-fly if the
attempt to set/get user.DOSATTRIB fails with ENOTSUP or ENOSYS.
The rationale behind it was that the file system does not support
extended attributes, so there's no need to fill up the log with
failure messages.

However, a "wide symlink" could point to a spot that doesn't support
extended attributes. Even with the default banned wide links, we
currenly allow stat'ing those files and follow the symlink, and this
in turn would disable "store dos attributes" for the whole share.
The user.DOSATTRIB attribute also stores file creation time,
so that is also affected.

Another case where this behavior would turn storage of DOS attributes
off is that of the ".." entry at the root of the share, if the parent
folder for the share's root path does not support extended attributes.

On the other hand, the information on the file system and its support
of extended attributes is readily available, so the fix for explosion
of the log should be not to configure "store dos attributes" on
such a share.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11649

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Dec 25 13:20:58 CET 2015 on sn-devel-144
2015-12-25 13:20:58 +01:00
..
loadparm_ctx.c s3:param: use lp_load_no_reinit() in lp_load_for_s4_ctx() 2015-04-22 13:57:30 +02:00
loadparm.c smbd: do not disable "store dos attributes" on-the-fly 2015-12-25 13:20:58 +01:00
pyparam.c s3-param: Rename loadparm_s3_context -> loadparm_s3_helpers 2012-06-27 17:11:16 +02:00
service.c param: remove unused get_share_params() 2014-11-26 21:27:21 +01:00
test_lp_load.c s3:param: remove arg save_defaults from lp_load_with_registry_shares() 2015-04-22 13:57:30 +02:00
util.c Change all uses of uint32/16/8 in proto.h to uint32_t/16_t/8_t. 2015-04-29 23:42:20 +02:00
wscript_build param: change s3_param.h from a generated file to a static one 2014-02-20 10:11:20 +13:00