sin/samba-mirror
1
0
Fork 0
mirror of https://github.com/samba-team/samba.git synced 2025-01-07 17:18:11 +03:00
Code
5259926de7
samba-mirror/source4/torture/smb2
History
Douglas Bagnall 5259926de7 s4/torture/smb2: avoid possibly closing undefined handle 
From OSS-Fuzz compilation:

Step #3 - "compile-honggfuzz-address-x86_64": ../../source4/torture/smb2/dir.c:1456:2: error: variable 'dir_handle' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
Step #3 - "compile-honggfuzz-address-x86_64":         torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
Step #3 - "compile-honggfuzz-address-x86_64":         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Step #3 - "compile-honggfuzz-address-x86_64": ../../lib/torture/torture.h:748:3: note: expanded from macro 'torture_assert_ntstatus_ok_goto'
Step #3 - "compile-honggfuzz-address-x86_64":                 torture_assert_ntstatus_equal_goto(torture_ctx,expr,NT_STATUS_OK,ret,label,cmt)
Step #3 - "compile-honggfuzz-address-x86_64":                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Step #3 - "compile-honggfuzz-address-x86_64": ../../lib/torture/torture.h:316:6: note: expanded from macro 'torture_assert_ntstatus_equal_goto'
Step #3 - "compile-honggfuzz-address-x86_64":         if (!NT_STATUS_EQUAL(__got, __expected)) { \
Step #3 - "compile-honggfuzz-address-x86_64":             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Step #3 - "compile-honggfuzz-address-x86_64": ../../source4/torture/smb2/dir.c:1582:24: note: uninitialized use occurs here
Step #3 - "compile-honggfuzz-address-x86_64":         smb2_util_close(tree, dir_handle);
Step #3 - "compile-honggfuzz-address-x86_64":                               ^~~~~~~~~~
Step #3 - "compile-honggfuzz-address-x86_64": ../../source4/torture/smb2/dir.c:1456:2: note: remove the 'if' if its condition is always false
Step #3 - "compile-honggfuzz-address-x86_64":         torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
Step #3 - "compile-honggfuzz-address-x86_64":         ^
Step #3 - "compile-honggfuzz-address-x86_64": ../../lib/torture/torture.h:748:3: note: expanded from macro 'torture_assert_ntstatus_ok_goto'
Step #3 - "compile-honggfuzz-address-x86_64":                 torture_assert_ntstatus_equal_goto(torture_ctx,expr,NT_STATUS_OK,ret,label,cmt)
Step #3 - "compile-honggfuzz-address-x86_64":                 ^
Step #3 - "compile-honggfuzz-address-x86_64": ../../lib/torture/torture.h:316:2: note: expanded from macro 'torture_assert_ntstatus_equal_goto'
Step #3 - "compile-honggfuzz-address-x86_64":         if (!NT_STATUS_EQUAL(__got, __expected)) { \
Step #3 - "compile-honggfuzz-address-x86_64":         ^
Step #3 - "compile-honggfuzz-address-x86_64": ../../source4/torture/smb2/dir.c:1434:2: note: variable 'dir_handle' is declared here
Step #3 - "compile-honggfuzz-address-x86_64":         struct smb2_handle dir_handle;
Step #3 - "compile-honggfuzz-address-x86_64":         ^

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Dec 13 07:45:20 UTC 2022 on sn-devel-184
2022-12-13 07:45:20 +00:00
..
acls.c s4:torture: Migrate smbtorture to new cmdline option parser 2021-06-16 00:34:38 +00:00
attr.c torture: add another simple DOS attributes test 2022-12-09 23:11:38 +00:00
block.c s4:torture/smb2: move smb2_transport blocking to the generic block.[ch] 2020-07-08 15:54:39 +00:00
block.h s4:torture/smb2: move smb2_transport blocking to the generic block.[ch] 2020-07-08 15:54:39 +00:00
charset.c s4:torture: Convert samba4.base.charset test to smb2 2020-01-30 12:05:13 +00:00
compound.c s4: torture: Add compound_async.read_read test to show we don't go async on the last read in a compound. 2022-12-01 15:04:58 +00:00
connect.c torture: fix mem leak found by ASAN (smb2_connect) 2019-08-21 15:42:43 +00:00
create.c torture: add an interactive test that works out maximum name and path lenghts 2022-12-09 23:11:38 +00:00
credits.c s4: torture: Add a TALLOC_CTX * to torture_smb2_crediting_init(). 2017-05-05 15:52:12 +02:00
delete-on-close.c s4:torture/smb2: add smb2.delete-on-close-perms.BUG14427 2020-07-02 15:25:31 +00:00
deny.c Convert samba4.base.deny* tests to smb2 2020-06-24 20:50:24 +00:00
dir.c s4/torture/smb2: avoid possibly closing undefined handle 2022-12-13 07:45:20 +00:00
dosmode.c CI: add test "smb2.async_dosmode" 2022-02-28 20:01:36 +00:00
durable_open.c s4:torture: remove remaining checks if alloc_size is 0 on empty files 2022-12-09 23:11:38 +00:00
durable_v2_open.c s4: torture: Add regression test for re-opening a durable handle after calling SMB2 setinfo (end of file). 2022-03-24 16:28:37 +00:00
ea.c Fix spelling mistakes. 2022-09-12 02:29:32 +00:00
getinfo.c smbtorture: check required access for SMB2-GETINFO 2022-08-23 11:52:29 +00:00
ioctl.c s3: smbd: Add test to show smbd crashes when doing an FSCTL on a named stream handle. 2022-11-14 17:13:36 +00:00
lease_break_handler.c s4:torture/smb2: provide verbose output when we're waiting for potential lease/oplock breaks 2021-03-29 19:36:37 +00:00
lease_break_handler.h s4-torture: Add handlers to ignore incoming oplock/lease break requests 2019-04-19 17:27:13 +00:00
lease.c s4:torture/smb2: add smb2.lease.v[1,2]_bug_15148 2022-08-18 18:45:34 +00:00
lock.c s4:torture/smb2: split replay_smb3_specification into durable handle and multichannel 2020-07-14 13:38:35 +00:00
mangle.c torture: test that a find with a mangled name works 2022-12-10 00:07:09 +00:00
max_allowed.c smbtorture: add a test opening a READ-ONLY file with SEC_FLAG_MAXIMUM_ALLOWED 2022-08-29 17:22:32 +00:00
maxfid.c s4/torture: move deletion out of close loop in torture_smb2_maxfid() 2021-01-28 08:11:49 +00:00
maxwrite.c s4:torture:smb2:maxwrite: compile maxwrite test at least. 2016-09-07 12:09:16 +02:00
mkdir.c s4:torture: Convert samba3.raw.mkdir test to smb2 2020-04-28 19:46:32 +00:00
multichannel.c s4:torture: remove remaining checks if alloc_size is 0 on empty files 2022-12-09 23:11:38 +00:00
notify_disabled.c s4:torture: Migrate smbtorture to new cmdline option parser 2021-06-16 00:34:38 +00:00
notify.c source4/torture: Drop unused variable mask 2022-02-17 18:12:52 +00:00
oplock_break_handler.c s4:torture/smb2: provide verbose output when we're waiting for potential lease/oplock breaks 2021-03-29 19:36:37 +00:00
oplock_break_handler.h s4:torture/smb2: add break_info.oplock_skip_ack 2020-07-08 15:54:39 +00:00
oplock.c s4/libcli/smb2: avoid using smb2_composite_setpathinfo() in smb2_util_setatr() 2022-08-23 11:52:29 +00:00
read_write.c s4:torture:smb2: use delete-on-close in test_rw_invalid() 2020-06-05 13:17:55 +00:00
read.c s4:torture/smb2: add smb2.read.bug14607 test 2021-07-15 23:04:34 +00:00
rename.c torture: add a test veryfing timestamps across rename 2022-12-09 23:11:38 +00:00
replay.c s4:torture: Migrate smbtorture to new cmdline option parser 2021-06-16 00:34:38 +00:00
samba3misc.c s4:torture/smb2: try to fix a RESOURCE_LEAK in smb2.samba3misc.localposixlock1 2019-09-10 18:56:45 +00:00
scan.c s4:torture: Migrate smbtorture to new cmdline option parser 2021-06-16 00:34:38 +00:00
secleak.c s4:torture: Convert samba4.base.secleak test to smb2 2020-06-24 20:50:24 +00:00
sessid.c s4:torture: Convert samba4.base.vuid test to smb2 2020-06-24 20:50:24 +00:00
session.c Fix spelling mistakes. 2022-09-12 02:29:32 +00:00
setinfo.c s4:torture:smb2 prefer torture_comment() to printf(). 2016-09-07 12:09:17 +02:00
sharemode.c torture/sharemode: fix empty initializer compile warning 2020-11-10 06:53:43 +00:00
smb2.c torture: convert mangling test to a suite 2022-12-09 23:11:38 +00:00
streams.c smbtorture: add test smb2.stream.attributes2 2022-08-22 08:02:35 +00:00
tcon.c s4:torture: Convert samba4.base.tcon test to smb2 2020-04-28 18:09:39 +00:00
timestamps.c s4:torture: remove remaining checks if alloc_size is 0 on empty files 2022-12-09 23:11:38 +00:00
util.c s4:torture: Migrate smbtorture to new cmdline option parser 2021-06-16 00:34:38 +00:00
wscript_build vfs_acl_xattr: add acl_xattr:security_acl_name option 2022-06-27 15:50:29 +00:00