1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
samba-mirror/source3/rpc_client
Noel Power 253c5585c9 s3/rpc_client: Fix array offset check
Previous to this commit we were modifying the offset before
the array offset check. This was causing a spurious debug
message indicating the offset was out of bounds. An second
problem is that upon detecting the error we don't exit the loop.
A third problem was that when reading the offset the check
didn't cater for the size of the integer address about to be read.

This commit moves the offset check to before the first read,
additionally when an error is detected now we actually exit the loop
and the offset have been corrected to include the size of the
integer to be read

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15579
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sat Feb 17 17:58:43 UTC 2024 on atb-devel-224

(cherry picked from commit 885850b6aa)

Autobuild-User(v4-20-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-20-test): Mon Feb 26 10:37:37 UTC 2024 on atb-devel-224
2024-02-26 10:37:37 +00:00
..
cli_lsarpc.c s3:rpc_client: Remove unused rpccli_lsa_open_policy2() 2023-11-21 12:21:18 +00:00
cli_lsarpc.h s3:rpc_client: Remove unused rpccli_lsa_open_policy2() 2023-11-21 12:21:18 +00:00
cli_mdssvc_private.h CVE-2023-34968: mdscli: return share relative paths 2023-07-21 12:05:35 +00:00
cli_mdssvc_util.c CVE-2023-34968: mdscli: return share relative paths 2023-07-21 12:05:35 +00:00
cli_mdssvc_util.h CVE-2023-34968: mdscli: return share relative paths 2023-07-21 12:05:35 +00:00
cli_mdssvc.c s3:rpc_client: Add missing newlines to logging messages 2023-08-08 04:39:38 +00:00
cli_mdssvc.h s3:rpc_client: add a mdssvc client library 2019-10-09 14:35:28 +00:00
cli_netlogon.c CVE-2022-38023 libcli/auth: pass lp_ctx to netlogon_creds_cli_set_global_db() 2022-12-13 13:07:29 +00:00
cli_netlogon.h s3:winbind: Pass the challenge to winbind_dual_SamLogon() as a data blob 2022-04-30 00:10:34 +00:00
cli_pipe_schannel.c s3:rpc_client: Pass remote name and socket to cli_rpc_pipe_open_schannel_with_creds() 2021-12-02 13:59:31 +00:00
cli_pipe.c librpc:ndr: Introduce ‘ndr_flags_type’ type 2023-11-01 20:10:45 +00:00
cli_pipe.h librpc: Make rpc_pipe_open_np() public and async 2023-03-06 21:32:35 +00:00
cli_samr.c s3:rpc_client: Fix code spelling 2023-07-19 09:58:37 +00:00
cli_samr.h s3:rpc_client: Fix code spelling 2023-07-19 09:58:37 +00:00
cli_spoolss.c s3:rpc_client: Fix code spelling 2023-09-11 02:42:41 +00:00
cli_spoolss.h
cli_winreg_int.c rpcclient: Fix a DBG msg: This is not dcerpc_winreg_int_openkey() 2021-03-16 17:09:32 +00:00
cli_winreg_int.h s3:rpc_client: Fix code spelling 2023-07-19 09:58:37 +00:00
cli_winreg_spoolss.c lib;smbd: Fix the -Os build by initializing variables 2021-08-06 17:22:30 +00:00
cli_winreg_spoolss.h s3:rpc_client: Fix code spelling 2023-07-19 09:58:37 +00:00
cli_winreg.c rpc_client: talloc_stackframe() aborts on failure 2021-04-19 18:18:31 +00:00
cli_winreg.h s3:rpc_client: Fix code spelling 2023-07-19 09:58:37 +00:00
init_lsa.c
init_lsa.h
init_samr.c s3:rpcclient: Pass salt down to init_samr_CryptPasswordAES() 2022-10-25 09:34:33 +00:00
init_samr.h s3:rpcclient: Pass salt down to init_samr_CryptPasswordAES() 2022-10-25 09:34:33 +00:00
init_spoolss.c
init_spoolss.h
local_np.c librpc: Fix error path cleanups in start_rpc_host_send() 2023-11-07 12:46:37 +00:00
local_np.h s3:rpc_client: Add local_np_connect() 2021-12-10 14:02:30 +00:00
py_mdscli.c Use python.h from libreplace 2023-11-20 15:37:33 +00:00
rpc_client.h
rpc_transport_np.c s3:rpc_client: Add missing newlines to logging messages 2023-08-08 04:39:38 +00:00
rpc_transport_sock.c
rpc_transport_tstream.c add accessor for tstream_context 2023-10-25 22:23:38 +00:00
rpc_transport.h add accessor for tstream_context 2023-10-25 22:23:38 +00:00
util_netlogon.c s3:rpc_client: Fix memory allocation hierarchy 2022-04-30 00:10:34 +00:00
util_netlogon.h s3-rpc_client: add copy_netr_DsRGetDCNameInfo() helper 2021-07-14 16:49:30 +00:00
wsp_cli.c s3/rpc_client: Fix array offset check 2024-02-26 10:37:37 +00:00
wsp_cli.h libcli/wsp: Add simple client api for wsp client code. 2023-10-25 22:23:38 +00:00