1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
samba-mirror/ctdb
Martin Schwenke 56d526c6ea ctdb-scripts: ctdbd_wrapper should never remove the PID file
kill_ctdbd() kills the daemon and then removes the PID file.  This is
racy because a new daemon could write a new PID file in between the
kill and the removal.  Reversing these steps would be an improvement.

However, none of the places where kill_ctdbd() is called is a safe
place to remove the PID file.  There is always a chance that a new
daemon could start, write a new PID file and then kill_ctdbd() could
remove the new PID file.

ctdbd is able to overwrite a stale PID file by checking to see if it
is locked.

Therefore, entirely drop removal of the PID file from ctdbd_wrapper.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12287

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
2016-10-13 14:25:09 +02:00
..
client ctdb-client: Print error message before next syscall to avoid losing errno 2016-08-17 23:00:25 +02:00
common ctdb-common: Add routines to manage PID file 2016-09-22 08:34:20 +02:00
config ctdb-scripts: ctdbd_wrapper should never remove the PID file 2016-10-13 14:25:09 +02:00
doc ctdb-tools: Addition of IPs is deferred until the next takeover run 2016-08-17 05:28:19 +02:00
ib ctdb-ib: Fix DEBUG log messages 2016-08-10 08:18:16 +02:00
include ctdb-daemon: Remove NUM_DB_PRIORITIES 2016-09-14 08:39:28 +02:00
packaging ctdb-packaging: Stop RPM from renaming working config to ctdb.rpmsave 2016-08-08 11:30:57 +02:00
protocol ctdb-protocol: Fix marshalling for GET_DB_SEQNUM control request 2016-09-14 08:39:28 +02:00
server ctdb-daemon: Log when removing stale Unix domain socket 2016-09-22 12:28:12 +02:00
tcp ctdb-tcp: Fix CID 1362724 Unchecked return value from library 2016-08-17 23:00:25 +02:00
tests ctdb-scripts: Dump stack traces of smbd processes after shutdown 2016-10-10 12:54:24 +02:00
tools ctdb-tools: CID 1125617 String not null terminated (STRING_NULL) 2016-09-08 06:57:21 +02:00
utils ctdb-pmda: Use 1s timeout for fetching statistics 2016-08-12 00:32:17 +02:00
.bzrignore more code rearrangement 2007-06-07 22:16:48 +10:00
.gitignore git: Ignore generated documentation files 2013-10-22 13:07:13 +11:00
configure ctdb-build: Allow configure and Makefile to find waf in tarball 2014-09-10 01:36:14 +02:00
configure.rpm ctdb-packaging: Package private libraries 2015-07-01 07:19:43 +02:00
COPYING add a licence file 2009-02-07 08:10:34 +11:00
Makefile ctdb-build: Allow configure and Makefile to find waf in tarball 2014-09-10 01:36:14 +02:00
README doc: README - add information about CTDB, license and website 2012-10-22 17:39:49 +11:00
wscript ctdb-common: Add routines to manage PID file 2016-09-22 08:34:20 +02:00

This is the release version of CTDB, a clustered implementation of TDB
database used by Samba and other projects to store temporary data.

This software is freely distributable under the GNU public license,
a copy of which you should have received with this software (in a file
called COPYING).

For documentation on CTDB, please visit CTDB website http://ctdb.samba.org.