mirror of
https://github.com/samba-team/samba.git
synced 2024-12-22 13:34:15 +03:00
0ff1b78fc2
Since commit 77deaadca8, a nodeA which
had previously accepted a connection from nodeB (where nodeB dies
e.g. as as result of fencing) when nodeB attempts to connect again
after restarting is always rejected with
ctdb_listen_event: Incoming queue active, rejecting connection from w.x.y.z
messages.
Consolidate dead node handling in the TCP restart handling.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14295
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
97 lines
2.5 KiB
C
97 lines
2.5 KiB
C
/*
|
|
ctdb over TCP
|
|
|
|
Copyright (C) Andrew Tridgell 2006
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "replace.h"
|
|
#include "system/network.h"
|
|
#include "system/filesys.h"
|
|
|
|
#include "lib/util/dlinklist.h"
|
|
#include "lib/util/debug.h"
|
|
|
|
#include "ctdb_private.h"
|
|
|
|
#include "common/common.h"
|
|
#include "common/logging.h"
|
|
|
|
#include "ctdb_tcp.h"
|
|
|
|
|
|
/*
|
|
called when a complete packet has come in
|
|
*/
|
|
void ctdb_tcp_read_cb(uint8_t *data, size_t cnt, void *args)
|
|
{
|
|
struct ctdb_node *node = talloc_get_type_abort(args, struct ctdb_node);
|
|
struct ctdb_tcp_node *tnode = talloc_get_type_abort(
|
|
node->transport_data, struct ctdb_tcp_node);
|
|
struct ctdb_req_header *hdr = (struct ctdb_req_header *)data;
|
|
|
|
if (data == NULL) {
|
|
/* incoming socket has died */
|
|
goto failed;
|
|
}
|
|
|
|
if (cnt < sizeof(*hdr)) {
|
|
DEBUG(DEBUG_ALERT,(__location__ " Bad packet length %u\n", (unsigned)cnt));
|
|
goto failed;
|
|
}
|
|
|
|
if (cnt & (CTDB_TCP_ALIGNMENT-1)) {
|
|
DEBUG(DEBUG_ALERT,(__location__ " Length 0x%x not multiple of alignment\n",
|
|
(unsigned)cnt));
|
|
goto failed;
|
|
}
|
|
|
|
if (hdr->ctdb_magic != CTDB_MAGIC) {
|
|
DEBUG(DEBUG_ALERT,(__location__ " Non CTDB packet 0x%x rejected\n",
|
|
hdr->ctdb_magic));
|
|
goto failed;
|
|
}
|
|
|
|
if (hdr->ctdb_version != CTDB_PROTOCOL) {
|
|
DEBUG(DEBUG_ALERT, (__location__ " Bad CTDB version 0x%x rejected\n",
|
|
hdr->ctdb_version));
|
|
goto failed;
|
|
}
|
|
|
|
/* tell the ctdb layer above that we have a packet */
|
|
tnode->ctdb->upcalls->recv_pkt(tnode->ctdb, data, cnt);
|
|
return;
|
|
|
|
failed:
|
|
node->ctdb->upcalls->node_dead(node);
|
|
|
|
TALLOC_FREE(data);
|
|
}
|
|
|
|
/*
|
|
queue a packet for sending
|
|
*/
|
|
int ctdb_tcp_queue_pkt(struct ctdb_node *node, uint8_t *data, uint32_t length)
|
|
{
|
|
struct ctdb_tcp_node *tnode = talloc_get_type(node->transport_data,
|
|
struct ctdb_tcp_node);
|
|
if (tnode->out_queue == NULL) {
|
|
DBG_DEBUG("No outgoing connection, dropping packet\n");
|
|
return 0;
|
|
}
|
|
|
|
return ctdb_queue_send(tnode->out_queue, data, length);
|
|
}
|