1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-28 07:21:54 +03:00
https://gitlab.com/samba-team/samba is the Official GitLab mirror of https://git.samba.org/samba.git -- Merge requests should be made on GitLab (not on GitHub)
Go to file
Andreas Schneider 57ff5a33e9 s4:torture: Fix stack variable used out of scope in test_devicemode_full()
==17828==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffc37790230 at pc 0x7fc37e2a3a11 bp 0x7ffc3778fec0 sp 0x7ffc3778feb8
READ of size 16 at 0x7ffc37790230 thread T0
    #0 0x7fc37e2a3a10 in ndr_push_spoolss_GetPrinter librpc/gen_ndr/ndr_spoolss.c:27123
    #1 0x7fc380629b30 in dcerpc_binding_handle_call_send ../../librpc/rpc/binding_handle.c:416
    #2 0x7fc38062a132 in dcerpc_binding_handle_call ../../librpc/rpc/binding_handle.c:553
    #3 0x7fc37ed113c9 in dcerpc_spoolss_GetPrinter_r librpc/gen_ndr/ndr_spoolss_c.c:1947
    #4 0x5570ba6c4d03 in test_devicemode_full ../../source4/torture/rpc/spoolss.c:2249
    #5 0x5570ba6e61ea in test_PrinterInfo_DevModes ../../source4/torture/rpc/spoolss.c:2384
    #6 0x5570ba6e61ea in test_PrinterInfo_DevMode ../../source4/torture/rpc/spoolss.c:2488
    #7 0x5570ba6e61ea in test_printer_dm ../../source4/torture/rpc/spoolss.c:9082
    #8 0x7fc37fc7b67d in wrap_test_with_simple_test ../../lib/torture/torture.c:808
    #9 0x7fc37fc7d40b in internal_torture_run_test ../../lib/torture/torture.c:516
    #10 0x7fc37fc7d87c in torture_run_tcase_restricted ../../lib/torture/torture.c:581
    #11 0x7fc37fc7deb2 in torture_run_suite_restricted ../../lib/torture/torture.c:435
    #12 0x5570ba89a65d in run_matching ../../source4/torture/smbtorture.c:95
    #13 0x5570ba89a6e4 in run_matching ../../source4/torture/smbtorture.c:105
    #14 0x5570ba89a6e4 in run_matching ../../source4/torture/smbtorture.c:105
    #15 0x5570ba89b3e4 in torture_run_named_tests ../../source4/torture/smbtorture.c:172
    #16 0x5570ba89f3e0 in main ../../source4/torture/smbtorture.c:750
    #17 0x7fc37c62c5af in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
    #18 0x7fc37c62c678 in __libc_start_main_impl ../csu/libc-start.c:381
    #19 0x5570ba49e824 in _start ../sysdeps/x86_64/start.S:115

Address 0x7ffc37790230 is located in stack of thread T0 at offset 160 in frame
    #0 0x5570ba6c4562 in test_devicemode_full ../../source4/torture/rpc/spoolss.c:2186

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Dec 20 06:55:45 UTC 2022 on sn-devel-184
2022-12-20 06:55:45 +00:00
.github Added redirect from GitHub to GitLab 2018-12-05 16:35:33 +01:00
auth build: Remove unused dependencies 2022-11-08 02:39:37 +00:00
bootstrap gitlab-ci: do some basic testing on ubuntu1804-32bit 2022-11-24 12:05:26 +00:00
buildtools CVE-2022-37966 wafsamba: add support for CHECK_VARIABLE(mandatory=True) 2022-12-13 13:07:30 +00:00
coverity coverity: Add modeling file for Coverity scan 2017-02-23 07:11:18 +01:00
ctdb ctdb: Fix a use-after-free in run_proc 2022-10-06 15:10:20 +00:00
dfs_server dfs_server: Fix typos 2022-08-26 18:54:37 +00:00
docs-xml CVE-2022-37966 samba-tool: add 'domain trust modify' command 2022-12-13 13:07:30 +00:00
dynconfig dynconfig: Introduce and expose SAMBA_LIBEXECDIR 2021-04-01 19:32:36 +00:00
examples build: Convert winexe to use enabled= in wscript 2022-12-16 07:41:38 +00:00
file_server s3: Remove --log-stdout from daemons 2021-04-29 03:58:37 +00:00
include
lib compression/huffman: debug function bails upon disaster (CID 1517261) 2022-12-19 23:29:04 +00:00
libcli libcldap: Save lines in cldap_netlogon_create_filter() with talloc_asprintf_addbuf() 2022-12-14 04:32:34 +00:00
libds/common lib: Move 448 bytes from R/W data segment to R/O text 2022-12-15 22:51:06 +00:00
libgpo s3-librpc: add ads.idl and convert ads_struct to talloc. 2022-12-16 20:38:32 +00:00
librpc smbd: Remove source3/smbd/statcache.c 2022-12-14 22:54:29 +00:00
nsswitch nsswitch: Align integer types 2022-12-12 21:16:33 +00:00
packaging ctdb-scripts: Drop uses of ctdbd_wrapper 2022-04-06 06:34:37 +00:00
pidl rpc_server3: Remove pipes_struct->auth 2022-01-05 00:11:38 +00:00
python tests: add a Python test for case insensitive access 2022-12-20 01:32:07 +00:00
release-scripts release-script: Fix shellcheck errors 2022-08-17 11:03:54 +00:00
script gitlab-ci: do some basic testing on ubuntu1804-32bit 2022-11-24 12:05:26 +00:00
selftest smbd: Add "posix" flag to openat_pathref_dirfsp_nosymlink() 2022-12-15 11:30:04 +00:00
source3 rpc_server:srvsvc - retrieve share ACL via root context 2022-12-19 20:41:15 +00:00
source4 s4:torture: Fix stack variable used out of scope in test_devicemode_full() 2022-12-20 06:55:45 +00:00
testdata lib/compression: add test data for lzxpress plain compression 2022-12-01 22:56:40 +00:00
testprogs testprogs: Use new kerberos options for samba-tool in test_kpasswd_mit.sh 2022-12-14 23:56:50 +00:00
tests readlink test: inverse return code 2022-02-18 22:17:33 +00:00
testsuite testsuite: Reformat shell scripts 2022-08-10 13:17:31 +00:00
third_party CVE-2022-37966 kdc: Implement new Kerberos session key behaviour since ENC_HMAC_SHA1_96_AES256_SK was added 2022-12-13 13:07:30 +00:00
wintest wintest: Remove unreachable return statement 2022-05-10 05:19:34 +00:00
.bzrignore
.clang-format Add a .clang-format file 2022-07-20 18:23:49 +00:00
.editorconfig editorconfig: We always inserted a new line so keep doing that 2022-02-28 10:22:34 +00:00
.gitattributes gitattributes: Ignore .SAMBABACKUP files 2018-08-16 23:42:22 +02:00
.gitignore gitignore: Add .ropeproject for pylsp-rope plugin 2022-05-11 00:04:55 +00:00
.gitlab-ci-coverage-runners.yml add .gitlab-ci-coverage.yml for a scheduled build 2021-04-13 09:33:14 +00:00
.gitlab-ci-coverage.yml add .gitlab-ci-coverage.yml for a scheduled build 2021-04-13 09:33:14 +00:00
.gitlab-ci-default-runners.yml .gitlab-ci*.yml: only use gitlab.org shared runners if possible 2021-04-13 08:23:35 +00:00
.gitlab-ci-default.yml .gitlab-ci.yml: Honour AUTOBUILD_SKIP_SAMBA_O3 in GitLab CI 2021-10-13 11:10:44 +00:00
.gitlab-ci-main.yml gitlab-ci: do some basic testing on ubuntu1804-32bit 2022-11-24 12:05:26 +00:00
.gitlab-ci-private.yml .gitlab-ci.yml: move the content to .gitlab-ci-main.yml 2021-04-13 08:23:35 +00:00
.gitlab-ci.yml .gitlab-ci.yml: move the content to .gitlab-ci-main.yml 2021-04-13 08:23:35 +00:00
.testr.conf testr: Use waf testonly and create a custom directory for new workers. 2014-10-14 06:44:07 +02:00
.ycm_extra_conf.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
callcatcher-exceptions.grep
configure configure/Makefile: export PYTHONHASHSEED=1 in all 'configure/Makefile' scripts 2022-03-29 22:32:32 +00:00
configure.developer
COPYING
GPG_AA99442FB680B620_replaces_6F33915B6568B7EA.txt ReleaseKey: add GnuPG key transition statement for the Samba release key 2021-01-21 13:57:45 +01:00
Makefile Makefile: add support for 'make testonly' 2021-01-27 09:56:29 +00:00
PFIF.txt docs: protocolfreedom.org is no longer 2020-06-12 22:11:43 +00:00
README.cifs-utils
README.Coding.md README.Coding: PRINT format specifiers PRIuxx 2022-07-21 13:47:31 +00:00
README.contributing Rename Samba's DCO to Samba Developer's Declaration 2020-10-20 22:54:01 +00:00
README.md Update README.md with more up to date information 2020-06-12 22:11:43 +00:00
SECURITY.md Update SECURITY.md to point to security releases 2020-06-03 15:55:10 +00:00
setup.cfg pep8 tidy up config 2020-12-17 00:54:51 +00:00
VERSION VERSION: Bump version up to 4.18.0pre1... 2022-08-08 16:22:13 +02:00
VFS-License-clarification.txt VFS-License-clarification: minor improvements aligning w/ GPLv3 text 2020-11-04 21:29:40 +00:00
WHATSNEW.txt WHATSNEW: samba-tool: fewer tracebacks, more colour 2022-09-19 07:14:31 +00:00
wscript tsocket: Fix the build on FreeBSD 2022-12-12 21:16:33 +00:00
wscript_build s4:lib: Remove obsolete popt cmdline parser 2021-06-20 23:26:32 +00:00
wscript_build_embedded_heimdal wafsamba: Remove clangdb code which doesn't work 2022-01-21 23:33:36 +00:00
wscript_build_system_heimdal wscript: Correctly determine dependencies for system Heimdal build 2022-11-08 02:39:37 +00:00
wscript_build_system_mitkrb5 wafsamba: Remove clangdb code which doesn't work 2022-01-21 23:33:36 +00:00
wscript_configure_embedded_heimdal HEIMDAL: move code from source4/heimdal* to third_party/heimdal* 2022-01-19 21:41:59 +00:00
wscript_configure_system_gnutls waf: Check for gnutls_pbkdf2() 2022-07-28 11:51:29 +00:00
wscript_configure_system_heimdal wscript: Correctly determine dependencies for system Heimdal build 2022-11-08 02:39:37 +00:00
wscript_configure_system_mitkrb5 CVE-2022-37966 system_mitkrb5: require support for aes enctypes 2022-12-13 13:07:30 +00:00

About Samba

Samba is the standard Windows interoperability suite of programs for Linux and Unix. Samba is Free Software licensed under the GNU General Public License and the Samba project is a member of the Software Freedom Conservancy. Since 1992, Samba has provided secure, stable and fast file and print services for all clients using the SMB/CIFS protocol, such as all versions of DOS and Windows, OS/2, Linux and many others. Samba is an important component to seamlessly integrate Linux/Unix Servers and Desktops into Active Directory environments. It can function both as a domain controller or as a regular domain member.

For the AD DC implementation a full HOWTO is provided at: https://wiki.samba.org/index.php/Samba4/HOWTO

Community guidelines can be read at: https://wiki.samba.org/index.php/How_to_do_Samba:_Nicely

This software is freely distributable under the GNU public license, a copy of which you should have received with this software (in a file called COPYING).

CONTRIBUTIONS

Please see https://wiki.samba.org/index.php/Contribute for detailed set-by-step instructions on how to submit a patch for Samba via GitLab.

Samba's GitLab mirror is at https://gitlab.com/samba-team/samba

OUR CONTRIBUTORS

See https://www.samba.org/samba/team/ for details of the Samba Team, as well as details of all those currently active in Samba development.

If you like a particular feature then look through the git change-log (on the web at https://gitweb.samba.org/?p=samba.git;a=summary) and see who added it, then send them an email.

Remember that free software of this kind lives or dies by the response we get. If no one tells us they like it then we'll probably move onto something else.

MORE INFO

DOCUMENTATION

There is quite a bit of documentation included with the package, including man pages and the wiki at https://wiki.samba.org

If you would like to help with our documentation, please contribute that improved content to the wiki, we are moving as much content there as possible.

MAILING LIST

Please do NOT send subscription/unsubscription requests to the lists!

There is a mailing list for discussion of Samba. For details go to https://lists.samba.org/ or send mail to samba-subscribe@lists.samba.org

There is also an announcement mailing list where new versions are announced. To subscribe go to https://lists.samba.org/ or send mail to samba-announce-subscribe@lists.samba.org. All announcements also go to the samba list, so you only need to be on one.

For details of other Samba mailing lists and for access to archives, see https://lists.samba.org/

MAILING LIST ETIQUETTE

A few tips when submitting to this or any mailing list.

  1. Make your subject short and descriptive. Avoid the words "help" or "Samba" in the subject. The readers of this list already know that a) you need help, and b) you are writing about samba (of course, you may need to distinguish between Samba PDC and other file sharing software). Avoid phrases such as "what is" and "how do i". Some good subject lines might look like "Slow response with Excel files" or "Migrating from Samba PDC to NT PDC".

  2. If you include the original message in your reply, trim it so that only the relevant lines, enough to establish context, are included. Chances are (since this is a mailing list) we've already read the original message.

  3. Trim irrelevant headers from the original message in your reply. All we need to see is a) From, b) Date, and c) Subject. We don't even really need the Subject, if you haven't changed it. Better yet is to just preface the original message with "On [date] [someone] wrote:".

  4. Please don't reply to or argue about spam, spam filters or viruses on any Samba lists. We do have a spam filtering system that is working quite well thank you very much but occasionally unwanted messages slip through. Deal with it.

  5. Never say "Me too." It doesn't help anyone solve the problem. Instead, if you ARE having the same problem, give more information. Have you seen something that the other writer hasn't mentioned, which may be helpful?

  6. If you ask about a problem, then come up with the solution on your own or through another source, by all means post it. Someone else may have the same problem and is waiting for an answer, but never hears of it.

  7. Give as much relevant information as possible such as Samba release number, OS, kernel version, etc...

  8. RTFM. Google.

WEBSITE

A Samba website has been setup with lots of useful info. Connect to:

https://www.samba.org/

As well as general information and documentation, this also has searchable archives of the mailing list and links to other useful resources such as the wiki.