1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
samba-mirror/python/samba
Tim Beale 5bfad1b2b0 netcmd: Improve error handling of gpo aclcheck as non-admin
Reading the nTSecurityDescriptor attribute over LDAP requires admin
creds. However, if you don't specify admin creds, then you get an error
like this:

bin/samba-tool gpo aclcheck
ERROR(<class 'KeyError'>): uncaught exception - 'No such element'
  File "bin/python/samba/netcmd/__init__.py", line 184, in _run
    return self.run(*args, **kwargs)
  File "bin/python/samba/netcmd/gpo.py", line 1536, in run
    ds_sd_ndr = m['nTSecurityDescriptor'][0]

This patch adds an explicit check/error message to make the problem
clearer.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2019-02-01 03:36:17 +01:00
..
emulate traffic_replay: use packets per second as primary scale 2019-01-08 23:55:35 +01:00
gp_parse python/samba/gp_parse: PY2/PY3 Decode only when necessary 2018-11-05 20:05:24 +01:00
kcc python/kcc lib: cope with differently formed repsToFrom 2019-01-19 19:21:20 +01:00
netcmd netcmd: Improve error handling of gpo aclcheck as non-admin 2019-02-01 03:36:17 +01:00
provision python/samba/provision: PY3 port samba4.dlz_bind9.version 2018-11-14 05:07:15 +01:00
samba3 python/samba3: import passdb in the manner it is used 2018-11-01 05:08:14 +01:00
subunit PEP8: fix E701: multiple statements on one line (colon) 2018-08-24 07:49:30 +02:00
tests selftest: Move dns_hub.py into selftest directory 2019-02-01 03:36:15 +01:00
web_server s4/web_server: PY3: port to python3 2018-09-27 01:54:27 +02:00
__init__.py python/samba: PY3 ord needs 'str' type not int 2018-12-10 10:38:21 +01:00
colour.py python/colour: add colourizing and switch functions 2018-05-31 01:57:17 +02:00
common.py python: avoid useless work in dsdb_Dn.__cmp__ 2018-11-01 05:08:12 +01:00
compat.py python/samba: fix default params for PY3 ConfigParser 2018-12-10 10:38:22 +01:00
dbchecker.py Fix spelling mistakes 2018-11-30 03:35:13 +01:00
descriptor.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
dnsserver.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
domain_update.py python/domain_update: remove unused imports 2018-10-25 21:45:53 +02:00
drs_utils.py drs_utils: Avoid invalid dereference of v8 requests 2018-11-06 07:15:33 +01:00
forest_update.py python/forest_update: remove unused imports 2018-10-25 21:45:53 +02:00
getopt.py python/samba: PY3 fix can't compare string with int 2018-11-14 05:07:17 +01:00
gp_ext_loader.py python/gp_ext_loader: remove unused imports 2018-10-25 21:45:53 +02:00
gp_sec_ext.py python/samba: PY3 port gpo.apply smbtorture test 2018-12-10 10:38:22 +01:00
gpclass.py python/gpclass: Convert gpclass to use s3 SMB Python bindings 2019-01-17 01:40:29 +01:00
graph.py PEP8: fix E303: too many blank lines (2) 2018-08-24 07:49:30 +02:00
hostconfig.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
idmap.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
join.py join: Throw CommandError instead of Exception for simple errors 2019-01-16 22:11:04 +01:00
logger.py logger: use color automatically for a tty 2018-11-21 10:46:20 +01:00
mdb_util.py mdb_util: Better error message if lmdb-utils not installed 2018-11-09 21:07:47 +01:00
ms_display_specifiers.py python/samba: port open to io.open for PY2/PY3 compat 2018-09-03 03:22:20 +02:00
ms_forest_updates_markdown.py python/samba: PY3 port samba4.blackbox.functionalprep 2018-10-23 05:50:28 +02:00
ms_schema_markdown.py PEP8: fix E305: expected 2 blank lines after class or function definition, found 1 2018-08-24 07:49:30 +02:00
ms_schema.py python/samba: port open to io.open for PY2/PY3 compat 2018-09-03 03:22:20 +02:00
ndr.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
ntacls.py ntacls: Pass correct use_ntvfs through to setntacl() 2019-01-17 01:40:30 +01:00
remove_dc.py python/remove_dc: fix Exception construction 2018-11-01 05:08:13 +01:00
samdb.py python/samba: PY3 fix failing py3 samba.tests.group_audit test 2018-12-10 10:38:22 +01:00
schema.py python/schema: remove unused import 2018-10-25 21:45:53 +02:00
sd_utils.py PEP8: fix E231: missing whitespace after ',' 2018-08-24 07:49:28 +02:00
sites.py PEP8: fix E128: continuation line under-indented for visual indent 2018-08-24 07:49:27 +02:00
subnets.py python/subnets: use the correct variable name 2018-11-01 05:08:11 +01:00
tdb_util.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
upgrade.py PEP8: improve formatting around bit-wise OR ("|") 2018-08-24 07:49:32 +02:00
upgradehelpers.py python/upgradehelpers: use mkstemp, not mktemp 2018-11-07 17:55:08 +01:00
uptodateness.py python/uptodateness: cope with unknown invocation ID 2019-01-19 19:21:19 +01:00
xattr.py python/xattr: remove unused variable 2018-11-01 05:08:14 +01:00