mirror of
https://github.com/samba-team/samba.git
synced 2025-02-28 01:58:17 +03:00
5c051eacd4
Although "lpq cache time" is 0 in the test environment the "print_queue_length()" function can still return cached results. This is because the print_queue_length() function calls print_queue_update(), which just sends MSG_PRINTER_UPDATE to the samba-bgqd daemon and returns without waiting for the daemon to update it. This behavior causes problems in the selftests between samba3.blackbox.printing_var_exp and samba3.rpc.spoolss.printserver because when the later enumerates the printers at different levels and compares the results the number of jobs can differ depending if samba-bgqd updates the cache in between print_queue_update() and get_queue_status() in the print_queue_length() function: test: samba3.rpc.spoolss.printserver.printserver.enum_printers(nt4_dc) time: 2023-02-17 13:07:34.043842Z Testing EnumPrinters level 0 Testing EnumPrinters level 1 Testing EnumPrinters level 2 Checking EnumPrinters level 0 printer print_var_exp (ref print_var_exp) time: 2023-02-17 13:07:34.285992Z failure: samba3.rpc.spoolss.printserver.printserver.enum_printers(nt4_dc) [ Exception: Exception: ../../source4/torture/rpc/spoolss.c:1132: cur->info0.cjobs was 1 (0x1), expected 0 (0x0): invalid value To fix it, make sure the queue is empty before printing_var_exp test ends. Signed-off-by: Samuel Cabrero <scabrero@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Mon Feb 20 22:58:44 UTC 2023 on atb-devel-224