1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
samba-mirror/lib/pthreadpool
Andrew Bartlett 6107c79c90 build: Do not build selftest binaries for builds without --enable-selftest
Add new for_selftest option to SAMBA_BINARY() and SAMBA3_BINARY()

This allows us to be much more consistent (at least in the core Samba)
and documents clearly why the binary should not be installed.

Not modified are
 - test_lp_load
 - notifyd-tests
 - gendrandperf
 - test* from examples/libsmbclient
 - dbwrap_torture
 - split_tokens
 - locktest2
 - msgtest
 - msg_sink
 - msg_source
 - versiontest
 - rpc_open_tcp
 - test_headers

As these are not tested in selftest so any change would also be
untested.  Of course they probably should be added in a different
MR.

Also not modified (because they are not tests, nor part of the
build system) are:
 - smb2mount
 - notifydd
 - log2pacp
 - debug2html
 - smbfilter
 - destroy_netlogon_creds_cli
 - spotlight2*
 - tevent_glib_tracker

These do however appear to be untested.

For now, the source4 forked client tools are left unchanged:
 - smbclient4
 - nmblookup4

Finally, the heimdal binaries are left as install=False as
they are either part of the build system or end-user tools
that we just don't want to install.  These are however tested.

The motivation is commit like c34ec003b7
and da87fa998a, which are both totally
correct but are not needed if the selftest is not run on MacOS.

There are likely other platforms or build environments where building
our test binaries is more pain than valuable, see for example also
https://lists.samba.org/archive/samba/2019-November/227137.html

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>

Autobuild-User(master): Isaac Boukris <iboukris@samba.org>
Autobuild-Date(master): Fri Nov 22 11:48:59 UTC 2019 on sn-devel-184
2019-11-22 11:48:59 +00:00
..
Makefile
pthreadpool_pipe.c
pthreadpool_pipe.h
pthreadpool_sync.c Revert "pthreadpool: call unshare(CLONE_FS) if available" 2019-01-11 23:11:13 +01:00
pthreadpool_tevent.c Revert "pthreadpool: split out pthreadpool_tevent_job from pthreadpool_tevent_job_state" 2019-01-11 23:11:14 +01:00
pthreadpool_tevent.h Revert "pthreadpool: maintain a global list of orphaned pthreadpool_tevent_jobs" 2019-01-11 23:11:14 +01:00
pthreadpool.c pthreadpool: Remove wrong comment. 2019-08-23 23:09:12 +00:00
pthreadpool.h Revert "pthreadpool: call unshare(CLONE_FS) if available" 2019-01-11 23:11:13 +01:00
tests_cmocka.c Revert "pthreadpool: test cancelling and freeing pending pthreadpool_tevent jobs/pools" 2019-01-11 23:11:14 +01:00
tests.c lib/pthreadpool: cppcheck: Fix Memory leak 2019-06-04 22:13:07 +00:00
wscript_build build: Do not build selftest binaries for builds without --enable-selftest 2019-11-22 11:48:59 +00:00