1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
samba-mirror/ctdb/protocol
Martin Schwenke 0d8084ed62 ctdb-protocol: CID 1499395: Uninitialized variables (UNINIT)
Issue is reported here:

853     	case CTDB_CONTROL_DB_VACUUM: {
854     		struct ctdb_db_vacuum db_vacuum;
855
>>>     CID 1499395:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "db_vacuum.full_vacuum_run" when calling "ctdb_db_vacuum_len".
856     		CHECK_CONTROL_DATA_SIZE(ctdb_db_vacuum_len(&db_vacuum));
857     		return ctdb_control_db_vacuum(ctdb, c, indata, async_reply);
858     	}

The problem is that ctdb_bool_len() unnecessarily dereferences its
argument, which in this case is &db_vacuum.full_vacuum_run.  Not a
security issue because the value copied by dereferencing is not used.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Feb 23 02:02:06 UTC 2022 on sn-devel-184
2022-02-23 02:02:06 +00:00
..
protocol_api.h ctdb-protocol: Drop protocol client functions for recmaster controls 2022-01-17 10:21:33 +00:00
protocol_basic.c ctdb-protocol: CID 1499395: Uninitialized variables (UNINIT) 2022-02-23 02:02:06 +00:00
protocol_basic.h ctdb-protocol: Separate protocol-basic subsystem 2018-07-05 06:52:42 +02:00
protocol_call.c ctdb-protocol: Fix marshalling for ctdb_reply_dmaster 2017-08-30 14:59:25 +02:00
protocol_client.c ctdb-protocol: Drop protocol client functions for recmaster controls 2022-01-17 10:21:33 +00:00
protocol_control.c ctdb-protocol: Drop marshalling for {GET,SET}_RECMASTER controls 2022-01-17 10:21:33 +00:00
protocol_debug.c ctdb-protocol: Add marshalling for controls DISABLE_NODE/ENABLE_NODE 2021-09-09 01:46:49 +00:00
protocol_header.c ctdb-protocol: Fix marshalling for ctdb_req_header 2017-08-30 14:59:25 +02:00
protocol_keepalive.c ctdb-protocol: Add marshalling for ctdb_req_keepalive 2017-08-30 14:59:26 +02:00
protocol_message.c ctdb-protocol: Add CTDB_SRVID_LEADER 2022-01-17 10:21:32 +00:00
protocol_packet.c ctdb-protocol: Check arguments in ctdb_allocate_pkt 2016-05-03 04:43:20 +02:00
protocol_private.h ctdb-protocol: Add marshalling for struct ctdb_echo_data 2020-04-28 09:08:39 +00:00
protocol_sock.c ctdb-protocol: Add a generic packet header 2017-09-01 08:52:07 +02:00
protocol_tunnel.c ctdb-protocol: Add protocol marshalling for CTDB_REQ_TUNNEL 2017-10-10 11:45:19 +02:00
protocol_types.c ctdb-protocol: Add marshalling for struct ctdb_echo_data 2020-04-28 09:08:39 +00:00
protocol_util.c ctdb-protocol: Print IPv6 sockets with RFC5952 "[2001:db8::1]:80" notation 2022-01-13 17:02:21 +00:00
protocol_util.h ctdb:protocol_util: remove 'const' from allocated strings 2019-06-04 22:13:07 +00:00
protocol.h ctdb-protocol: Mark {GET,SET}_RECMASTER controls obsolete 2022-01-17 10:21:33 +00:00