Ralph Boehme 6a9bdca128 dbwrap_ctdb: treat empty records in ltdb as non-existing ...

When fetching records from remote ctdb nodes via ctdbd_parse() or in
db_ctdb_traverse(), we already check for tombstone records and skip
them. This was originally also done for the ltdb checks.

See also bug: https://bugzilla.samba.org/show_bug.cgi?id=10008
(commit 1cae59ce112ccb51b45357a52b902f80fce1eef1).

Commit 925625b52886d40b50fc631bad8bdc81970f7598 reverted part of the
patch of bug 10008 due to a deadlock it introduced.

This patch re-introduces the consistent treatment of empty records in
the ltdb but avoids the deadlock by correctly signalling
NT_STATUS_NOT_FOUND if an empty record is found authoritatively in
the ltdb and not calling ctdb in this case.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12005

Pair-Programmed-With: Michael Adam <obnox@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>

Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Aug  9 04:38:44 CEST 2016 on sn-devel-144

(cherry picked from commit 25df582739918b7afd4e5497eaffe279e2d92cd1)

Autobuild-User(v4-5-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-5-test): Wed Aug 10 15:08:00 CEST 2016 on sn-devel-144

2016-08-10 15:08:00 +02:00

..

ABI

s3-smbldap: make smbldap public library and maintain its ABI

2012-09-07 14:14:30 +02:00

asys

asys: call clock_gettime_mono() only on profile-enabled build

2016-03-28 20:45:16 +02:00

dbwrap

dbwrap_ctdb: treat empty records in ltdb as non-existing

2016-08-10 15:08:00 +02:00

eventlog

lib: Remove tdb_compat

2015-03-17 11:30:52 +01:00

netapi

s3-libnetapi: Correctly check for lp_realm.

2016-06-15 16:31:17 +02:00

pthreadpool

lib: Fix CID 1338432 Unchecked return value

2015-11-10 21:20:18 +01:00

smbconf

Convert all uint32/16/8 to _t in a grab-bag of remaining files.

2015-05-14 22:16:56 +02:00

unix_msg

lib: Move msghdr to lib/util/

2016-06-07 14:34:10 +02:00

access.c

Update mailing list references to point at lists.samba.org

2015-02-10 07:08:28 +01:00

addrchange.c

s3:lib/addrchange: make use of tdgram_* in addrchange_*()

2015-06-12 17:08:17 +02:00

addrchange.h

…

adt_tree.c

adt_tree: Fix return types.

2012-03-24 17:11:11 +01:00

audit.c

Change all uses of uint32/16/8 in proto.h to uint32_t/16_t/8_t.

2015-04-29 23:42:20 +02:00

avahi.c

…

background.c

s3: Move call to prctl_set_comment to reinit_after_fork

2015-09-24 08:00:16 +02:00

background.h

s3: Add infrastructure for background jobs

2012-04-17 10:21:00 +02:00

cbuf.c

…

cbuf.h

lib: Fix a typo

2014-02-20 22:58:58 +01:00

charcnv.c

Change all uses of uint32/16/8 in proto.h to uint32_t/16_t/8_t.

2015-04-29 23:42:20 +02:00

cleanupdb.c

s3/lib: add smbd_cleanupd.tdb

2016-07-28 05:00:18 +02:00

cleanupdb.h

s3/lib: add smbd_cleanupd.tdb

2016-07-28 05:00:18 +02:00

cluster_support.c

lib: Move lp_ctdbd_socket() to cluster_support.c

2015-10-03 00:01:11 +02:00

cluster_support.h

lib: Move lp_ctdbd_socket() to cluster_support.c

2015-10-03 00:01:11 +02:00

conn_tdb.c

smbstatus: show signing state of sessions and tcons

2016-01-22 07:52:21 +01:00

conn_tdb.h

smbstatus: show signing state of sessions and tcons

2016-01-22 07:52:21 +01:00

ctdb_dummy.c

s3-messaging/ctdb: add messaging_ctdbd_reinit()

2016-07-11 20:05:06 +02:00

ctdbd_conn.c

ctdbd_conn: add ctdbd_reinit_connection()

2016-07-11 20:05:06 +02:00

dmallocmsg.c

…

dumpcore.c

source3: Honor the core soft limit of the OS.

2016-03-05 00:39:48 +01:00

errmap_unix.c

s3:lib/errmap_unix: map EOVERFLOW to NT_STATUS_ALLOTTED_SPACE_EXCEEDED

2015-12-21 23:21:17 +01:00

events.c

dlist: remove unneeded argument from DLIST_DEMOTE()

2016-02-06 21:48:17 +01:00

file_id.c

lib: Apply some const to pull_file_id_24

2013-09-06 13:40:05 +02:00

file_id.h

lib: Apply some const to pull_file_id_24

2013-09-06 13:40:05 +02:00

filename_util.c

s3: smbd: Remove many common uses of lp_posix_pathnames().

2016-03-24 22:57:16 +01:00

fncall.c

pthreadpool: Allow multiple jobs to be received

2014-03-27 06:06:11 +01:00

fstring.c

…

g_lock.c

lib: Convert g_lock to new dbwrap_watch

2016-07-15 16:56:13 +02:00

gencache.c

lib: Avoid a gencache_parse when setting a delete marker

2016-03-07 17:58:16 +01:00

gencache.h

lib: Remove ntstatus.h from gencache.h

2015-12-16 04:14:20 +01:00

id_cache.c

lib/util: move memcache.[ch] to the toplevel 'samba-util' library

2014-07-18 15:43:33 +02:00

id_cache.h

…

idmap_cache.c

s3:idmap_cache: remove unused idmap_cache_set_sid2[u|g]id()

2014-12-03 06:44:29 +01:00

idmap_cache.h

s3:idmap_cache: remove unused idmap_cache_set_sid2[u|g]id()

2014-12-03 06:44:29 +01:00

interface.c

s3:lib: extend interpret_interface() to optionally read speed, caps, and index from config

2016-01-26 07:33:16 +01:00

ldap_debug_handler.c

…

ldap_escape.c

…

lsa.c

lib: Fix talloc hierarchy in init_lsa_ref_domain_list

2015-02-27 22:53:06 +01:00

messages_ctdbd.c

s3-messaging/ctdb: add messaging_ctdbd_reinit()

2016-07-11 20:05:06 +02:00

messages_dgm_ref.c

Remove function name from callers of DBG_*

2015-10-21 23:13:17 +02:00

messages_dgm_ref.h

lib: Push down unique generation one level

2015-10-19 12:09:10 +02:00

messages_dgm.c

messaging: Fix creating the dgm lockfile

2015-10-22 02:14:29 +02:00

messages_dgm.h

lib: Push down unique generation one level

2015-10-19 12:09:10 +02:00

messages_util.c

lib: Introduce SERVER_ID_BUF_LENGTH

2016-03-06 16:21:12 +01:00

messages_util.h

messaging: Define a binary format for message headers

2015-02-13 23:32:07 +01:00

messages.c

lib: Move "message_send_all" to serverid.c

2016-07-28 05:00:19 +02:00

ms_fnmatch.c

…

namearray.c

…

popt_common.c

s3: fix encryption help messages

2015-12-22 02:22:50 +01:00

privileges.c

Fix various spelling errors

2015-11-06 13:43:45 +01:00

privileges.h

…

readdir_attr.h

s3:vfs: add SMB_VFS_READDIR_ATTR()

2014-12-04 22:11:07 +01:00

recvfile.c

lib: Move sys_rw* to lib/util

2015-10-13 01:23:07 +02:00

sendfile.c

Remove a few #ifdef EWOULDBLOCk

2014-09-18 20:36:11 +02:00

server_contexts.c

…

server_id_db_util.c

lib: Fix a signed/unsigned mixup

2016-07-16 00:17:03 +02:00

server_id_db_util.h

lib: Add server_id_db_set_exclusive

2015-07-07 23:51:23 +02:00

server_id_watch.c

lib: Add server_id_watch_send

2016-07-15 16:56:13 +02:00

server_id_watch.h

lib: Add server_id_watch_send

2016-07-15 16:56:13 +02:00

server_mutex.c

server_mutex: don't leak lock_path onto talloc tos

2014-11-03 23:46:05 +01:00

server_prefork_util.c

…

server_prefork_util.h

…

server_prefork.c

lib: Remove sys_waitpid

2016-02-23 22:03:16 +01:00

server_prefork.h

…

serverid.c

lib: Move "message_send_all" to serverid.c

2016-07-28 05:00:19 +02:00

sessionid_tdb.c

smbstatus: show signing state of sessions and tcons

2016-01-22 07:52:21 +01:00

sharesec.c

sharesec: Remove error message for unmarshall_sec_desc failure

2015-07-06 20:19:12 +02:00

smbd_shim.c

s3-smbd_shim: Add become_authenticated_pipe_user().

2013-10-29 15:52:58 +01:00

smbd_shim.h

s3-smbd_shim: Add become_authenticated_pipe_user().

2013-10-29 15:52:58 +01:00

smbldap.c

s3: lib: ldap: Use struct sockaddr_storage to cope with IPv6.

2016-05-29 05:37:12 +02:00

smbrun.c

lib: Remove sys_waitpid

2016-02-23 22:03:16 +01:00

sock_exec.c

s3-lib: Don't close the listener twice if we goto failed.

2012-12-12 23:14:44 +01:00

srprs.c

s3:lib: fix/simplify srprs_hex()

2014-11-25 07:25:44 +01:00

srprs.h

s3:lib: use includes.h with cbuf and srprs

2012-09-07 23:39:45 +02:00

substitute_generic.c

Finally remove all malloc()'s from the substitute code. Now totally

2012-01-27 03:43:21 +01:00

substitute.c

substitute: Fix talloc_sub_basic for %G in the case of a local user.

2016-01-22 05:03:25 +01:00

sys_popen.c

lib: Extract sys_popen()

2016-02-23 22:03:16 +01:00

sys_popen.h

lib: Extract sys_popen()

2016-02-23 22:03:16 +01:00

sysacls.c

lib: Fix indentation

2015-05-06 04:14:14 +02:00

sysquotas_4A.c

sys-quotas: do not fail if user has no quota

2016-03-31 20:30:10 +02:00

sysquotas_4B.c

s3-quotas: fix sysquotas_4B quota fetching for BSD

2016-05-23 23:28:12 +02:00

sysquotas_linux.c

s3-sysquotas-linux: do not check for EDQUOT

2016-06-01 00:57:32 +02:00

sysquotas_nfs.c

nfs-quota: do not fail on ECONNREFUSED

2016-03-31 20:30:11 +02:00

sysquotas_xfs.c

xfs quotas - fix case of no quota for user

2016-04-29 05:39:14 +02:00

sysquotas.c

s3-sysquotas: remove special handling of EDQUOT

2016-06-01 00:57:32 +02:00

system_smbd.c

lib: Avoid a malloc/realloc in getgroups_unix_user

2015-03-11 16:11:08 +01:00

system.c

lib: Extract sys_popen()

2016-02-23 22:03:16 +01:00

talloc_dict.c

s3:talloc_dict: fix a SIGBUS when dereferencing unaligned pointers

2015-11-30 22:31:16 +01:00

tallocmsg.c

lib: Use talloc_report_str

2015-02-13 23:32:07 +01:00

tdb_validate.c

lib: Remove sys_waitpid

2016-02-23 22:03:16 +01:00

tdb_validate.h

lib: Remove tdb_compat

2015-03-17 11:30:52 +01:00

tevent_barrier.c

Use tevent_req_simple_recv_unix in a few places

2014-11-10 06:09:04 +01:00

tevent_barrier.h

s3: Implement tevent_barrier

2012-04-17 10:21:02 +02:00

tevent_wait.c

s3:tevent_wait: simplify the code by using tevent_req_defer_callback()

2015-05-19 16:37:52 +02:00

tevent_wait.h

s3: Add tevent_wait_send/recv

2012-07-18 15:54:20 -07:00

time.c

lib: Align nt_time_to_unix_timespec with unix_timespec_to_nt_time

2014-06-30 22:28:14 +02:00

tldap_gensec_bind.c

s3: tldap: Make tldap_gensec_bind_send()/tldap_gensec_bind_recv() static.

2016-06-28 11:19:33 +02:00

tldap_gensec_bind.h

s3: tldap: Make tldap_gensec_bind_send()/tldap_gensec_bind_recv() static.

2016-06-28 11:19:33 +02:00

tldap_util.c

lib: Give base64.c its own .h

2016-05-04 01:28:23 +02:00

tldap.c

tldap: Add tldap_get/set_stream

2016-04-15 15:32:11 +02:00

username.c

lib/util: move memcache.[ch] to the toplevel 'samba-util' library

2014-07-18 15:43:33 +02:00

util_builtin.c

Change all uses of uint32/16/8 in proto.h to uint32_t/16_t/8_t.

2015-04-29 23:42:20 +02:00

util_cluster.c

lib: Make ctdbd_probe return 0/errno

2015-10-07 23:54:06 +02:00

util_cluster.h

s3: add cluster_probe_ok() in a new module util_cluster.

2013-10-17 23:21:53 +02:00

util_cmdline.c

s3-lib: Do not require a password with --use-ccache.

2014-12-02 19:23:05 +01:00

util_ea.c

dlist: remove unneeded type argument from DLIST_ADD_END()

2016-02-06 21:48:17 +01:00

util_ea.h

s3:lib: Factor read_ea_list_entry() and read_nttrans_ea_list() out so they can be used by the SMB2 client code.

2013-08-15 09:07:06 +02:00

util_file.c

lib: Remove "includes.h" from util_file.c

2016-02-23 22:03:17 +01:00

util_file.h

lib: Remove "includes.h" from util_file.c

2016-02-23 22:03:17 +01:00

util_malloc.c

s3: Remove some unused code

2012-05-15 18:24:10 +02:00

util_names.c

s3:lib: add braces around if-block in my_sam_name()

2016-01-26 03:19:18 +01:00

util_nscd.c

…

util_nttoken.c

…

util_path.c

lib: Separate out xx_path() & callers

2015-12-14 20:23:13 +01:00

util_path.h

lib: Separate out xx_path() & callers

2015-12-14 20:23:13 +01:00

util_procid.c

lib: Move some procid functions out of util.c

2015-11-09 07:53:18 +01:00

util_procid.h

lib: Move some procid functions out of util.c

2015-11-09 07:53:18 +01:00

util_sd.c

util_sd: Also accept hex input for ALLOW/DENIED

2016-02-20 00:46:29 +01:00

util_sec.c

s3-lib: Get the real initial uid for selftest

2015-11-05 09:23:15 +01:00

util_sid_passdb.c

s3:util_sid: donate an empty line.

2015-03-16 20:26:50 +01:00

util_sid_passdb.h

s3:passdb: add sid_check_object_is_for_passdb()

2012-12-03 08:48:30 +01:00

util_sid.c

s3-util: skip S-1-18 sids in token generaion in sid_array_from_info3().

2016-01-16 01:24:04 +01:00

util_sock.c

Fix various spelling errors

2015-11-06 13:43:45 +01:00

util_specialsids.c

s3-util: add helper functions to deal with the S-1-18 domain.

2016-01-15 22:19:07 +01:00

util_str.c

lib: Fix a typo

2015-05-06 15:37:14 +02:00

util_tdb.c

Convert all uint32/16/8 to _t in source3/lib.

2015-05-13 19:11:23 +02:00

util_transfer_file.c

lib: Move sys_rw* to lib/util

2015-10-13 01:23:07 +02:00

util_tsock.c

lib: Introduce util_tsock.h

2016-01-10 22:24:17 +01:00

util_tsock.h

lib: Introduce util_tsock.h

2016-01-10 22:24:17 +01:00

util_unixsids.c

lib/util: Remove dummy wrapper for getgrnam().

2012-03-24 15:25:48 +01:00

util_wellknown.c

s3:lib: validate domain name in lookup_wellknown_name()

2015-10-15 19:56:14 +02:00

util.c

s3: lib: util: Add map_process_lock_to_ofd_lock() utility function.

2016-05-21 01:28:28 +02:00

version_test.c

…

version.c

…

winbind_util.c

Convert all uint32/16/8 to _t in source3/lib.

2015-05-13 19:11:23 +02:00

winbind_util.h

Convert all uint32/16/8 to _t in source3/lib.

2015-05-13 19:11:23 +02:00

wins_srv.c

lib: Add a "mem_ctx" arg to gencache_get (unused so far)

2013-09-05 09:16:23 -07:00

xattr_tdb.c

s3: Fix the build on FreeBSD

2012-04-19 19:13:45 +02:00

xattr_tdb.h

s3-xattr_tdb: Be nice to xattr_tdb_getxattr callers, return the full blob

2012-04-18 12:05:00 +10:00