mirror of
https://github.com/samba-team/samba.git
synced 2024-12-23 17:34:34 +03:00
c98bdf2494
The warning is:
../source4/smbd/service_stream.c: In function ‘stream_io_handler’:
../source4/smbd/service_stream.c:94:18: warning: increment of a boolean expression [-Wbool-operation]
conn->processing++;
^~
../source4/smbd/service_stream.c💯18: warning: decrement of a boolean expression [-Wbool-operation]
conn->processing--;
^~
while the code in question looks like:
conn->processing++;
if (flags & TEVENT_FD_WRITE) {
conn->ops->send_handler(conn, flags);
} else if (flags & TEVENT_FD_READ) {
conn->ops->recv_handler(conn, flags);
}
conn->processing--;
If this is never going to be nested, processing can be bool and the ++
and -- can be true/false assignments. But it seems possible that these
might be nested so it is better to go the other way.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Dec 1 00:28:05 CET 2016 on sn-devel-144
|
||
|---|---|---|
| .. | ||
| process_model.c | ||
| process_model.h | ||
| process_single.c | ||
| process_standard.c | ||
| server.c | ||
| service_named_pipe.c | ||
| service_stream.c | ||
| service_stream.h | ||
| service_task.c | ||
| service_task.h | ||
| service.c | ||
| service.h | ||
| wscript_build | ||