1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
https://gitlab.com/samba-team/samba is the Official GitLab mirror of https://git.samba.org/samba.git -- Merge requests should be made on GitLab (not on GitHub)
Go to file
Andrew Bartlett 6b5aba80e6 lib/krb5_wrap: Fix missing error check in new salt code
CID 1492905: Control flow issues  (DEADCODE)

This was a regression in 5eeb441b77.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14874
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14881

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Oct 23 08:07:13 UTC 2021 on sn-devel-184

(cherry picked from commit 5094d986b7)
2021-10-26 12:00:28 +00:00
.github Added redirect from GitHub to GitLab 2018-12-05 16:35:33 +01:00
auth dsdb: Allow special chars like "@" in samAccountName when generating the salt 2021-10-26 12:00:28 +00:00
bootstrap bootstrap: Update distro list in README.md 2020-12-15 12:03:58 +00:00
buildtools wafsamba: add support git worktree to vcs_dir_contents() 2021-08-12 10:36:10 +00:00
coverity coverity: Add modeling file for Coverity scan 2017-02-23 07:11:18 +01:00
ctdb ctdb-tests: add a comment to the generated public_addresses file used by eventscript UNIT tests 2021-10-18 08:41:15 +00:00
dfs_server lib/util: remove extra safe_string.h file 2020-08-28 02:18:40 +00:00
docs-xml docs: Update list of available commands in rpcclient 2021-05-26 12:45:16 +00:00
dynconfig build: Remove workaround for missing os.path.relpath in Python < 2.6 2019-11-13 08:42:30 +00:00
examples vfs: RIP SMB_VFS_SYS_ACL_SET_FILE() 2020-12-17 18:56:29 +00:00
file_server s4: rename source4/smbd/ to source4/samba/ 2020-11-27 10:07:18 +00:00
include
lib lib/krb5_wrap: Fix missing error check in new salt code 2021-10-26 12:00:28 +00:00
libcli libcli/smb: allow unexpected padding in SMB2 READ responses 2021-08-12 09:39:40 +00:00
libds/common libds: rename UF_MACHINE_ACCOUNT_MASK to UF_TRUST_ACCOUNT_MASK 2018-03-13 18:59:17 +01:00
libgpo python: Ensure reference counts are properly incremented 2021-09-16 06:50:11 +00:00
librpc tests/krb5: Check buffer types in PAC with STRICT_CHECKING=1 2021-10-26 12:00:27 +00:00
nsswitch wbinfo: Align some integer types 2020-11-30 22:24:38 +00:00
packaging winbind.service: drop quotes from $WINBINDOPTIONS variable 2020-05-12 12:27:11 +00:00
pidl pidl: set the per-request memory context in the pidl generator 2021-04-01 10:31:20 +00:00
python tests/krb5: Add tests for account salt calculation 2021-10-26 12:00:28 +00:00
release-scripts
script autobuild: allow AUTOBUILD_FAIL_IMMEDIATELY=0 (say from a gitlab variable) 2021-09-23 08:54:03 +00:00
selftest dsdb: Allow special chars like "@" in samAccountName when generating the salt 2021-10-26 12:00:28 +00:00
source3 dsdb: Allow special chars like "@" in samAccountName when generating the salt 2021-10-26 12:00:28 +00:00
source4 dsdb: Allow special chars like "@" in samAccountName when generating the salt 2021-10-26 12:00:28 +00:00
testdata regfio: Improve handling of malformed registry hive files 2019-03-20 05:26:18 +00:00
testprogs selftest/dbcheck: Fix up RODC one-way links (use correct dbcheck rule) 2021-10-26 12:00:27 +00:00
tests tests/sysquotas.c: include jfs/quota.h for 4B test on AIX 2019-02-17 13:33:13 +01:00
testsuite unittests: Mark test binaries for selftest 2020-10-23 14:09:43 +00:00
third_party third_party: Update socket_wrapper to version 1.3.3 2021-03-31 10:13:54 +00:00
wintest wintest: py3 telnet.sendline() doesn't like string with ^Z 2019-07-02 04:21:36 +00:00
.bzrignore
.gitattributes gitattributes: Ignore .SAMBABACKUP files 2018-08-16 23:42:22 +02:00
.gitignore gitignore: Add .build.log 2019-11-26 12:49:41 +00:00
.gitlab-ci-private.yml .gitlab-ci.yml: merge .gitlab-ci-private.yml 2019-02-18 10:54:19 +01:00
.gitlab-ci.yml CI: add samba-no-opath 2020-12-16 09:08:30 +00:00
.testr.conf
.ycm_extra_conf.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
callcatcher-exceptions.grep
configure configure: Do not put arguments into double quotes 2021-08-10 11:40:12 +00:00
configure.developer
COPYING
GPG_AA99442FB680B620_replaces_6F33915B6568B7EA.txt ReleaseKey: add GnuPG key transition statement for the Samba release key 2021-01-21 13:57:45 +01:00
Makefile Makefile: add support for 'make testonly' 2021-02-02 09:20:10 +00:00
PFIF.txt docs: protocolfreedom.org is no longer 2020-06-12 22:11:43 +00:00
README.cifs-utils
README.Coding.md README.Coding: target Python 3.6+ 2020-08-03 04:13:37 +00:00
README.contributing Rename Samba's DCO to Samba Developer's Declaration 2020-10-20 22:54:01 +00:00
README.md Update README.md with more up to date information 2020-06-12 22:11:43 +00:00
SECURITY.md Update SECURITY.md to point to security releases 2020-06-03 15:55:10 +00:00
setup.cfg pep8 tidy up config 2020-12-17 00:54:51 +00:00
VERSION VERSION: Bump version up to Samba 4.14.9... 2021-10-05 15:08:27 +02:00
VFS-License-clarification.txt VFS-License-clarification: minor improvements aligning w/ GPLv3 text 2020-11-04 21:29:40 +00:00
WHATSNEW.txt WHATSNEW: Add release notes for Samba 4.14.8. 2021-10-05 15:08:27 +02:00
wscript wscript: fix installing pre-commit with 'git worktree' 2021-08-12 11:49:18 +00:00
wscript_build s4: rename source4/smbd/ to source4/samba/ 2020-11-27 10:07:18 +00:00
wscript_build_embedded_heimdal wscript_build_embedded_heimdal: update to handle waf 2.0.4 2018-09-05 06:37:25 +02:00
wscript_build_system_heimdal wscript: port build_system_heimdal to waf 2.0 2018-09-05 06:37:27 +02:00
wscript_build_system_mitkrb5 wscript: port build_system_mitkrb5 to waf 2.0 2018-09-05 06:37:27 +02:00
wscript_configure_embedded_heimdal build: Notice if flex is missing at configure time 2021-04-20 07:39:05 +00:00
wscript_configure_system_gnutls waf: Only use gnutls_aead_cipher_encryptv2() for GnuTLS > 3.6.14 2020-09-11 08:27:26 +00:00
wscript_configure_system_heimdal wscript: Fix build with system heimdal 2019-11-13 17:49:38 +00:00
wscript_configure_system_mitkrb5 Fix uxsuccess test with new MIT krb5 library 1.18 2020-03-10 13:02:27 +00:00

About Samba

Samba is the standard Windows interoperability suite of programs for Linux and Unix. Samba is Free Software licensed under the GNU General Public License and the Samba project is a member of the Software Freedom Conservancy. Since 1992, Samba has provided secure, stable and fast file and print services for all clients using the SMB/CIFS protocol, such as all versions of DOS and Windows, OS/2, Linux and many others. Samba is an important component to seamlessly integrate Linux/Unix Servers and Desktops into Active Directory environments. It can function both as a domain controller or as a regular domain member.

For the AD DC implementation a full HOWTO is provided at: https://wiki.samba.org/index.php/Samba4/HOWTO

Community guidelines can be read at: https://wiki.samba.org/index.php/How_to_do_Samba:_Nicely

This software is freely distributable under the GNU public license, a copy of which you should have received with this software (in a file called COPYING).

CONTRIBUTIONS

Please see https://wiki.samba.org/index.php/Contribute for detailed set-by-step instructions on how to submit a patch for Samba via GitLab.

Samba's GitLab mirror is at https://gitlab.com/samba-team/samba

OUR CONTRIBUTORS

See https://www.samba.org/samba/team/ for details of the Samba Team, as well as details of all those currently active in Samba development.

If you like a particular feature then look through the git change-log (on the web at https://gitweb.samba.org/?p=samba.git;a=summary) and see who added it, then send them an email.

Remember that free software of this kind lives or dies by the response we get. If no one tells us they like it then we'll probably move onto something else.

MORE INFO

DOCUMENTATION

There is quite a bit of documentation included with the package, including man pages and the wiki at https://wiki.samba.org

If you would like to help with our documentation, please contribute that improved content to the wiki, we are moving as much content there as possible.

MAILING LIST

Please do NOT send subscription/unsubscription requests to the lists!

There is a mailing list for discussion of Samba. For details go to https://lists.samba.org/ or send mail to samba-subscribe@lists.samba.org

There is also an announcement mailing list where new versions are announced. To subscribe go to https://lists.samba.org/ or send mail to samba-announce-subscribe@lists.samba.org. All announcements also go to the samba list, so you only need to be on one.

For details of other Samba mailing lists and for access to archives, see https://lists.samba.org/

MAILING LIST ETIQUETTE

A few tips when submitting to this or any mailing list.

  1. Make your subject short and descriptive. Avoid the words "help" or "Samba" in the subject. The readers of this list already know that a) you need help, and b) you are writing about samba (of course, you may need to distinguish between Samba PDC and other file sharing software). Avoid phrases such as "what is" and "how do i". Some good subject lines might look like "Slow response with Excel files" or "Migrating from Samba PDC to NT PDC".

  2. If you include the original message in your reply, trim it so that only the relevant lines, enough to establish context, are included. Chances are (since this is a mailing list) we've already read the original message.

  3. Trim irrelevant headers from the original message in your reply. All we need to see is a) From, b) Date, and c) Subject. We don't even really need the Subject, if you haven't changed it. Better yet is to just preface the original message with "On [date] [someone] wrote:".

  4. Please don't reply to or argue about spam, spam filters or viruses on any Samba lists. We do have a spam filtering system that is working quite well thank you very much but occasionally unwanted messages slip through. Deal with it.

  5. Never say "Me too." It doesn't help anyone solve the problem. Instead, if you ARE having the same problem, give more information. Have you seen something that the other writer hasn't mentioned, which may be helpful?

  6. If you ask about a problem, then come up with the solution on your own or through another source, by all means post it. Someone else may have the same problem and is waiting for an answer, but never hears of it.

  7. Give as much relevant information as possible such as Samba release number, OS, kernel version, etc...

  8. RTFM. Google.

WEBSITE

A Samba website has been setup with lots of useful info. Connect to:

https://www.samba.org/

As well as general information and documentation, this also has searchable archives of the mailing list and links to other useful resources such as the wiki.