1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-12 09:18:10 +03:00
samba-mirror/source4
Tim Beale 6c1ff59099 acl_read: Rework Samba code to reflect Windows logic
This patch should not alter functionality. It is just updating the Samba
code to better match the Windows specification docs.

When fixing Samba BUG #13434, the Microsoft behaviour wasn't clearly
documented, so we made a best guess based on observed behaviour.
The problem was an exception was made to allow "objectClass=*" searches
to return objects, even if you didn't have Read Property rights for the
object's objectClass attribute. However, the logic behind what
attributes were and weren't covered by this exception wasn't clear.

I made a guess that it was attributes belonging to the Public Info
property-set that also have the systemOnly flag set.

Microsoft have confirmed the object visibility behaviour. It turns out
that an optimization is made for the 4 attributes that are always
present for every object (i.e. objectClass, distinguishedName,
name, objectGUID). They're updating their Docs to reflect this.

Now that we know the Windows logic, we can update the Samba code.
This simplifies the code somewhat.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2018-09-21 20:04:23 +02:00
..
auth python: Add samba.auth.session_info_fill_unix() 2018-07-12 04:32:06 +02:00
build/pasn1
cldap_server cldap: clear remote address after cldap_dse_fill 2018-05-31 09:54:18 +02:00
client s4:client: Fix size types and loop 2018-04-03 20:20:10 +02:00
cluster dbwrap: Remove calls to loadparm 2018-04-24 01:53:19 +02:00
dns_server dns_server: Avoid ldb_dn_add_child_fmt() on untrusted input 2018-08-15 07:08:24 +02:00
dsdb acl_read: Rework Samba code to reflect Windows logic 2018-09-21 20:04:23 +02:00
echo_server source4/smbd: Do not overstamp the process model with "single" 2017-10-19 05:33:10 +02:00
heimdal PY3: make sure print stmt is enclosed by '(' & ')' 2018-09-19 22:25:05 +02:00
heimdal_build heimdal-build: Avoid using python str.format() 2018-09-21 03:06:44 +02:00
include lib: Remove global xfile.h includes 2016-11-20 06:23:19 +01:00
kdc kdc: Improve code clarity with extra brackets 2018-09-05 16:17:59 +02:00
ldap_server ldap_server: Fix CID 1435721 Unchecked return value 2018-05-24 03:35:00 +02:00
lib source4/lib/tls/wscript: update to handle waf 2.0.4 2018-09-05 06:37:24 +02:00
libcli s4: libcli/smb2: calculate correct credit charge for finds 2018-07-25 00:23:13 +02:00
libnet FIXUP: Improve memory handling on py_net_change_password 2018-05-17 14:28:19 +02:00
librpc s4/librpc: Fix py2 dependecies leaking into py3 libraries 2018-09-16 09:21:59 +02:00
nbt_server samdb: Add remote address to connect 2018-05-10 20:02:23 +02:00
ntp_signd samdb: Add remote address to connect 2018-05-10 20:02:23 +02:00
ntvfs s4:libcli: allow passing an already negotiated connection to smb_composite_connect() 2018-07-24 06:55:23 +02:00
param s4/param: py2/p3 compat override_prefixmap should be string/bytes 2018-09-15 15:18:26 +02:00
rpc_server s4:rpc_server/netlogon: don't treet trusted domains as primary in LogonGetDomainInfo() 2018-09-04 02:31:27 +02:00
script PEP8: fix E401: multiple imports on one line 2018-08-24 07:49:30 +02:00
scripting samba_dnsupdate: honor 'dns zone scavenging' option, only update if needed 2018-09-12 18:03:10 +02:00
selftest PY3: wrap filter calls with list where list is expected 2018-09-16 06:16:20 +02:00
setup provision: Add support for BIND 9.12.x 2018-08-10 05:36:19 +02:00
smb_server samdb: Add remote address to connect 2018-05-10 20:02:23 +02:00
smbd samba: read backup date field on init and fail if present 2018-06-28 03:34:26 +02:00
torture PY3: use pyembed_libname for library names (otherwise missing deps) 2018-09-16 06:16:20 +02:00
utils tests/demote: replace demote test bash script to python 2018-06-07 04:21:17 +02:00
web_server PY3: use pyembed_libname for library names (otherwise missing deps) 2018-09-16 06:16:20 +02:00
winbind samdb: Add remote address to connect 2018-05-10 20:02:23 +02:00
wrepl_server source4/smbd: Do not overstamp the process model with "single" 2017-10-19 05:33:10 +02:00
.clang_complete
.valgrind_suppressions
wscript_build Do not install smbclient4 and nmblookup4 2014-04-15 03:25:13 +02:00