1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-27 03:21:53 +03:00
samba-mirror/source3/libsmb
Andrew Tridgell fc86057354 r20690: fix a bug that causes smbd to 'hang' intermittently.
The problem occurs like this:

  1) running smbd as a domain member without winbindd

  2) client1 connects, during auth smbd-1 calls update_trustdom_cache()

  3) smbd-1 takes the trustdom cache timestamp lock, then starts
     enumerate_domain_trusts

  4) enumerate_domain_trusts hangs for some unknown reason

  5) other clients connect, all block waiting for read lock on trustdom
     cache

  6) samba is now hung

The problem is the lock, and really its just trying to avoid a race
where the cure is worse than the problem. A race in updating the
trutdom cache is not a big issue. So I've just removed the lock.

It is still an open question why enumerate_domain_trusts() can
hang. Unfortunately I've not in a position to get a sniff at the site
that is affected. I suspect a full fix will involve ensuring that all
the rpc code paths have appropriate timeouts.
(This used to be commit ab8d410533)
2007-10-10 12:17:02 -05:00
..
asn1.c r19070: If there's an error in the data struct, there's no point to continue with 2007-10-10 12:15:07 -05:00
cliconnect.c r19250: Fixes bug 4156. 2007-10-10 12:15:25 -05:00
clidfs.c r17571: Change the return code of cli_session_setup from BOOL to NTSTATUS 2007-10-10 11:38:39 -05:00
clidgram.c r10656: BIG merge from trunk. Features not copied over 2007-10-10 11:04:48 -05:00
clientgen.c r20124: clean up nested extern declaration warnings 2007-10-10 12:16:26 -05:00
clierror.c r18865: fixed some of the most obvious NTSTATUS/WERROR mixups in Samba3. It 2007-10-10 12:01:06 -05:00
clifile.c r18009: Fixes bug 4026. 2007-10-10 11:39:47 -05:00
clifsinfo.c r17800: Start using struct timespec internally for file times 2007-10-10 11:38:48 -05:00
clikrb5.c r20403: Cleaning out my Samba 3.0 tree: 2007-10-10 12:16:47 -05:00
clilist.c r18011: Should fix bug 3835. 2007-10-10 11:39:48 -05:00
climessage.c r12043: It's amazing the warnings you find when compiling on a 64-bit 2007-10-10 11:05:42 -05:00
clioplock.c r8572: Remove crufty #define NO_SYSLOG as it's not used at all anymore. 2007-10-10 11:00:11 -05:00
cliprint.c r11511: A classic "friday night check-in" :-). This moves much 2007-10-10 11:05:19 -05:00
cliquota.c r4088: Get medieval on our ass about malloc.... :-). Take control of all our allocation 2007-10-10 10:53:32 -05:00
clirap2.c r19184: W2k3 returns its name for the GetServerInfo RAP call. Do the same. 2007-10-10 12:15:20 -05:00
clirap.c r19231: I encountered a WinXP/Home system which, acting as the master browser for its 2007-10-10 12:15:23 -05:00
clireadwrite.c r17333: Some C++ warnings 2007-10-10 11:38:26 -05:00
clisecdesc.c r18745: Use the Samba4 data structures for security descriptors and security descriptor 2007-10-10 12:00:54 -05:00
clispnego.c r19041: Make us connect to Vista RC1. Apparently metze had done the same patch some 2007-10-10 12:15:05 -05:00
clistr.c r17333: Some C++ warnings 2007-10-10 11:38:26 -05:00
clitrans.c r17333: Some C++ warnings 2007-10-10 11:38:26 -05:00
conncache.c r18533: Ensure we clear out the failed connection cache for an entire 2007-10-10 11:51:48 -05:00
credentials.c r13553: Fix all our warnings at -O6 on an x86_64 box. 2007-10-10 11:10:13 -05:00
dcerpc_err.c r14645: No idea how this happened, fixing the build. 2007-10-10 11:15:41 -05:00
doserr.c r19160: Add new WERR codes seen by working with NETLOGON getdcname. 2007-10-10 12:15:18 -05:00
errormap.c r17677: There is no need for a 2nd krb5_to_nt_status function, is there? 2007-10-10 11:38:46 -05:00
libsmb_cache.c r20269: merge -r20264:20267 from SAMBA_3_0_24 2007-10-10 12:16:38 -05:00
libsmb_compat.c r16360: Fix Klocwork ID 136 520 521 522 523 542 574 575 576 607 2007-10-10 11:18:48 -05:00
libsmbclient.c r20333: Fix a couple of Coverity errors in one run, this was a potential NULL dereference 2007-10-10 12:16:41 -05:00
namecache.c r19249: Attempt to fix a site lookup bug found by Guenther. 2007-10-10 12:15:25 -05:00
namequery_dc.c r20296: If we're going to overwrite krb5.conf 2007-10-10 12:16:39 -05:00
namequery.c r20604: Fix two memleaks, Coverity ID 337, merge to 3_0_24 2007-10-10 12:16:57 -05:00
nmblib.c r15240: Correctly disallow unauthorized access when logging on with the 2007-10-10 11:16:29 -05:00
nterr.c r18891: Fix "double const" warning from host opi 2007-10-10 12:14:42 -05:00
ntlm_check.c r18029: More C++ stuff 2007-10-10 11:43:23 -05:00
ntlmssp_parse.c r10656: BIG merge from trunk. Features not copied over 2007-10-10 11:04:48 -05:00
ntlmssp_sign.c r17976: Fix typo 2007-10-10 11:39:44 -05:00
ntlmssp.c r19936: Patch from Kai Blin <kai.blin@gmail.com> to 2007-10-10 12:16:11 -05:00
passchange.c r19577: Fix from Nils Nordman for bug #4085. Thanks ! 2007-10-10 12:15:42 -05:00
pwd_cache.c r10656: BIG merge from trunk. Features not copied over 2007-10-10 11:04:48 -05:00
samlogon_cache.c r19368: Use WINBINDD_CACHE_TDB_DEFAULT_HASH_SIZE whereever the winbindd tdb is 2007-10-10 12:15:31 -05:00
smb_share_modes.c r20269: merge -r20264:20267 from SAMBA_3_0_24 2007-10-10 12:16:38 -05:00
smb_signing.c r19659: Fix bug #4187. Possible crash in signing on/off code. 2007-10-10 12:15:45 -05:00
smbdes.c r18047: More C++ stuff 2007-10-10 11:43:24 -05:00
smbencrypt.c r18966: this bug affects Samba3 too. I'm actually surprised nobody has 2007-10-10 12:14:52 -05:00
smberr.c r10656: BIG merge from trunk. Features not copied over 2007-10-10 11:04:48 -05:00
spnego.c r13915: Fixed a very interesting class of realloc() bugs found by Coverity. 2007-10-10 11:10:59 -05:00
trustdom_cache.c r20690: fix a bug that causes smbd to 'hang' intermittently. 2007-10-10 12:17:02 -05:00
trusts_util.c r16945: Sync trunk -> 3.0 for 3.0.24 code. Still need 2007-10-10 11:19:14 -05:00
unexpected.c Merge from HEAD - make Samba compile with -Wwrite-strings without additional 2003-01-03 08:28:12 +00:00