1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00
samba-mirror/source4/smbd/service_stream.h
Douglas Bagnall c98bdf2494 smbd/service_stream: connection processing flag is not really bool
The warning is:

../source4/smbd/service_stream.c: In function ‘stream_io_handler’:
../source4/smbd/service_stream.c:94:18: warning: increment of a boolean expression [-Wbool-operation]
  conn->processing++;
                    ^~
../source4/smbd/service_stream.c💯18: warning: decrement of a boolean expression [-Wbool-operation]
  conn->processing--;
                    ^~

while the code in question looks like:

	conn->processing++;
	if (flags & TEVENT_FD_WRITE) {
		conn->ops->send_handler(conn, flags);
	} else if (flags & TEVENT_FD_READ) {
		conn->ops->recv_handler(conn, flags);
	}
	conn->processing--;

If this is never going to be nested, processing can be bool and the ++
and -- can be true/false assignments. But it seems possible that these
might be nested so it is better to go the other way.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Thu Dec  1 00:28:05 CET 2016 on sn-devel-144
2016-12-01 00:28:05 +01:00

80 lines
2.3 KiB
C

/*
Unix SMB/CIFS implementation.
structures specific to stream servers
Copyright (C) Stefan (metze) Metzmacher 2004
Copyright (C) Andrew Tridgell 2005
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#ifndef __SERVICE_STREAM_H__
#define __SERVICE_STREAM_H__
#include "librpc/gen_ndr/server_id.h"
/* modules can use the following to determine if the interface has changed
* please increment the version number after each interface change
* with a comment and maybe update struct stream_connection_critical_sizes.
*/
/* version 0 - initial version - metze */
#define SERVER_SERVICE_VERSION 0
/*
top level context for an established stream connection
*/
struct stream_connection {
const struct stream_server_ops *ops;
const struct model_ops *model_ops;
struct server_id server_id;
void *private_data;
struct {
struct tevent_context *ctx;
struct tevent_fd *fde;
} event;
struct socket_context *socket;
struct imessaging_context *msg_ctx;
struct loadparm_context *lp_ctx;
struct tstream_context *tstream;
struct tsocket_address *local_address;
struct tsocket_address *remote_address;
/*
* this transport layer session info, normally NULL
* which means the same as an anonymous session info
*/
struct auth_session_info *session_info;
uint processing;
const char *terminate;
};
/* operations passed to the service_stream code */
struct stream_server_ops {
/* the name of the server_service */
const char *name;
void (*accept_connection)(struct stream_connection *);
void (*recv_handler)(struct stream_connection *, uint16_t);
void (*send_handler)(struct stream_connection *, uint16_t);
};
void stream_terminate_connection(struct stream_connection *srv_conn, const char *reason);
#endif /* __SERVICE_STREAM_H__ */