1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-13 13:18:06 +03:00
samba-mirror/python/samba
Noel Power 744acb276c python/samba: PY3 don't call str for bytes (or str)
Note: Fix needed also for gpo.apply

minPwdAge, maxPwdAge, minPwdLength & set_pwdProperties all
have a line like

value = str(value).encode('utf8')

this is a generic type statement I guess to convert int, float etc
to utf8 encoded bytes representing the string value for those.

This worked fine in PY2 but in py3 some routine already are passing
bytes into these methods, in these cases e.g. b'200' will get converted
to "b'200'", this change only performs the conversion above for non
bytes (or str) types by replacing the above with

        if not isinstance(value, binary_type):
            value = str(value).encode('utf8')

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2018-12-10 10:38:22 +01:00
..
emulate traffic_replay: Add a max-members option to cap group size 2018-12-04 12:22:50 +01:00
gp_parse python/samba/gp_parse: PY2/PY3 Decode only when necessary 2018-11-05 20:05:24 +01:00
kcc python/kcc/graph: import KCCError, which is used somewhere 2018-11-01 05:08:13 +01:00
netcmd python/samba/netcmd: PY3 fix samba4.blackbox.trust_utils test 2018-12-10 10:38:21 +01:00
provision python/samba/provision: PY3 port samba4.dlz_bind9.version 2018-11-14 05:07:15 +01:00
samba3 python/samba3: import passdb in the manner it is used 2018-11-01 05:08:14 +01:00
subunit PEP8: fix E701: multiple statements on one line (colon) 2018-08-24 07:49:30 +02:00
tests python/samba: PY3 port gpo.apply smbtorture test 2018-12-10 10:38:22 +01:00
web_server s4/web_server: PY3: port to python3 2018-09-27 01:54:27 +02:00
__init__.py python/samba: PY3 ord needs 'str' type not int 2018-12-10 10:38:21 +01:00
colour.py python/colour: add colourizing and switch functions 2018-05-31 01:57:17 +02:00
common.py python: avoid useless work in dsdb_Dn.__cmp__ 2018-11-01 05:08:12 +01:00
compat.py python/samba: fix default params for PY3 ConfigParser 2018-12-10 10:38:22 +01:00
dbchecker.py Fix spelling mistakes 2018-11-30 03:35:13 +01:00
descriptor.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
dnsserver.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
domain_update.py python/domain_update: remove unused imports 2018-10-25 21:45:53 +02:00
drs_utils.py drs_utils: Avoid invalid dereference of v8 requests 2018-11-06 07:15:33 +01:00
forest_update.py python/forest_update: remove unused imports 2018-10-25 21:45:53 +02:00
getopt.py python/samba: PY3 fix can't compare string with int 2018-11-14 05:07:17 +01:00
gp_ext_loader.py python/gp_ext_loader: remove unused imports 2018-10-25 21:45:53 +02:00
gp_sec_ext.py python/samba: PY3 port gpo.apply smbtorture test 2018-12-10 10:38:22 +01:00
gpclass.py python/samba: PY3 port gpo.apply smbtorture test 2018-12-10 10:38:22 +01:00
graph.py PEP8: fix E303: too many blank lines (2) 2018-08-24 07:49:30 +02:00
hostconfig.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
idmap.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
join.py PY3: net.change_password & net.set_password take string not bytes 2018-12-10 10:38:21 +01:00
logger.py logger: use color automatically for a tty 2018-11-21 10:46:20 +01:00
mdb_util.py mdb_util: Better error message if lmdb-utils not installed 2018-11-09 21:07:47 +01:00
ms_display_specifiers.py python/samba: port open to io.open for PY2/PY3 compat 2018-09-03 03:22:20 +02:00
ms_forest_updates_markdown.py python/samba: PY3 port samba4.blackbox.functionalprep 2018-10-23 05:50:28 +02:00
ms_schema_markdown.py PEP8: fix E305: expected 2 blank lines after class or function definition, found 1 2018-08-24 07:49:30 +02:00
ms_schema.py python/samba: port open to io.open for PY2/PY3 compat 2018-09-03 03:22:20 +02:00
ndr.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
ntacls.py python/ntacls: remove unused imports 2018-10-25 21:45:53 +02:00
remove_dc.py python/remove_dc: fix Exception construction 2018-11-01 05:08:13 +01:00
samdb.py python/samba: PY3 don't call str for bytes (or str) 2018-12-10 10:38:22 +01:00
schema.py python/schema: remove unused import 2018-10-25 21:45:53 +02:00
sd_utils.py PEP8: fix E231: missing whitespace after ',' 2018-08-24 07:49:28 +02:00
sites.py PEP8: fix E128: continuation line under-indented for visual indent 2018-08-24 07:49:27 +02:00
subnets.py python/subnets: use the correct variable name 2018-11-01 05:08:11 +01:00
tdb_util.py PEP8: fix E302: expected 2 blank lines, found 1 2018-08-24 07:49:29 +02:00
upgrade.py PEP8: improve formatting around bit-wise OR ("|") 2018-08-24 07:49:32 +02:00
upgradehelpers.py python/upgradehelpers: use mkstemp, not mktemp 2018-11-07 17:55:08 +01:00
uptodateness.py uptodateness: add get_utdv_summary function 2018-10-18 06:15:25 +02:00
xattr.py python/xattr: remove unused variable 2018-11-01 05:08:14 +01:00