1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
samba-mirror/selftest
Stefan Metzmacher 7baeeece2d s3:smbd: let mkdir_internal() work more atomically using a temporary name
Currently we do this in mkdir_internal():

mkdirat(client_name);
if (EEXIST) {
   return EEXIST;
}
prepare_acls(client_name);

Note 'prepare_acls()' is a placeholder for the complex steps
it is doing to prepare the directory. During these steps
we have the problem that other clients already see
the directory and are able to create files or subdirectories
in it and these may not inherit the correct acls as
the their parent directory is not created completely.

I think I found a good strategie even without relying on
renameat2(RENAME_NOREPLACE).

We would do this instead:

tmp_name = ".::TMPNAME:D:$PID:client_name"
mkdirat(tmp_name, mode=client_mode);
prepare_acls(tmp_name);
mkdirat(client_name, mode=0);
if (EEXIST) {
   unlinkat(tmp_name);
   return EEXIST;
}
renameat(tmp_name, client_name);

So instead of having a long windows during prepare_acls,
we just have a short window between mkdirat(client_name, mode=0)
and renameat(tmp_name, client_name);
And in that short window the directory with the client_name
has a mode of 0, so it's not possible for other clients
to create files or subdirs in it.

As the mkdirat(client_name, mode=0) still catches
EEXIST the race where two clients try to create
the same client_name is closed as before,
so we don't need any other protection.

Following patches will make use of renameat2(RENAME_NOREPLACE),
but this already a very good improvement.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15693

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
2024-08-21 08:02:30 +00:00
..
expectedfail.d python/samba/tests/krb5: Add tests for password expiry with krb5 ENC-TS 2024-06-13 00:45:36 +00:00
flapping.d tests/ntacls: unblock failing gitlab pipelines because test_setntacl_forcenative 2024-05-10 00:26:35 +00:00
gnupg
knownfail_heimdal_kdc.d selftest: Move Heimdal Kerberos knownfails to separate files in their own directory 2024-07-23 22:42:39 +00:00
knownfail_mit_kdc.d selftest: Move MIT Kerberos knownfails to separate files in their own directory 2024-07-23 23:47:43 +00:00
knownfail.d s3:smbd: let mkdir_internal() work more atomically using a temporary name 2024-08-21 08:02:30 +00:00
manage-ca selftest: Fix code spelling 2023-07-05 06:34:32 +00:00
ns selftest: Fix code spelling 2023-07-05 06:34:32 +00:00
sanitizer selftest: Add Address Sanitizer suppressions 2022-09-08 22:34:36 +00:00
target tests: Test parametric per-user syntax for hide/veto files 2024-07-31 08:39:29 +00:00
checkpassword_arg1.sh selftest: Reformat shell scripts 2022-03-03 00:59:34 +00:00
create_smb1_fail_skipfile.txt selftest: Fix code spelling 2023-07-05 06:34:32 +00:00
devel_env.sh selftest: Update devel_env.sh for SAMBA_DCERPCD_DONT_LOG_STDOUT=1 2023-01-26 14:10:36 +00:00
expectedfail_heimdal s4:selftest: also test samba4.ldb.simple.ldap with starttls and SASL-BIND 2024-04-23 23:50:34 +00:00
filter-subunit
flapping selftest: Remove samba3.blackbox.smbclient_tar from flapping tests 2020-12-01 19:06:45 +00:00
format-subunit selftest: be less confident in commending st/summary 2022-12-01 22:56:39 +00:00
format-subunit-json python: remove all 'from __future__ import print_function' 2021-04-28 03:43:34 +00:00
gdb_backtrace selftest/gdb_backtrace: print info threads and some signpost headers 2024-03-20 23:42:34 +00:00
gdb_backtrace_test.c
gdb_run selftest: Reformat shell scripts 2022-03-03 00:59:34 +00:00
in_screen selftest: Reformat shell scripts 2022-03-03 00:59:34 +00:00
knownfail selftest: Remove samba4.rpc.lsa.forest.trust from knownfail 2024-07-18 11:27:38 +00:00
knownfail_heimdal_kdc selftest: Move Heimdal Kerberos knownfails to separate files in their own directory 2024-07-23 22:42:39 +00:00
knownfail_mit_kdc selftest: Move MIT Kerberos knownfails to separate files in their own directory 2024-07-23 23:47:43 +00:00
knownfail-32bit torture:charset: use < and > assertions for strncasecmp_m 2024-04-10 22:56:33 +00:00
no-python-tests.txt
perf_tests.py perftest: ndr_pack runs in none environment 2024-02-08 02:48:44 +00:00
quick selftest/quick: add smb2.session 2022-02-02 17:36:35 +00:00
README
save.env.sh selftest: Reformat shell scripts 2022-03-03 00:59:34 +00:00
selftest.pl selftest: setup pam_matrix in the simpleserver env 2024-07-17 10:12:36 +00:00
selftest.pl.1
selftesthelpers.py tests: Make timelimit available to test scripts 2023-06-01 21:00:36 +00:00
skip third_party/heimdal: Import lorikeet-heimdal-202405090452 (commit 49c8e97b7221db53355258059ef385c856e1385f) 2024-05-16 02:11:37 +00:00
skip_mit_kdc s4:mitkdc: Add support for S4U2Self & S4U2Proxy 2022-03-04 14:05:31 +00:00
skip-32bit gitlab-ci: do some basic testing on ubuntu1804-32bit 2022-11-24 12:05:26 +00:00
skip.no-GSS_KRB5_CRED_NO_CI_FLAGS_X
skip.opath-required smbd: use safe_symlink_target_path() in symlink_target_below_conn() 2024-01-22 10:53:29 +00:00
slow
slow-none ldb: Move tests to selftest/tests.py and out of standlone build 2024-03-01 02:41:36 +00:00
SocketWrapper.pm
Subunit.pm selftest: Fix subunit reporting the time incorrectly 2023-08-21 23:37:29 +00:00
subunithelper.py selftest: Use now() instead of utcnow() 2023-10-13 03:50:31 +00:00
tap2subunit selftest: Don’t use invalid escape sequences 2023-08-30 02:15:29 +00:00
tests.py selftest: run the cmdline tests that we already have 2024-07-03 01:35:31 +00:00
TODO
todo_smb2_tests_to_port.list selftest: Fix code spelling 2023-07-05 06:34:32 +00:00
ubsan.supp selftest: Remove ubsan suppressions 2023-10-25 22:23:37 +00:00
valgrind_run
wscript selftest: Move MIT Kerberos knownfails to separate files in their own directory 2024-07-23 23:47:43 +00:00

# vim: ft=rst

This directory contains test scripts that are useful for running a
bunch of tests all at once.

There are two parts to this:

 * The test runner (selftest/selftest.pl)
 * The test formatter

selftest.pl simply outputs subunit, which can then be formatted or analyzed
by tools that understand the subunit protocol. One of these tools is
format-subunit, which is used by default as part of "make test".

Available testsuites
====================
The available testsuites are obtained from a script, usually
source{3,4}/selftest/tests.py. This script should for each testsuite output
the name of the test, the command to run and the environment that should be
provided. Use the included "plantest" function to generate the required output.

Testsuite behaviour
===================

Exit code
------------
The testsuites should exit with a non-zero exit code if at least one
test failed. Skipped tests should not influence the exit code.

Output format
-------------
Testsuites can simply use the exit code to indicate whether all of their
tests have succeeded or one or more have failed. It is also possible to
provide more granular information using the Subunit protocol.

This protocol works by writing simple messages to standard output. Any
messages that can not be interpreted by this protocol are considered comments
for the last announced test.

For a full description of the subunit protocol, see the README file in the subunit
repository at http://github.com/testing-cabal/subunit.

The following commands are Samba extensions to Subunit:

start-testsuite
~~~~~~~~~~~~~~~
start-testsuite: name

The testsuite name is used as prefix for all containing tests.

skip-testsuite
~~~~~~~~~~~~~~
skip-testsuite: name

Mark the testsuite with the specified name as skipped.

testsuite-success
~~~~~~~~~~~~~~~~~
testsuite-success: name

Indicate that the testsuite has succeeded successfully.

testsuite-fail
~~~~~~~~~~~~~~
testsuite-fail: name

Indicate that a testsuite has failed.

Environments
============
Tests often need to run against a server with particular things set up,
a "environment". This environment is provided by the test "target": Samba 3,
Samba 4 or Windows.

The environments are currently available include

 - none: No server set up, no variables set.
 - dc,s3dc: Domain controller set up. The following environment variables will
   be set:

     * USERNAME: Administrator user name
     * PASSWORD: Administrator password
     * DOMAIN: Domain name
     * REALM: Realm name
     * SERVER: DC host name
     * SERVER_IP: DC IPv4 address
     * SERVER_IPV6: DC IPv6 address
     * NETBIOSNAME: DC NetBIOS name
     * NETIOSALIAS: DC NetBIOS alias

 - member,s4member,s3member: Domain controller and member server that is joined to it set up. The
   following environment variables will be set:

     * USERNAME: Domain administrator user name
     * PASSWORD: Domain administrator password
     * DOMAIN: Domain name
     * REALM: Realm name
     * SERVER: Name of the member server

See Samba.pm, Samba3.pm and Samba4.pm for the full list.

Running tests
=============

To run all the tests use::

   make test

To run a quicker subset run::

   make quicktest

To run a specific test, use this syntax::

   make test TESTS=testname

for example::

   make test TESTS=samba4.BASE-DELETE