samba-mirror

mirror of https://github.com/samba-team/samba.git synced 2025-02-23 09:57:40 +03:00

History

Amitay Isaacs 04a061e4d1 ctdb-io: Do not use sys_write to write to client sockets

When sending messages to clients, ctdb checks for EAGAIN error code and
schedules next write in the subsequent event loop.  Using sys_write in
these places causes ctdb to loop hard till a client is able to read from
the socket.  With real time scheduling, ctdb daemon spins consuming 100%
of CPU trying to write to the client sockets.  This can be quite harmful
when running under VMs or machines with single CPU.

This regression was introduced when all read/write calls were replaced to
use sys_read/sys_write wrappers (c1558adeaa980fb4bd6177d36250ec8262e9b9fe).

The existing code backs off in case of EAGAIN failures and waits for an
event loop to process the write again.  This should give ctdb clients
a chance to get scheduled and to process the ctdb socket.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>

Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Tue Feb 24 12:29:30 CET 2015 on sn-devel-104

2015-02-24 12:29:30 +01:00

cmdline.c

ctdb: Change default debug level to NOTICE (2)

2015-02-18 05:34:06 +01:00

ctdb_fork.c

ctdb-logging: Remove log ringbuffer

2014-10-06 12:34:32 +02:00

ctdb_io.c

ctdb-io: Do not use sys_write to write to client sockets

2015-02-24 12:29:30 +01:00

ctdb_logging.c

ctdb-logging: Rework debug level parsing