Douglas Bagnall dab828f63c pytest/source_char: check for mixed direction text ... As pointed out in https://lwn.net/Articles/875964, forbidding bidi marker characters is not always going to be enough to avoid right-to-left vs left-to-right confusion. Consider this: $ python -c's = "b = x # 2 * n * m"; print(s); print(s.replace("x", "א").replace("n", "ח"))' b = x # 2 * n * m b = א # 2 * ח * m Those two lines are semantically the same, with the Hebrew letters "א" and "ח" replacing "x" and "n". But they look like they mean different things. It is not enough to say we only allow these scripts (or indeed non-ascii) in strings and comments, as demonstrated in this example: $ python -c's = "b = \"x#\" # n"; print(s); print(s.replace("x", "א").replace("n", "ח"))' b = "x#" # n b = "א#" # ח where the second line is visually disordered but looks valid. Any series of neutral characters between teo RTL characters will be reversed (and possibly mirrored). In practice this affects one file, which is a text file for testing unicode normalisation. I think, for the reasons shown above, we are unlikely to see legitimate RTL code outside perhaps of documentation files — but if we do, we can add those files to the allow-list. Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Dec 3 18:53:43 UTC 2021 on sn-devel-184		2021-12-03 18:53:43 +00:00
..
printing
samba3	s4:torture:libsmbclient: make use of PROTOCOL_* enum values instead of of hardcoded int values	2021-07-15 00:06:31 +00:00
ldif-utils-test-multisite.ldif
minschema_classes.txt
replication-ndrpack-example.gz
source-chars-bad.c	test/bad_chars: ensure our tests could fail	2021-11-17 04:36:36 +00:00
source-chars-bidi.py	pytest/source_char: check for mixed direction text	2021-12-03 18:53:43 +00:00
traffic-sample-very-short.txt	scripts: Scripts to replay and generate samba traffic	2017-08-17 04:06:06 +02:00
unconnected-intrasite.ldif