samba-mirror

mirror of https://github.com/samba-team/samba.git synced 2025-01-26 10:04:02 +03:00

History

Michael Adam 8732e2356f recovery: data corruption of persistent DBs after recoveries: don't delete emtpy records

The record-by-record mode of recovery deletes empty records.
For persistent databases, this can lead to data corruption
by deleting records that should be there:

- Assume the cluster has been running for a while.

- A record R in a persistent database has been created and
  deleted a couple of times, the last operation being deletion,
  leaving an empty record with a high RSN, say 10.

- Now a node N is turned off.

- This leaves the local database copy of D on N with the empty
  copy of R and RSN 10. On all other nodes, the recovery has deleted
  the copy of record R.

- Now the record is created again while node N is turned off.
  This creates R with RSN = 1 on all nodes except for N.

- Now node N is turned on again. The following recovery will chose
  the older empty copy of R due to RSN 10 > RSN 1.

==> Hence the record is gone after the recovery.

On databases like Samba's registry, this can damage the higher-level
data structures built from the various tdb-level records.

This patch fixes that problem by not deleting empty records in recoveries
for persistent databases.

Signed-off-by: Michael Adam <obnox@samba.org>

(This used to be ctdb commit 6860c79aea416f56cfd7a6af790bbdf495dbc54e)

2012-11-20 00:48:24 +01:00

ctdb_banning.c

Remove explicit include of lib/tevent/tevent.h.

2012-04-13 17:28:14 +10:00

ctdb_call.c

STATISTICS: Add tracking of the 10 hottest keys per database measured in hopcount

2012-06-13 16:19:18 +10:00

ctdb_control.c

Run the shutdown eventscript before we tear down the transport

2012-05-30 11:51:38 +10:00

ctdb_daemon.c

ctdbd: Return explicit boolean values for function returning bool