Jeremy Allison b2ce2441a3 s3: libsmbclient: Work around bugs in SLES cifsd and Apple smbx SMB1 servers. ...

SLES's cifsd and Apple's smbx do not correctly handle FILE_NON_DIRECTORY_FILE
which prevents recursive copies in gvfs from working correctly [1] since GVFS
tries to open the directory, expecting ENOTDIR, but it suceeds and appears as a
zero byte file.

This fix adds code to the cli_open() open code that checks if
CreateOptions was requested with FILE_NON_DIRECTORY_FILE set,
and if the attributes returned include FILE_ATTRIBUTE_DIRECTORY
we synchronously close the file handle just opened, and return
NT_STATUS_FILE_IS_A_DIRECTORY to the caller.

Depends on the previous API update to cli_ntcreate()
to add returned attributes.

Fixes bug #10587 - Opening directories on SLES's cifsd and Apple's smbx succeeds.

https://bugzilla.samba.org/show_bug.cgi?id=10587

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

2014-05-09 23:10:07 +02:00

..

ABI

libsmb: add ABI/smbclient-0.2.1.sigs

2013-06-11 10:50:41 -07:00

async_smb.c

s3:libsmb: don't pass down FLAG_CASELESS_PATHNAMES and FLAGS2_DFS_PATHNAMES anymore

2013-10-17 16:14:58 +02:00

auth_generic.c

s3-auth: Register ncalrpc_as_system gensec module.

2014-04-24 11:21:05 +02:00

cli_smb2_fnum.c

s3: client - rename 'struct smb2_create_returns' to 'struct smb_create_returns' so we can use this in SMB1 create returns as well.

2014-05-09 23:10:07 +02:00

cli_smb2_fnum.h

s3: client - rename 'struct smb2_create_returns' to 'struct smb_create_returns' so we can use this in SMB1 create returns as well.

2014-05-09 23:10:07 +02:00

cliconnect.c

param: rename lp function and variable from "cli_minprotocol" to "client_min_protocol"

2014-02-07 16:19:15 -08:00

clidfs.c

param: rename lp function and variable from "cli_minprotocol" to "client_min_protocol"

2014-02-07 16:19:15 -08:00

clidgram.c

param: rename lp function and variable from 'piddir' to 'pid_directory'

2014-02-07 16:19:11 -08:00

clidgram.h

Fix bug #8953 - winbind can hang as nbt_getdc() has no timeout.

2012-05-22 16:25:14 -07:00

clientgen.c

s3:libsmb: remove unused cli_state->case_sensitive

2013-10-17 16:24:52 +02:00

clierror.c

s3:libsmb: get rid of cli_state_disconnect

2012-05-28 14:49:49 +02:00

clifile.c

s3: libsmbclient: Work around bugs in SLES cifsd and Apple smbx SMB1 servers.

2014-05-09 23:10:07 +02:00

clifsinfo.c

auth/gensec: remove tevent_context argument from gensec_update()

2014-03-27 00:36:32 +01:00

clilist.c

s3-client: smbclient shows no error if deleting a directory with del failed

2013-11-14 21:23:07 +01:00

climessage.c

s3:libsmb: s/struct event_context/struct tevent_context

2013-02-19 23:47:54 +01:00

clioplock.c

s3:libsmb: s/struct event_context/struct tevent_context

2013-02-19 23:47:54 +01:00

cliprint.c

s3:libsmb: get rid of cli_state_server_time_zone

2012-05-28 14:49:48 +02:00

cliquota.c

s3: client : Add extra return parameter to all client open calls.

2014-05-09 23:10:07 +02:00

clirap2.c

libsmb: Fix CID 241313 Array compared against 0

2013-11-11 21:04:09 +01:00

clirap.c

lib-util: rename memdup to smb_memdup and fix all callers

2014-04-16 20:39:08 +02:00

clirap.h

s3:libsmb: add function cli_qpathinfo3()

2013-10-30 15:23:51 -07:00

clireadwrite.c

s3:libsmb: add support for SMB2 in cli_writeall()

2013-08-15 09:07:07 +02:00

clisecdesc.c

s3:libsmb: Plumb cli_smb2_set_security_descriptor() inside cli_set_security_descriptor().

2013-08-15 09:07:07 +02:00

clispnego.c

Fix bug #9213 - Bad ASN.1 NegTokenInit packet can cause invalid free.

2012-09-26 04:07:57 +02:00

clistr.c

s3:libsmb: remove unused clistr_push_fn()

2011-07-07 19:16:28 +02:00

clisymlink.c

s3: client : Add extra return parameter to all client open calls.

2014-05-09 23:10:07 +02:00

clitrans.c

s3:libsmb: don't pass down FLAG_CASELESS_PATHNAMES and FLAGS2_DFS_PATHNAMES anymore

2013-10-17 16:14:58 +02:00

conncache.c

lib: Use "mem_ctx" arg in gencache_get

2013-09-05 20:09:21 +02:00

dsgetdcname.c

s3-dsgetdcname: print IP address for LDAP ping.

2014-02-13 14:31:44 +01:00

errormap_wbc.c

s3-errormap: move (unused) map_nt_error_from_wbcErr out of errormap.

2011-02-25 01:08:41 +01:00

errormap_wbc.h

source3/libsmb/errormap_wbc.h: fix licence/copyright

2011-06-10 15:12:27 +02:00

errormap.c

s3-libsmb: Remove dead gssapi code.

2012-02-01 23:29:44 +01:00

libsmb_cache.c

Fix some blank line endings

2013-06-21 19:57:06 +02:00

libsmb_compat.c

Fix some blank line endings

2013-06-21 19:57:06 +02:00

libsmb_context.c

libsmbclient: Wrap more function calls in talloc_stackframe() to protect against talloc_tos() calls

2014-04-02 02:36:08 +02:00

libsmb_dir.c

s3-rpc_cli: pass down ndr_interface_table to cli_rpc_pipe_open_noauth().

2013-08-05 10:30:00 +02:00

libsmb_file.c

s3:libsmb: SMBC_getatr() if no method worked, try all methods again on next attempt

2013-10-30 15:23:51 -07:00

libsmb_misc.c

Fix some blank line endings

2013-06-21 19:57:06 +02:00

libsmb_path.c

Fix some blank line endings

2013-06-21 19:57:06 +02:00

libsmb_printjob.c

Fix some blank line endings

2013-06-21 19:57:06 +02:00

libsmb_server.c

param: rename lp function and variable from "cli_minprotocol" to "client_min_protocol"

2014-02-07 16:19:15 -08:00

libsmb_setget.c

libsmb: Provide a talloc_stackframe() to external users of libsmb_setget.c

2014-04-02 00:31:48 +02:00

libsmb_stat.c

s3/libsmb: make use of smbXcli_tcon_is_dfs_share()

2013-10-17 16:17:27 +02:00

libsmb_thread_impl.c

Provide a libsmbclient interface for programs requiring threads

2009-05-10 22:45:12 -04:00

libsmb_thread_posix.c

s3: fix detection and flags for using pthread

2010-01-26 00:19:10 +01:00

libsmb_xattr.c

s3: client : Add extra return parameter to all client open calls.

2014-05-09 23:10:07 +02:00

libsmb.h

s3:libsmb: Add in the core of the libsmb client SMB2 functions.

2013-08-15 09:07:06 +02:00

namecache.c

lib: Use "mem_ctx" arg in gencache_get

2013-09-05 20:09:21 +02:00

namequery_dc.c

s3-kerberos: remove unused kdc_name from create_local_private_krb5_conf_for_domain().

2014-03-07 18:43:57 +01:00

namequery.c

param: rename lp function and variable from 'passwordserver' to 'password_server'

2014-02-07 16:19:10 -08:00

nmblib.c

s3-libsmb: Remove check if array is NULL.

2012-12-21 13:56:01 +01:00

nmblib.h

source3/libsmb/nmblib.h: fix licence/copyright

2011-06-10 15:12:31 +02:00

ntlmssp_wrap.c

auth/gensec: introduce gensec_internal.h

2013-08-10 09:19:02 +02:00

ntlmssp.c

build: Build with system md5.h on OpenIndiana

2013-06-19 21:32:36 +02:00

passchange.c

s3-rpc_cli: pass down ndr_interface_table to cli_rpc_pipe_open_noauth().

2013-08-05 10:30:00 +02:00

proto.h

s3: client : Add extra return parameter to all client open calls.

2014-05-09 23:10:07 +02:00

pylibsmb.c

s3: client : Add extra return parameter to all client open calls.

2014-05-09 23:10:07 +02:00

reparse_symlink.c

s3: Fix symlink_reparse_buffer_parse

2011-07-03 11:31:29 +02:00

samlogon_cache.c

s3: Fix some False/NULL hickups

2011-12-20 13:13:17 +01:00

smb2cli_tcon.c

s3:libsmb: only set tcon to invalid in smb2cli_tdis*

2013-08-15 09:07:07 +02:00

smb2cli.h

libcli/smb: move smb2cli_ioctl.c from source3 to the toplevel

2012-05-15 20:17:01 +02:00

smb_share_modes.c

Remove uid_wrapper related code.

2014-04-17 14:56:05 +02:00

smbclient.pc.in

libsmbclient: add ABI checking and pc file

2011-10-18 11:24:55 +11:00

smberr.c

s3:libsmb: remove unused smb_dos_errstr()

2011-07-08 14:09:10 +02:00

smbsharemodes.pc.in

build: Provide .pc file for libsmbsharemodes

2012-05-30 04:15:11 +02:00

smbsock_connect.c

s3:libsmb: make use of samba_tevent_context_init()

2013-02-19 23:47:46 +01:00

trustdom_cache.c

lib: Use "mem_ctx" arg in gencache_get

2013-09-05 20:09:21 +02:00

trusts_util.c

s3/libsmb: Free memdup'd local variable

2014-02-22 00:58:23 +01:00

unexpected.c

lib: Add before/after hooks to async_connect

2013-05-17 11:22:45 +02:00

wscript

Add smbc_getPort(), smbc_setPort(). Bump the .so minor number.

2013-06-11 10:50:41 -07:00