1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
samba-mirror/source3
Jeremy Allison 8a427783e5 smbd: fix pathref unlinking in create_file_unixpath()
This is really subtle. If someone passes in an smb_fname where smb_fname
actually is taken from fsp->fsp_name, then the lifetime of these objects is
meant to be the same.

This is commonly the case from an SMB1 path-based call
(eg call_trans2qfilepathinfo()) where we use the pathref fsp
(smb_fname->fsp) as the handle. In this case we must not unlink smb_fname->fsp
from it's owner.

The asserts below:

  SMB_ASSERT(fsp->fsp_name->fsp != NULL);
  SMB_ASSERT(fsp->fsp_name->fsp == fsp);

ensure the required invarients are met.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14732

Pair-Programmed-With: Ralph Boehme <slow@samba.org>
Signed-off-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Jun  8 20:44:41 UTC 2021 on sn-devel-184
2021-06-08 20:44:41 +00:00
..
auth auth:creds: Add obtained arg to cli_credentials_set_kerberos_state() 2021-04-28 03:43:34 +00:00
build
client s3:client: Use samba_popt_get_context() 2021-05-20 02:58:36 +00:00
exports
groupdb lib: relicense smb_strtoul(l) under LGPLv3 2020-08-03 22:21:02 +00:00
include s3: smbd: Remove parent_smb_fname(), no longer used. 2021-06-02 06:30:36 +00:00
intl
lib dbwrap_ctdb: Remove "tryonly" from fetch_locked_internal() 2021-06-04 16:47:34 +00:00
libads auth:creds: Add obtained arg to cli_credentials_set_kerberos_state() 2021-04-28 03:43:34 +00:00
libgpo/gpext
libnet libnet: Initialize pointers 2021-06-04 16:47:34 +00:00
librpc rpc: Give dcerpc_util.c its own header 2021-04-06 22:29:34 +00:00
libsmb s3:libsmb: Use cli_credentials to store traversal creds 2021-05-28 02:55:31 +00:00
locale pam_winbind/ro.po: fix error from previous patch merge 2020-10-29 20:49:16 +00:00
locking smbd: Simplify share_mode_entry_do() 2021-06-04 16:47:34 +00:00
modules s3: VFS: linux_xfs_sgid. parent_smb_fname() -> SMB_VFS_PARENT_PATHNAME(). 2021-06-02 05:39:30 +00:00
nmbd nmbd: Reduce the wait interface loop sleep time 2021-05-14 20:52:47 +00:00
param loadparam: add option "acl flag inherited canonicalization" 2021-05-27 19:51:57 +00:00
passdb s3:param:py_param - allocate buffer for nt_name and comment 2021-05-27 22:07:45 +00:00
printing printing: Factor out remove_from_jobs_list() 2021-06-04 16:47:34 +00:00
profile
registry registry: Fix a typo 2021-04-19 18:18:31 +00:00
rpc_client Fix gcc11 compiler issue "-Werror=maybe-uninitialized" 2021-05-07 06:23:32 +00:00
rpc_server rpc_server: Use correct PRIu16 for printf of a uint16 2021-06-04 16:47:34 +00:00
rpcclient s3:rpcclient: Document command of witness protocol 2021-05-25 00:23:37 +00:00
script s3:torture: Migrate vfstest to new cmdline option parser 2021-05-20 02:58:36 +00:00
selftest torture/smb2: ACL inheritance flags test with non-canonical behaviour 2021-05-27 19:01:29 +00:00
services
smbd smbd: fix pathref unlinking in create_file_unixpath() 2021-06-08 20:44:41 +00:00
torture s3: torture: Add regression test for renaming SMB1+POSIX symlinks, dangling and real. 2021-05-24 16:57:37 +00:00
utils s3:utils: Use connection and credentials parser in net util 2021-05-28 02:55:31 +00:00
web
winbindd s3:winbind: Code cleanup for initialize_winbindd_cache() 2021-05-12 20:29:32 +00:00
.clang_complete
.dmallocrc
.indent.pro
Doxyfile
mainpage.dox
smbadduser.in
wscript build: Use bison at build time rather than lexyacc.sh to build the embedded heimdal 2021-04-28 03:43:34 +00:00
wscript_build s3:lib: Remove util_cmdline 2021-05-28 03:41:52 +00:00
wscript_configure_system_ncurses