1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
samba-mirror/ctdb/conf/node.h
Martin Schwenke 45da2281aa ctdb-conf: Add a common node address handling module
These functions are intended to be used in ctdbd, the ctdb tool and
fake_ctdbd, replacing the different copies in each place.

ctdb_read_nodes() will replace ctdb_read_nodes_file().  The name
change is intentional - in future the location may be something other
than a simple filename.

The static copies of ctdb_read_nodes_file() and node_map_add() are
slightly sanitised versions of those in tools/ctdb.c, with a call to
ctdb_parse_node_address().  A bit more care is taken in node_map_add()
to avoid undefined behaviour if talloc_realloc() fails.

ctdb_parse_node_address() will replace ctdb_parse_address().  There is
an obvious argument change, since the ctdb context argument was
unused.  It can only fail on an invalid node address, so return a
bool.  This function might be changed later to allow the input address
string to include an optional port.

Where to put this module isn't entirely clear.  It could go in common,
so be part of ctdb-util.  However, if it later needs
ctdb-conf (e.g. to allow the node list location to be configurable)
then there would be a direct cyclic dependency.  This is configuration
handling, so conf/ seems sane.  However, I didn't want to put it into
the ctdb-conf target, since some code might need to parse a nodes list
but not need to parse ctdb.conf.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
2024-07-23 11:37:34 +00:00

55 lines
1.7 KiB
C

/*
Node file loading
Copyright (C) Martin Andrew Tridgell 2007
Copyright (C) Martin Ronnie Sahlberg 2008, 2009
Copyright (C) Martin Schwenke 2015
Copyright (C) Amitay Isaacs 2015
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
#ifndef __CTDB_COMMON_NODES_H__
#define __CTDB_COMMON_NODES_H__
#include <talloc.h>
#include "protocol/protocol.h"
/**
* @brief Parse node address string, setting CTDB port
*
* Parse a node address string. Set the port number to the CTDB port.
*
* @param[in] str Text node address
* @param[out] address Socket address structure, already allocated
* @return true on success, false on failure
*/
bool ctdb_parse_node_address(const char *str, ctdb_sock_addr *address);
/**
* @brief Load node list into a node map
*
* Load nodes from location, into a node map, allocated off the given
* talloc context. Location must be a filename.
*
* @param[in] mem_ctx Talloc memory context
* @param[in] location Location of nodes list
* @return node map on success, NULL on failure
*/
struct ctdb_node_map *ctdb_read_nodes(TALLOC_CTX *mem_ctx,
const char *location);
#endif /* __CTDB_COMMON_NODES_H__ */