mirror of
https://github.com/samba-team/samba.git
synced 2025-01-10 01:18:15 +03:00
8d00b0e664
This is more lines of code, but it's still a simplification. With this patch we don't call the full openat_pathref_fsp() anymore when looking up the last component in filename_convert_dirfsp(), instead we do the direct SMB_VFS_OPENAT(). We don't need the whole complexity of non_widelink_open() for this case, we do know that we have a real non-cwd dirfsp. The other big change that is not obvious just from looking at the patch: This removes the special case for looking up posix symlinks. Before this patch, filename_convert_dirfsp() returned a proper smb_filename but without an attached fsp when a smb1 posix client hits a symlink. This caused all sorts of special case code everywhere. For example smbd_do_qfilepathinfo() needs to cover both cases just for the smb1 posix symlink case. This special-case handling can go now. We can do the path lookup in the smb1-only qpathinfo code and call into the common code with a proper fsp. When hitting a symlink and with O_PATH available, we'll get the symlink opened with an O_PATH fd. Without O_PATH we obviously can't do that, there we get fd=-1 and an indication that we don't have the procfd fallback around. Why all this? I want to present FIFOs (and eventually symlinks) as reparse points as the very next step. Without this patch, there is no real unified way to get the file attributes from disk. Now we can use the proper logic of fdos_mode() everywhere and not rely on special cases for fsp==NULL. This patch also changes some error codes for smb1 posix extensions. I chose to just change the test instead of going after each and every change. As long as we do get an error, I'm willing to accept that we slightly change error path behaviour for this deprecated code. And, I tried to split this up into smaller patches but I failed. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ralph Boehme <slow@samba.org> |
||
|---|---|---|
| .. | ||
| getdate.c | ||
| getdate.h | ||
| getdate.y | ||
| hash_inode.c | ||
| hash_inode.h | ||
| lib_vxfs.c | ||
| nfs4_acls.c | ||
| nfs4_acls.h | ||
| nfs4acl_xattr_ndr.c | ||
| nfs4acl_xattr_ndr.h | ||
| nfs4acl_xattr_nfs.c | ||
| nfs4acl_xattr_nfs.h | ||
| nfs4acl_xattr_util.c | ||
| nfs4acl_xattr_util.h | ||
| nfs4acl_xattr_xdr.c | ||
| nfs4acl_xattr_xdr.h | ||
| nfs4acl_xattr.h | ||
| nfs41acl.x | ||
| non_posix_acls.c | ||
| non_posix_acls.h | ||
| offload_token.c | ||
| offload_token.h | ||
| posixacl_xattr.c | ||
| posixacl_xattr.h | ||
| README-gpfs-acl.txt | ||
| README.nfs4acls.txt | ||
| test_nfs4_acls.c | ||
| test_vfs_full_audit.c | ||
| test_vfs_gpfs.c | ||
| test_vfs_posixacl.c | ||
| The_New_VFS.org | ||
| The_New_VFS.txt | ||
| util_reparse.c | ||
| util_reparse.h | ||
| vfs_acl_common.c | ||
| vfs_acl_common.h | ||
| vfs_acl_tdb.c | ||
| vfs_acl_xattr.c | ||
| vfs_afsacl.c | ||
| vfs_aio_fork.c | ||
| vfs_aio_pthread.c | ||
| vfs_aixacl2.c | ||
| vfs_aixacl_util.c | ||
| vfs_aixacl_util.h | ||
| vfs_aixacl.c | ||
| vfs_aixacl.h | ||
| vfs_audit.c | ||
| vfs_btrfs.c | ||
| vfs_cacheprime.c | ||
| vfs_cap.c | ||
| vfs_catia.c | ||
| vfs_ceph_snapshots.c | ||
| vfs_ceph.c | ||
| vfs_commit.c | ||
| vfs_crossrename.c | ||
| vfs_default_quota.c | ||
| vfs_default.c | ||
| vfs_delay_inject.c | ||
| vfs_dfs_samba4.c | ||
| vfs_dirsort.c | ||
| vfs_error_inject.c | ||
| vfs_expand_msdfs.c | ||
| vfs_extd_audit.c | ||
| vfs_fake_acls.c | ||
| vfs_fake_dfq.c | ||
| vfs_fake_perms.c | ||
| vfs_fileid.c | ||
| vfs_fruit.c | ||
| vfs_full_audit.c | ||
| vfs_glusterfs_fuse.c | ||
| vfs_glusterfs.c | ||
| vfs_gpfs.c | ||
| vfs_hpuxacl.c | ||
| vfs_hpuxacl.h | ||
| vfs_io_uring.c | ||
| vfs_linux_xfs_sgid.c | ||
| vfs_media_harmony.c | ||
| vfs_nfs4acl_xattr.c | ||
| vfs_not_implemented.c | ||
| vfs_offline.c | ||
| vfs_posix_eadb.c | ||
| vfs_posixacl.c | ||
| vfs_posixacl.h | ||
| vfs_prealloc.c | ||
| vfs_preopen.c | ||
| vfs_readahead.c | ||
| vfs_readonly.c | ||
| vfs_recycle.c | ||
| vfs_shadow_copy2.c | ||
| vfs_shadow_copy.c | ||
| vfs_shell_snap.c | ||
| vfs_snapper.c | ||
| vfs_solarisacl.c | ||
| vfs_solarisacl.h | ||
| vfs_streams_depot.c | ||
| vfs_streams_xattr.c | ||
| vfs_syncops.c | ||
| vfs_time_audit.c | ||
| vfs_tsmsm.c | ||
| vfs_unityed_media.c | ||
| vfs_virusfilter_clamav.c | ||
| vfs_virusfilter_common.h | ||
| vfs_virusfilter_dummy.c | ||
| vfs_virusfilter_fsav.c | ||
| vfs_virusfilter_sophos.c | ||
| vfs_virusfilter_utils.c | ||
| vfs_virusfilter_utils.h | ||
| vfs_virusfilter.c | ||
| vfs_vxfs.c | ||
| vfs_vxfs.h | ||
| vfs_widelinks.c | ||
| vfs_worm.c | ||
| vfs_xattr_tdb.c | ||
| vfs_zfsacl.c | ||
| wscript_build | ||
Configuring NFS4 ACLs in Samba3
===============================
Created: Peter Somogyi, 2006-JUN-06
Last modified: Alexander Werth, 2013-MAY-02
Revision no.: 4
-------------------------------
Parameters in smb.conf:
=======================
Each parameter must have a prefix "nfs4:".
Each one affects the behaviour only when _setting_ an acl on a file/dir:
mode = [simple|special]
- simple: Use OWNER@ and GROUP@ special IDs for non inheriting ACEs only.
This mode is the default.
- special: use OWNER@ and GROUP@ special IDs in ACEs instead of simple
user&group ids. This mode is deprecated.
Note1: EVERYONE@ is always processed (if found such an ACE).
Note2: There is a side effect when _only_ chown is performed.
Later this may be worked out.
Note3: Mode special inherits incorrect ACL entries when the user creating
a file is different from the owner of the caurrent folder.
Note4: Mode simple uses inheriting OWNER@ and GROUP@ special IDs to
support Creator Owner and Creator Group.
It's strongly advised to set "store dos attributes = yes" in smb.conf.
chown = [true|false]
- true => enable changing owner and group - default.
- false => disable support for changing owner or group
acedup = [dontcare|reject|ignore|merge]
- dontcare: copy ACEs as they come, don't care with "duplicate" records.
- reject: stop operation, exit acl setter operation with an error. (deprecated)
- ignore: don't include the second matching ACE. (deprecated)
- merge: OR 2 ace.flag fields and 2 ace.mask fields of the 2 duplicate ACEs into 1 ACE (default)
Two ACEs are considered here "duplicate" when their type and id fields are matching.
Example:
[smbtest]
path = /tests/psomogyi/smbtest
writable = yes
vfs objects = aixacl2
nfs4: mode = special
nfs4: chown = yes
nfs4: acedup = merge
Configuring AIX ACL support
==============================
Binaries: (default install path is [samba]/lib/vfs/)
- aixacl.so: provides AIXC ACL support only, can be compiled and works on all AIX platforms
- aixacl2.so: provides AIXC and JFS2-NFS4 ACL support, can be compiled and works only under AIX 5.3 and newer.
NFS4 acl currently has support only under JFS2 (ext. attr. format must be set to v2).
aixacl2.so always detects support for NFS4 acls and redirects to POSIX ACL handling automatically when NFS4 is not supported for a path.
Adding "vfs objects = aixacl2" to a share should be done only in case when NFS4 is really supported by the filesystem.
(Otherwise you may get performance loss.)
For configuration see also the example above.
General notes
=============
NFS4 handling logic is separated from AIX/jfs2 ACL parsing.
Samba and its VFS modules don't reorder ACEs. Windows clients do that (and the smbcacl tool). MSDN also says deny ACEs must come first.
NFS4 ACL's validity is checked by the system API, not by Samba.
NFS4 ACL rights are enforced by the OS or filesystem, not by Samba.
The flag INHERITED_ACE is never set (not required, as doesn't do WinNT/98/me, only since Win2k).
Win2k GUI behaves strangely when detecting inheritance (sometimes it doesn't detect,
but after adding an ace it shows that - it's some GUI error).
Unknown (unmappable) SIDs are not accepted.
TODOs
=====
- Creator Owner & Group SID handling (same way as posix)
- the 4 generic rights bits support (GENERIC_RIGHT_READ_ACCESS, WRITE, EXEC, ALL)
- chown & no ACL, but we have OWNER@ and GROUP@
- DIALUP, ANONYMOUS, ... builtin SIDs
- audit & alarm support - in theory it's forwarded so it should work, but currently there's no platform which supports them to test
- support for a real NFS4 client (we don't have an accepted API yet)