1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
samba-mirror/python/samba
Steve Howells 9198246f91 s4.2/fsmo.py: fixed fsmo transfer exception
In transfer_role() there is an duplicate call to samdb.modify() inside the if statement
where the type of role is being determined (specifically for the naming fsmo). This
call is unnecessary as after the if statement their is a correct call, with a try/catch
block, used by all fsmo transfers that will handle errors - such as the DC with the
fsmo role being offline.

The call to samdb.modify() inside the if statement for naming fsmo has been removed.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10924

Signed-off-by: Steve Howells <steve.howells@moscowfirst.com>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Marc Muehlfeld <mmuehlfeld@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2015-03-16 03:00:06 +01:00
..
netcmd s4.2/fsmo.py: fixed fsmo transfer exception 2015-03-16 03:00:06 +01:00
provision provision: Give a more helpful message when find_provision_key_parameters() fails 2015-03-06 20:11:52 +01:00
samba3 source4/scripting/python/samba/samba3: handle ntdb files. 2013-04-12 14:59:16 -07:00
subunit Drop support for failfast mode, rather than adding support for it everywhere. 2015-03-06 04:41:48 +01:00
tests selftest: modify python.samba.test.posixacl to cope with nss_winbind active 2015-03-12 14:35:06 +01:00
web_server Move python modules from source4/scripting/python/ to python/. 2013-03-02 03:57:34 +01:00
__init__.py Remove 'external' python module support code - use the third_party directory instead. 2015-03-06 04:41:48 +01:00
common.py scripting: Correct parsing of binary DN 2013-03-04 08:24:02 +01:00
dbchecker.py dbcheck: Add check and test for various invalid userParameters values 2014-07-09 08:42:08 +02:00
descriptor.py join.py: Set NT ACL on crossRef object for new partition 2014-09-02 14:15:54 +02:00
drs_utils.py Fix more pep8 issues in code I touched recently. 2014-10-14 06:44:06 +02:00
getopt.py samba-tool: Add -P to options.CredentialsOptions 2015-03-06 17:39:58 +01:00
hostconfig.py Move python modules from source4/scripting/python/ to python/. 2013-03-02 03:57:34 +01:00
idmap.py Move python modules from source4/scripting/python/ to python/. 2013-03-02 03:57:34 +01:00
join.py join.py: Set NT ACL on crossRef object for new partition 2014-09-02 14:15:54 +02:00
kcc_utils.py Remove last instances of pep8 error E602 (old style exceptions). 2014-10-14 06:44:06 +02:00
ms_display_specifiers.py Move python modules from source4/scripting/python/ to python/. 2013-03-02 03:57:34 +01:00
ms_schema.py Move python modules from source4/scripting/python/ to python/. 2013-03-02 03:57:34 +01:00
ndr.py Move python modules from source4/scripting/python/ to python/. 2013-03-02 03:57:34 +01:00
ntacls.py Move python modules from source4/scripting/python/ to python/. 2013-03-02 03:57:34 +01:00
samdb.py samba-tool: Create NIS enabled users and unixHomeDirectory attribute 2015-02-03 17:18:32 +01:00
schema.py Fix more pep8 issues in code I touched recently. 2014-10-14 06:44:06 +02:00
sd_utils.py s4-dsdb: Tests for security checks on undelete operation 2015-02-03 05:02:11 +01:00
sites.py Move python modules from source4/scripting/python/ to python/. 2013-03-02 03:57:34 +01:00
tdb_util.py Move python modules from source4/scripting/python/ to python/. 2013-03-02 03:57:34 +01:00
upgrade.py python: Use the security.dom_sid type for ctx.domsid in join.py and provision 2014-09-01 00:36:42 +02:00
upgradehelpers.py s4/scripting/devel: Add tool to roll over the krbtgt password 2015-02-25 01:08:12 +01:00
xattr.py Move python modules from source4/scripting/python/ to python/. 2013-03-02 03:57:34 +01:00