1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
samba-mirror/source3/rpc_parse
Volker Lendecke 929e1d9920 r24809: Consolidate the use of temporary talloc contexts.
This adds the two functions talloc_stackframe() and talloc_tos().

 * When a new talloc stackframe is allocated with talloc_stackframe(), then
 * the TALLOC_CTX returned with talloc_tos() is reset to that new
 * frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse
 * happens: The previous talloc_tos() is restored.
 *
 * This API is designed to be robust in the sense that if someone forgets to
 * TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and
 * resets the talloc_tos().

The original motivation for this patch was to get rid of the
sid_string_static & friends buffers. Explicitly passing talloc context
everywhere clutters code too much for my taste, so an implicit
talloc_tos() is introduced here. Many of these static buffers are
replaced by a single static pointer.

The intended use would thus be that low-level functions can rather
freely push stuff to talloc_tos, the upper layers clean up by freeing
the stackframe. The more of these stackframes are used and correctly
freed the more exact the memory cleanup happens.

This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and
lp_talloc_ctx (did I forget any?)

So, never do a

tmp_ctx = talloc_init("foo");

anymore, instead, use

tmp_ctx = talloc_stackframe()

:-)

Volker
(This used to be commit 6585ea2cb7)
2007-10-10 12:30:24 -05:00
..
parse_buffer.c r23801: The FSF has moved around a lot. This fixes their Mass Ave address. 2007-10-10 12:28:27 -05:00
parse_ds.c r23801: The FSF has moved around a lot. This fixes their Mass Ave address. 2007-10-10 12:28:27 -05:00
parse_eventlog.c r23801: The FSF has moved around a lot. This fixes their Mass Ave address. 2007-10-10 12:28:27 -05:00
parse_lsa.c r24809: Consolidate the use of temporary talloc contexts. 2007-10-10 12:30:24 -05:00
parse_misc.c r24809: Consolidate the use of temporary talloc contexts. 2007-10-10 12:30:24 -05:00
parse_net.c r23801: The FSF has moved around a lot. This fixes their Mass Ave address. 2007-10-10 12:28:27 -05:00
parse_ntsvcs.c r24809: Consolidate the use of temporary talloc contexts. 2007-10-10 12:30:24 -05:00
parse_prs.c r24759: Comment out the _nonnull calls for 3.2.x, as agreed with tridge. 2007-10-10 12:30:18 -05:00
parse_rpc.c r23801: The FSF has moved around a lot. This fixes their Mass Ave address. 2007-10-10 12:28:27 -05:00
parse_samr.c r24771: Use infolevel 25 to set the machine account's password (just like winxp). 2007-10-10 12:30:19 -05:00
parse_sec.c r24067: Fix a type mismatch found by the IBM checker 2007-10-10 12:29:01 -05:00
parse_spoolss.c r24809: Consolidate the use of temporary talloc contexts. 2007-10-10 12:30:24 -05:00
parse_svcctl.c r24809: Consolidate the use of temporary talloc contexts. 2007-10-10 12:30:24 -05:00