Andrew Tridgell 95455b5789 r18528: work around what appears to be a compiler bug in gcc on irix. It ...

caused the RPC-SECRETS test to crash smbd in an inlined version of
this memcmp() call. This patch should have absolutely no effect at
all, but in fact it prevents the crash.

Disassembling at the point of the crash, it shows that gcc is inlining
the memcmp(). I don't know enough MIPS assembler to actually spot the
bug. In case anyone reading this does know MIPS assembler, here is the
gcc generated code that crashes:

0x105e0218 <gssapi_krb5_verify_header+168>:     lw      $t1,52($sp)
0x105e021c <gssapi_krb5_verify_header+172>:     lw      $t1,0($t1)
0x105e0220 <gssapi_krb5_verify_header+176>:     lhu     $t1,0($t1)
0x105e0224 <gssapi_krb5_verify_header+180>:     lw      $t2,68($sp)
0x105e0228 <gssapi_krb5_verify_header+184>:     lhu     $t2,0($t2)
0x105e022c <gssapi_krb5_verify_header+188>:     subu    $t1,$t1,$t2

it gets a segv at 0x105e0220.

lha, what do you think of this? The change should be innocuous on all
other platforms, apart from making the code harder to read :(

2007-10-10 14:18:42 -05:00

..

8003.c

r15515: Syncronsise with current lorikeet-heimdal.

2007-10-10 14:05:45 -05:00

accept_sec_context.c

r16235: Don't update minor_status when cleaning up on error. This restores

2007-10-10 14:09:07 -05:00

acquire_cred.c

r12000: Update to current lorikeet-heimdal, including in particular support

2007-10-10 13:46:57 -05:00

add_oid_set_member.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

address_to_krb5addr.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

arcfour.c

r15481: Update heimdal/ to match current lorikeet-heimdal.

2007-10-10 14:05:39 -05:00

arcfour.h

r10153: This patch adds a new parameter to gensec_sig_size(), the size of the

2007-10-10 13:38:04 -05:00

ccache_name.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

cfx.c

r18308: get this right ....

2007-10-10 14:18:06 -05:00

cfx.h

r10153: This patch adds a new parameter to gensec_sig_size(), the size of the

2007-10-10 13:38:04 -05:00

compat.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

context_time.c

r12269: Update to current lorikeet-heimdal. This changed the way the hdb

2007-10-10 13:47:26 -05:00

copy_ccache.c

r11995: A big kerberos-related update.

2007-10-10 13:46:56 -05:00

create_emtpy_oid_set.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

decapsulate.c

r18528: work around what appears to be a compiler bug in gcc on irix. It

2007-10-10 14:18:42 -05:00

delete_sec_context.c

r14198: Update Samba4 to current lorikeet-heimdal.

2007-10-10 13:56:58 -05:00

display_name.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

display_status.c

r11294: Update Heimdal in Samba4 to lorikeet-heimdal (which is in turn updated

2007-10-10 13:45:15 -05:00

duplicate_name.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

encapsulate.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

external.c

r9680: Update Heimdal to current lorikeet-heimdal (which was itself updated

2007-10-10 13:34:39 -05:00

get_mic.c

r15515: Syncronsise with current lorikeet-heimdal.

2007-10-10 14:05:45 -05:00

gssapi_locl.h

r15481: Update heimdal/ to match current lorikeet-heimdal.

2007-10-10 14:05:39 -05:00

gssapi.h

r15481: Update heimdal/ to match current lorikeet-heimdal.

2007-10-10 14:05:39 -05:00

import_name.c

r14198: Update Samba4 to current lorikeet-heimdal.

2007-10-10 13:56:58 -05:00

init_sec_context.c

r15993: don't use u_int32_t, as the main heimdal code also don't use

2007-10-10 14:08:47 -05:00

init.c

r11317: An ugly hack to setup the global gssapi_krb5_context early, when we

2007-10-10 13:45:19 -05:00

inquire_cred.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

release_buffer.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

release_cred.c

r12000: Update to current lorikeet-heimdal, including in particular support

2007-10-10 13:46:57 -05:00

release_name.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

release_oid_set.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

sequence.c

r16100: Patch from Michael Wood <mwood@icts.uct.ac.za>: s/then/than/ for correct grammar

2007-10-10 14:08:59 -05:00

spnego.asn1

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

test_oid_set_member.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

unwrap.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

verify_mic.c

r8302: import mini HEIMDAL into the tree

2007-10-10 13:19:33 -05:00

wrap.c

r15481: Update heimdal/ to match current lorikeet-heimdal.

2007-10-10 14:05:39 -05:00