mirror of
https://github.com/samba-team/samba.git
synced 2025-01-06 13:18:07 +03:00
6b567e0c13
Allocate state off fsp->conn, not NULL, and add a destructor that catches deallocation of conn which happens on connection shutdown or force close. Note - We don't allocate off fsp as the passed in fsp will get freed once we return EINPROGRESS/NT_STATUS_MORE_PROCESSING_REQUIRED. A new fsp pointer gets allocated on every re-run of the open code path. The destructor allows us to NULL out the saved conn struct pointer when conn is deallocated so we know not to access deallocated memory. This matches the async teardown code changes for bug #14301 in pread/pwrite/fsync vfs_default.c and vfs_glusterfs.c state is still correctly deallocated in all code paths so no memory leaks. This allows us to safely complete when the openat() returns and then return the error NT_STATUS_NETWORK_NAME_DELETED to the client open request. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301 Signed-off-by: Jeremy Allison <jra@samba.org> Reviewed-by: Volker Lendecke <vl@samba.org>
502 lines
13 KiB
C
502 lines
13 KiB
C
/*
|
|
* Simulate Posix AIO using pthreads.
|
|
*
|
|
* Based on the aio_fork work from Volker and Volker's pthreadpool library.
|
|
*
|
|
* Copyright (C) Volker Lendecke 2008
|
|
* Copyright (C) Jeremy Allison 2012
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
|
|
*/
|
|
|
|
#include "includes.h"
|
|
#include "system/filesys.h"
|
|
#include "system/shmem.h"
|
|
#include "smbd/smbd.h"
|
|
#include "smbd/globals.h"
|
|
#include "../lib/pthreadpool/pthreadpool_tevent.h"
|
|
#ifdef HAVE_LINUX_FALLOC_H
|
|
#include <linux/falloc.h>
|
|
#endif
|
|
|
|
#if defined(HAVE_OPENAT) && defined(HAVE_LINUX_THREAD_CREDENTIALS)
|
|
|
|
/*
|
|
* We must have openat() to do any thread-based
|
|
* asynchronous opens. We also must be using
|
|
* thread-specific credentials (Linux-only
|
|
* for now).
|
|
*/
|
|
|
|
struct aio_open_private_data {
|
|
struct aio_open_private_data *prev, *next;
|
|
/* Inputs. */
|
|
int dir_fd;
|
|
int flags;
|
|
mode_t mode;
|
|
uint64_t mid;
|
|
bool in_progress;
|
|
const char *fname;
|
|
char *dname;
|
|
connection_struct *conn;
|
|
struct smbXsrv_connection *xconn;
|
|
const struct security_unix_token *ux_tok;
|
|
uint64_t initial_allocation_size;
|
|
/* Returns. */
|
|
int ret_fd;
|
|
int ret_errno;
|
|
};
|
|
|
|
/* List of outstanding requests we have. */
|
|
static struct aio_open_private_data *open_pd_list;
|
|
|
|
static void aio_open_do(struct aio_open_private_data *opd);
|
|
static void opd_free(struct aio_open_private_data *opd);
|
|
|
|
/************************************************************************
|
|
Find the open private data by mid.
|
|
***********************************************************************/
|
|
|
|
static struct aio_open_private_data *find_open_private_data_by_mid(uint64_t mid)
|
|
{
|
|
struct aio_open_private_data *opd;
|
|
|
|
for (opd = open_pd_list; opd != NULL; opd = opd->next) {
|
|
if (opd->mid == mid) {
|
|
return opd;
|
|
}
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
/************************************************************************
|
|
Callback when an open completes.
|
|
***********************************************************************/
|
|
|
|
static void aio_open_handle_completion(struct tevent_req *subreq)
|
|
{
|
|
struct aio_open_private_data *opd =
|
|
tevent_req_callback_data(subreq,
|
|
struct aio_open_private_data);
|
|
int ret;
|
|
|
|
ret = pthreadpool_tevent_job_recv(subreq);
|
|
TALLOC_FREE(subreq);
|
|
|
|
/*
|
|
* We're no longer in flight. Remove the
|
|
* destructor used to preserve opd so
|
|
* a talloc_free actually removes it.
|
|
*/
|
|
talloc_set_destructor(opd, NULL);
|
|
|
|
if (opd->conn == NULL) {
|
|
/*
|
|
* We were shutdown closed in flight. No one
|
|
* wants the result, and state has been reparented
|
|
* to the NULL context, so just free it so we
|
|
* don't leak memory.
|
|
*/
|
|
DBG_NOTICE("aio open request for %s/%s abandoned in flight\n",
|
|
opd->dname,
|
|
opd->fname);
|
|
if (opd->ret_fd != -1) {
|
|
close(opd->ret_fd);
|
|
opd->ret_fd = -1;
|
|
}
|
|
/*
|
|
* Find outstanding event and reschedule so the client
|
|
* gets an error message return from the open.
|
|
*/
|
|
schedule_deferred_open_message_smb(opd->xconn, opd->mid);
|
|
opd_free(opd);
|
|
return;
|
|
}
|
|
|
|
if (ret != 0) {
|
|
bool ok;
|
|
|
|
if (ret != EAGAIN) {
|
|
smb_panic("aio_open_handle_completion");
|
|
/* notreached. */
|
|
return;
|
|
}
|
|
/*
|
|
* Make sure we run as the user again
|
|
*/
|
|
ok = change_to_user_and_service(opd->conn, opd->conn->vuid);
|
|
if (!ok) {
|
|
smb_panic("Can't change to user");
|
|
return;
|
|
}
|
|
/*
|
|
* If we get EAGAIN from pthreadpool_tevent_job_recv() this
|
|
* means the lower level pthreadpool failed to create a new
|
|
* thread. Fallback to sync processing in that case to allow
|
|
* some progress for the client.
|
|
*/
|
|
aio_open_do(opd);
|
|
}
|
|
|
|
DEBUG(10,("aio_open_handle_completion: mid %llu "
|
|
"for file %s/%s completed\n",
|
|
(unsigned long long)opd->mid,
|
|
opd->dname,
|
|
opd->fname));
|
|
|
|
opd->in_progress = false;
|
|
|
|
/* Find outstanding event and reschedule. */
|
|
if (!schedule_deferred_open_message_smb(opd->xconn, opd->mid)) {
|
|
/*
|
|
* Outstanding event didn't exist or was
|
|
* cancelled. Free up the fd and throw
|
|
* away the result.
|
|
*/
|
|
if (opd->ret_fd != -1) {
|
|
close(opd->ret_fd);
|
|
opd->ret_fd = -1;
|
|
}
|
|
opd_free(opd);
|
|
}
|
|
}
|
|
|
|
/*****************************************************************
|
|
The core of the async open code - the worker function. Note we
|
|
use the new openat() system call to avoid any problems with
|
|
current working directory changes plus we change credentials
|
|
on the thread to prevent any security race conditions.
|
|
*****************************************************************/
|
|
|
|
static void aio_open_worker(void *private_data)
|
|
{
|
|
struct aio_open_private_data *opd =
|
|
(struct aio_open_private_data *)private_data;
|
|
|
|
/* Become the correct credential on this thread. */
|
|
if (set_thread_credentials(opd->ux_tok->uid,
|
|
opd->ux_tok->gid,
|
|
(size_t)opd->ux_tok->ngroups,
|
|
opd->ux_tok->groups) != 0) {
|
|
opd->ret_fd = -1;
|
|
opd->ret_errno = errno;
|
|
return;
|
|
}
|
|
|
|
aio_open_do(opd);
|
|
}
|
|
|
|
static void aio_open_do(struct aio_open_private_data *opd)
|
|
{
|
|
opd->ret_fd = openat(opd->dir_fd,
|
|
opd->fname,
|
|
opd->flags,
|
|
opd->mode);
|
|
|
|
if (opd->ret_fd == -1) {
|
|
opd->ret_errno = errno;
|
|
} else {
|
|
/* Create was successful. */
|
|
opd->ret_errno = 0;
|
|
|
|
#if defined(HAVE_LINUX_FALLOCATE)
|
|
/*
|
|
* See if we can set the initial
|
|
* allocation size. We don't record
|
|
* the return for this as it's an
|
|
* optimization - the upper layer
|
|
* will also do this for us once
|
|
* the open returns.
|
|
*/
|
|
if (opd->initial_allocation_size) {
|
|
(void)fallocate(opd->ret_fd,
|
|
FALLOC_FL_KEEP_SIZE,
|
|
0,
|
|
(off_t)opd->initial_allocation_size);
|
|
}
|
|
#endif
|
|
}
|
|
}
|
|
|
|
/************************************************************************
|
|
Open private data teardown.
|
|
***********************************************************************/
|
|
|
|
static void opd_free(struct aio_open_private_data *opd)
|
|
{
|
|
if (opd->dir_fd != -1) {
|
|
close(opd->dir_fd);
|
|
}
|
|
DLIST_REMOVE(open_pd_list, opd);
|
|
TALLOC_FREE(opd);
|
|
}
|
|
|
|
/************************************************************************
|
|
Create and initialize a private data struct for async open.
|
|
***********************************************************************/
|
|
|
|
static struct aio_open_private_data *create_private_open_data(TALLOC_CTX *ctx,
|
|
const files_struct *fsp,
|
|
int flags,
|
|
mode_t mode)
|
|
{
|
|
struct aio_open_private_data *opd = talloc_zero(ctx,
|
|
struct aio_open_private_data);
|
|
const char *fname = NULL;
|
|
|
|
if (!opd) {
|
|
return NULL;
|
|
}
|
|
|
|
*opd = (struct aio_open_private_data) {
|
|
.dir_fd = -1,
|
|
.ret_fd = -1,
|
|
.ret_errno = EINPROGRESS,
|
|
.flags = flags,
|
|
.mode = mode,
|
|
.mid = fsp->mid,
|
|
.in_progress = true,
|
|
.conn = fsp->conn,
|
|
/*
|
|
* TODO: In future we need a proper algorithm
|
|
* to find the correct connection for a fsp.
|
|
* For now we only have one connection, so this is correct...
|
|
*/
|
|
.xconn = fsp->conn->sconn->client->connections,
|
|
.initial_allocation_size = fsp->initial_allocation_size,
|
|
};
|
|
|
|
/* Copy our current credentials. */
|
|
opd->ux_tok = copy_unix_token(opd, get_current_utok(fsp->conn));
|
|
if (opd->ux_tok == NULL) {
|
|
opd_free(opd);
|
|
return NULL;
|
|
}
|
|
|
|
/*
|
|
* Copy the parent directory name and the
|
|
* relative path within it.
|
|
*/
|
|
if (parent_dirname(opd,
|
|
fsp->fsp_name->base_name,
|
|
&opd->dname,
|
|
&fname) == false) {
|
|
opd_free(opd);
|
|
return NULL;
|
|
}
|
|
opd->fname = talloc_strdup(opd, fname);
|
|
if (opd->fname == NULL) {
|
|
opd_free(opd);
|
|
return NULL;
|
|
}
|
|
|
|
#if defined(O_DIRECTORY)
|
|
opd->dir_fd = open(opd->dname, O_RDONLY|O_DIRECTORY);
|
|
#else
|
|
opd->dir_fd = open(opd->dname, O_RDONLY);
|
|
#endif
|
|
if (opd->dir_fd == -1) {
|
|
opd_free(opd);
|
|
return NULL;
|
|
}
|
|
|
|
DLIST_ADD_END(open_pd_list, opd);
|
|
return opd;
|
|
}
|
|
|
|
static int opd_inflight_destructor(struct aio_open_private_data *opd)
|
|
{
|
|
/*
|
|
* Setting conn to NULL allows us to
|
|
* discover the connection was torn
|
|
* down which kills the fsp that owns
|
|
* opd.
|
|
*/
|
|
DBG_NOTICE("aio open request for %s/%s cancelled\n",
|
|
opd->dname,
|
|
opd->fname);
|
|
opd->conn = NULL;
|
|
/* Don't let opd go away. */
|
|
return -1;
|
|
}
|
|
|
|
/*****************************************************************
|
|
Setup an async open.
|
|
*****************************************************************/
|
|
|
|
static int open_async(const files_struct *fsp,
|
|
int flags,
|
|
mode_t mode)
|
|
{
|
|
struct aio_open_private_data *opd = NULL;
|
|
struct tevent_req *subreq = NULL;
|
|
|
|
/*
|
|
* Allocate off fsp->conn, not NULL or fsp. As we're going
|
|
* async fsp will get talloc_free'd when we return
|
|
* EINPROGRESS/NT_STATUS_MORE_PROCESSING_REQUIRED. A new fsp
|
|
* pointer gets allocated on every re-run of the
|
|
* open code path. Allocating on fsp->conn instead
|
|
* of NULL allows use to get notified via destructor
|
|
* if the conn is force-closed or we shutdown.
|
|
* opd is always safely freed in all codepath so no
|
|
* memory leaks.
|
|
*/
|
|
opd = create_private_open_data(fsp->conn, fsp, flags, mode);
|
|
if (opd == NULL) {
|
|
DEBUG(10, ("open_async: Could not create private data.\n"));
|
|
return -1;
|
|
}
|
|
|
|
subreq = pthreadpool_tevent_job_send(opd,
|
|
fsp->conn->sconn->ev_ctx,
|
|
fsp->conn->sconn->pool,
|
|
aio_open_worker, opd);
|
|
if (subreq == NULL) {
|
|
opd_free(opd);
|
|
return -1;
|
|
}
|
|
tevent_req_set_callback(subreq, aio_open_handle_completion, opd);
|
|
|
|
DEBUG(5,("open_async: mid %llu created for file %s/%s\n",
|
|
(unsigned long long)opd->mid,
|
|
opd->dname,
|
|
opd->fname));
|
|
|
|
/*
|
|
* Add a destructor to protect us from connection
|
|
* teardown whilst the open thread is in flight.
|
|
*/
|
|
talloc_set_destructor(opd, opd_inflight_destructor);
|
|
|
|
/* Cause the calling code to reschedule us. */
|
|
errno = EINPROGRESS; /* Maps to NT_STATUS_MORE_PROCESSING_REQUIRED. */
|
|
return -1;
|
|
}
|
|
|
|
/*****************************************************************
|
|
Look for a matching SMB2 mid. If we find it we're rescheduled,
|
|
just return the completed open.
|
|
*****************************************************************/
|
|
|
|
static bool find_completed_open(files_struct *fsp,
|
|
int *p_fd,
|
|
int *p_errno)
|
|
{
|
|
struct aio_open_private_data *opd;
|
|
|
|
opd = find_open_private_data_by_mid(fsp->mid);
|
|
if (!opd) {
|
|
return false;
|
|
}
|
|
|
|
if (opd->in_progress) {
|
|
DEBUG(0,("find_completed_open: mid %llu "
|
|
"still in progress for "
|
|
"file %s/%s. PANIC !\n",
|
|
(unsigned long long)opd->mid,
|
|
opd->dname,
|
|
opd->fname));
|
|
/* Disaster ! This is an open timeout. Just panic. */
|
|
smb_panic("find_completed_open - in_progress\n");
|
|
/* notreached. */
|
|
return false;
|
|
}
|
|
|
|
*p_fd = opd->ret_fd;
|
|
*p_errno = opd->ret_errno;
|
|
|
|
DEBUG(5,("find_completed_open: mid %llu returning "
|
|
"fd = %d, errno = %d (%s) "
|
|
"for file %s\n",
|
|
(unsigned long long)opd->mid,
|
|
opd->ret_fd,
|
|
opd->ret_errno,
|
|
strerror(opd->ret_errno),
|
|
smb_fname_str_dbg(fsp->fsp_name)));
|
|
|
|
/* Now we can free the opd. */
|
|
opd_free(opd);
|
|
return true;
|
|
}
|
|
|
|
/*****************************************************************
|
|
The core open function. Only go async on O_CREAT|O_EXCL
|
|
opens to prevent any race conditions.
|
|
*****************************************************************/
|
|
|
|
static int aio_pthread_open_fn(vfs_handle_struct *handle,
|
|
struct smb_filename *smb_fname,
|
|
files_struct *fsp,
|
|
int flags,
|
|
mode_t mode)
|
|
{
|
|
int my_errno = 0;
|
|
int fd = -1;
|
|
bool aio_allow_open = lp_parm_bool(
|
|
SNUM(handle->conn), "aio_pthread", "aio open", false);
|
|
|
|
if (smb_fname->stream_name) {
|
|
/* Don't handle stream opens. */
|
|
errno = ENOENT;
|
|
return -1;
|
|
}
|
|
|
|
if (!aio_allow_open) {
|
|
/* aio opens turned off. */
|
|
return open(smb_fname->base_name, flags, mode);
|
|
}
|
|
|
|
if (!(flags & O_CREAT)) {
|
|
/* Only creates matter. */
|
|
return open(smb_fname->base_name, flags, mode);
|
|
}
|
|
|
|
if (!(flags & O_EXCL)) {
|
|
/* Only creates with O_EXCL matter. */
|
|
return open(smb_fname->base_name, flags, mode);
|
|
}
|
|
|
|
/*
|
|
* See if this is a reentrant call - i.e. is this a
|
|
* restart of an existing open that just completed.
|
|
*/
|
|
|
|
if (find_completed_open(fsp,
|
|
&fd,
|
|
&my_errno)) {
|
|
errno = my_errno;
|
|
return fd;
|
|
}
|
|
|
|
/* Ok, it's a create exclusive call - pass it to a thread helper. */
|
|
return open_async(fsp, flags, mode);
|
|
}
|
|
#endif
|
|
|
|
static struct vfs_fn_pointers vfs_aio_pthread_fns = {
|
|
#if defined(HAVE_OPENAT) && defined(HAVE_LINUX_THREAD_CREDENTIALS)
|
|
.open_fn = aio_pthread_open_fn,
|
|
#endif
|
|
};
|
|
|
|
static_decl_vfs;
|
|
NTSTATUS vfs_aio_pthread_init(TALLOC_CTX *ctx)
|
|
{
|
|
return smb_register_vfs(SMB_VFS_INTERFACE_VERSION,
|
|
"aio_pthread", &vfs_aio_pthread_fns);
|
|
}
|