Jonathon Reinhart a4ed6ada50 Remove unnecessary/incorrect talloc_steal() calls ...

The talloc_steal() in dsdb_enum_group_mem() is unnecessary, because
members was already allocated from the same mem_ctx.

The talloc_steal() in pdb_samba_dsdb_enum_aliasmem() is also unnecessary
for the same reason, but also incorrect, because it should be
dereferencing pmembers:

    talloc_steal(mem_ctx, *pmembers);

Furthermore, we should only assign to *pnum_members on success; otherwise
num_members is used uninitialized.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14264

Signed-off-by: Jonathon Reinhart <Jonathon.Reinhart@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Mar  5 18:40:16 UTC 2020 on sn-devel-184

2020-03-05 18:40:16 +00:00

..

ABI

passdb: Increase ABI version to 0.28.0

2019-03-07 01:30:49 +00:00

account_pol.c

source3: Update all consumers of strtoul_err(), strtoull_err() to new API

2019-06-30 11:32:18 +00:00

login_cache.c

lib: Pass mem_ctx to cache_path()

2018-08-17 14:28:51 +02:00

lookup_sid.c

s3/passdb: clang: Fix 'Value stored during its initialization is never read'

2019-09-26 18:41:27 +00:00

lookup_sid.h

passdb: Introduce xid_to_sid

2019-02-28 12:57:24 +00:00

machine_account_secrets.c

krb5_wrap: move source3/libads/krb5_errs.c to lib/krb5_wrap/krb5_errs.c

2020-02-10 16:32:37 +00:00

machine_sid.c

passdb: Use struct allocation

2020-01-30 12:27:40 +00:00

machine_sid.h

s3: rename sid_check_is_in_our_domain() to sid_check_is_in_our_sam()

2012-07-12 18:36:02 +02:00

passdb.c

s3/passed: clang: Fix 'Value stored during its initialization is never read'

2019-09-26 18:41:27 +00:00

pdb_compat.c

passdb: Use dom_sid_str_buf

2018-12-20 23:40:24 +01:00

pdb_get_set.c

passdb: Use dom_sid_str_buf

2018-12-20 23:40:24 +01:00

pdb_interface.c

smbdotconf: mark "delete user script" with substitution="1"

2019-11-27 10:25:34 +00:00

pdb_ldap_schema.c

s3-passdb: Remove obsolte ldapsam_compat support.

2012-07-03 21:56:49 +02:00

pdb_ldap_schema.h

s3-passdb: Remove obsolte ldapsam_compat support.

2012-07-03 21:56:49 +02:00

pdb_ldap_util.c

smbdotconf: mark "ldap suffix" with constant="1"

2019-11-27 10:25:36 +00:00

pdb_ldap_util.h

s3: move smbldap_util to pdb_ldap_util.

2011-11-16 12:26:26 +01:00

pdb_ldap.c

smbdotconf: mark "ldap suffix" with constant="1"

2019-11-27 10:25:36 +00:00

pdb_ldap.h

lib: modules: Change XXX_init interface from XXX_init(void) to XXX_init(TALLOC_CTX *)

2017-04-22 01:17:00 +02:00

pdb_nds.c

s3:passdb: Use generate_secret_buffer() for generating passwords

2019-08-14 15:07:24 +00:00

pdb_nds.h

lib: modules: Change XXX_init interface from XXX_init(void) to XXX_init(TALLOC_CTX *)

2017-04-22 01:17:00 +02:00

pdb_samba_dsdb.c

Remove unnecessary/incorrect talloc_steal() calls

2020-03-05 18:40:16 +00:00

pdb_secrets.c

passdb: Use dom_sid_str_buf

2018-12-20 23:40:24 +01:00

pdb_secrets.h

Convert all uses of uint32/16/8 to _t in source3/passdb.

2015-05-12 01:32:12 +02:00

pdb_smbpasswd.c

smbdotconf: mark "rename user script" with substitution="1"

2019-11-27 10:25:36 +00:00

pdb_smbpasswd.h

lib: modules: Change XXX_init interface from XXX_init(void) to XXX_init(TALLOC_CTX *)

2017-04-22 01:17:00 +02:00

pdb_tdb.c

smbdotconf: mark "rename user script" with substitution="1"

2019-11-27 10:25:36 +00:00

pdb_tdb.h

lib: modules: Change XXX_init interface from XXX_init(void) to XXX_init(TALLOC_CTX *)

2017-04-22 01:17:00 +02:00

pdb_util.c

s3/passdb: clang: Fix 'Value stored during its initialization is never read'

2019-09-26 18:41:26 +00:00

py_passdb.c

py3: Remove PyStr_AsString() compatability macro

2019-06-24 17:24:27 +00:00

secrets_lsa.c

s3:secrets: rename secrets_delete() to secrets_delete_entry()

2017-06-27 16:57:45 +02:00

secrets.c

smbdotconf: mark "ldap admin dn" with constant="1"

2019-11-27 10:25:36 +00:00

wscript_build

smbdes: add des_crypt56_gnutls() using DES-CBC with zeroed IV

2019-12-10 00:30:30 +00:00