1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-24 21:34:56 +03:00
samba-mirror/selftest
Tim Beale 7a410ccb5f netcmd: Fix passwordsettings --max-pwd-age command
The min_pwd_age and max_pwd_age parameters are both optional and default
to None. However, if we just set the max-pwd-age, then the check
'min_pwd_age >= max_pwd_age' will throw a Python exception because it's
trying to compare an int to NoneType (min_pwd_age). This works on Python 2
but is a problem on Python 3.

We could just add a check that min_pwd_age is not None, but that defeats
the point of having the check if you're only setting either the min or
max age indepedently.

This patch gets the current min/max password age from the DB (in ticks).
If either setting is changed, the ticks will be updated. Then at the end
we check the min is still less than the max (to do this, we convert the
ticks back to days in the interests of readability).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13873

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Apr  5 08:03:08 UTC 2019 on sn-devel-144
2019-04-05 08:03:08 +00:00
..
flapping.d flapping tests: Add samba3.smb2.notify 2019-04-04 06:40:16 +00:00
gnupg selftest:gnupg: add a gpg key for Samba Selftest <selftest@samba.example.com> 2016-07-22 16:03:27 +02:00
knownfail.d netcmd: Fix passwordsettings --max-pwd-age command 2019-04-05 08:03:08 +00:00
manage-ca selftest/manage-ca: update manage-CA-samba.example.com.sh 2016-07-22 23:34:21 +02:00
target selftest: use test smb.conf in provision 2019-03-30 22:21:26 +00:00
checkpassword_arg1.sh selftest: require SAMBA_CPS_ACCOUNT_NAME in checkpassword_arg1.sh 2019-02-11 07:43:32 +01:00
devel_env.sh
filter-subunit selftest/filter-subunit: use py3 print 2019-03-12 00:42:18 +00:00
flapping source4 rpc: binding.c enable DCERPC_SCHANNEL_AUTO for schannel connections 2017-05-25 02:25:13 +02:00
format-subunit PY3: change shebang to python3 in misc dirs 2018-12-14 18:00:40 +01:00
format-subunit-json selftest/format-subunit-json: remove useless py2 print 2019-03-12 00:42:18 +00:00
gdb_backtrace selftest/gdb_*: make use of 'mktemp' 2016-12-01 05:54:21 +01:00
gdb_backtrace_test.c
gdb_run selftest/gdb_*: make use of 'mktemp' 2016-12-01 05:54:21 +01:00
in_screen selftest: Give tmux a bit of time to establish 2017-06-21 03:14:17 +02:00
knownfail s3:smbd: fix max_buffer handling of initial notify requests 2019-03-29 00:35:39 +00:00
no-python-tests.txt selftest: Add basic sanity-check tests for nopython target 2019-02-20 02:10:00 +01:00
perf_tests.py perf-tests: rename paged search test for regex disambiguation 2019-04-05 04:41:25 +00:00
quick
README Remove documentation for testsuite-count subunit extension, which is no longer used. 2015-02-17 15:41:10 +01:00
save.env.sh selftest: add save.env.sh helper script. 2016-06-27 05:00:15 +02:00
selftest.pl selftest: Restore IPs 12-16 for selftest client 2019-03-27 13:31:27 +00:00
selftest.pl.1
selftesthelpers.py selftest: Add smbstatus to testhelper 2019-03-27 13:31:27 +00:00
skip s4:selftest: make use of ad_dc_default 2019-02-27 10:16:10 +00:00
skip_mit_kdc prefork tests: disable restart tests MIT 2019-04-03 01:40:22 +00:00
skip.no-GSS_KRB5_CRED_NO_CI_FLAGS_X script/autobuild.py: try make test TESTS=samba3.*ktest for samba-systemkrb5 2017-01-10 13:54:17 +01:00
slow
SocketWrapper.pm
Subunit.pm selftest: consistently produce high-res UTC time 2018-03-22 13:26:44 +01:00
subunithelper.py PY3: Only decode when necessary 2018-10-23 05:50:25 +02:00
tap2subunit Add basic tap2subunit converter, rather than relying on the one from subunit-tools. 2015-03-06 04:41:47 +01:00
tests.py lib:util: Add test for talloc_keep_secret() 2019-04-03 06:48:21 +00:00
TODO
valgrind_run
wscript selftest: Remove support for running multiple tests against python versions in a single run 2019-03-21 04:06:15 +00:00

# vim: ft=rst

This directory contains test scripts that are useful for running a
bunch of tests all at once.

There are two parts to this:

 * The test runner (selftest/selftest.pl)
 * The test formatter

selftest.pl simply outputs subunit, which can then be formatted or analyzed
by tools that understand the subunit protocol. One of these tools is
format-subunit, which is used by default as part of "make test".

Available testsuites
====================
The available testsuites are obtained from a script, usually
source{3,4}/selftest/tests.py. This script should for each testsuite output
the name of the test, the command to run and the environment that should be
provided. Use the included "plantest" function to generate the required output.

Testsuite behaviour
===================

Exit code
------------
The testsuites should exit with a non-zero exit code if at least one
test failed. Skipped tests should not influence the exit code.

Output format
-------------
Testsuites can simply use the exit code to indicate whether all of their
tests have succeeded or one or more have failed. It is also possible to
provide more granular information using the Subunit protocol.

This protocol works by writing simple messages to standard output. Any
messages that can not be interpreted by this protocol are considered comments
for the last announced test.

For a full description of the subunit protocol, see the README file in the subunit
repository at http://github.com/testing-cabal/subunit.

The following commands are Samba extensions to Subunit:

start-testsuite
~~~~~~~~~~~~~~~
start-testsuite: name

The testsuite name is used as prefix for all containing tests.

skip-testsuite
~~~~~~~~~~~~~~
skip-testsuite: name

Mark the testsuite with the specified name as skipped.

testsuite-success
~~~~~~~~~~~~~~~~~
testsuite-success: name

Indicate that the testsuite has succeeded successfully.

testsuite-fail
~~~~~~~~~~~~~~
testsuite-fail: name

Indicate that a testsuite has failed.

Environments
============
Tests often need to run against a server with particular things set up,
a "environment". This environment is provided by the test "target": Samba 3,
Samba 4 or Windows.

The environments are currently available include

 - none: No server set up, no variables set.
 - dc,s3dc: Domain controller set up. The following environment variables will
   be set:

     * USERNAME: Administrator user name
     * PASSWORD: Administrator password
     * DOMAIN: Domain name
     * REALM: Realm name
     * SERVER: DC host name
     * SERVER_IP: DC IPv4 address
     * SERVER_IPV6: DC IPv6 address
     * NETBIOSNAME: DC NetBIOS name
     * NETIOSALIAS: DC NetBIOS alias

 - member,s4member,s3member: Domain controller and member server that is joined to it set up. The
   following environment variables will be set:

     * USERNAME: Domain administrator user name
     * PASSWORD: Domain administrator password
     * DOMAIN: Domain name
     * REALM: Realm name
     * SERVER: Name of the member server

See Samba.pm, Samba3.pm and Samba4.pm for the full list.

Running tests
=============

To run all the tests use::

   make test

To run a quicker subset run::

   make quicktest

To run a specific test, use this syntax::

   make test TESTS=testname

for example::

   make test TESTS=samba4.BASE-DELETE