1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-22 13:34:15 +03:00
samba-mirror/source3
Martin Schwenke 6784ff24b8 ctdbd_conn: Generalise inaccurate error message
Seeing:

  ctdb_read_packet failed: Cannot allocate memory
  [...,  0] ../source3/lib/ctdbd_conn.c:121(cluster_fatal)
  cluster fatal event: ctdbd died

The error is due to a memory allocation failure rather than ctdbd
dying.  However, the error message makes people wonder why ctdbd died.

Another alternative would be to wrap cluster_fatal() and have the
wrapper interpret the return value from ctdb_read_packet() to choose
from a set of more precise messages to pass to cluster_fatal().  For a
memory allocation it isn't strictly necessary to call cluster_fatal(),
but all is probably lost and it is still probably better to try to
exit cleanly as soon as possible instead of crashing somewhere.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Oct  5 16:16:29 CEST 2018 on sn-devel-144
2018-10-05 16:16:29 +02:00
..
auth s3: Rename server_messaging_context() to global_messaging_context() 2018-09-07 17:26:17 +02:00
build source3/build/charset.py: update to handle waf 2.0.4 2018-09-05 06:37:23 +02:00
client s3:lib: Move popt_common_credentials to separate file 2018-09-07 17:26:14 +02:00
exports
groupdb lib: Pass mem_ctx to state_path() 2018-08-17 11:30:11 +02:00
include lib: Remove unused tdb_pack_append() 2018-10-03 01:07:15 +02:00
intl lib: Pass mem_ctx to lock_path() 2018-08-17 11:30:10 +02:00
lib ctdbd_conn: Generalise inaccurate error message 2018-10-05 16:16:29 +02:00
libads libads: Simplify parse_spn() 2018-08-22 03:59:51 +02:00
libgpo/gpext libgpo: Fix CID 1438462 Error handling issues (CHECKED_RETURN) 2018-08-22 00:58:41 +02:00
libnet s3:libads: Add net ads leave keep-account option 2018-07-30 07:34:11 +02:00
librpc smbd: Remove "share_mode_entry->lease" 2018-07-27 01:42:31 +02:00
libsmb libsmb: Remove smb_share_modes.[ch] 2018-10-02 10:40:05 +02:00
locale pam_winbind: initial Turkish translation 2017-11-15 13:52:05 +01:00
locking leases: Streamline leases_db_key a bit 2018-10-03 04:11:59 +02:00
modules vfs_gpfs: Check for GPFS file system on connect 2018-09-19 00:54:23 +02:00
nmbd s3: nmbd: Stop nmbd network announce storm. 2018-09-19 22:25:05 +02:00
param s3:loadparm: reinit_globals in lp_load_with_registry_shares() 2018-09-07 17:26:14 +02:00
passdb Fix pdb_samba_dsdb build on Ubuntu 16.04 with -O3 -Werror=strict-overflow 2018-09-20 01:29:47 +02:00
printing s3: Rename server_messaging_context() to global_messaging_context() 2018-09-07 17:26:17 +02:00
profile lib: Pass mem_ctx to cache_path() 2018-08-17 14:28:51 +02:00
registry lib: Pass mem_ctx to state_path() 2018-08-17 11:30:11 +02:00
rpc_client s3-rpc_client: Advertise Windows 7 client info 2018-09-08 01:43:27 +02:00
rpc_server mdssvc: Move a variable declaration closer to its use 2018-09-14 10:48:47 +02:00
rpcclient s3-rpcclient: Use spoolss_init_spoolss_UserLevel1 in winspool cmds 2018-09-08 01:43:27 +02:00
script PEP8: fix E128: continuation line under-indented for visual indent 2018-09-06 15:50:17 +02:00
selftest PEP8: fix E127: continuation line over-indented for visual indent 2018-09-06 12:10:12 +02:00
services srcctl3: Improve debug messages 2018-01-16 02:43:03 +01:00
smbd smbd: Simplify downgrade_share_lease 2018-10-02 22:22:37 +02:00
torture s3: Rename server_messaging_context() to global_messaging_context() 2018-09-07 17:26:17 +02:00
utils s3: Fix the build when compiling without JSON support 2018-09-24 07:03:09 +02:00
web
winbindd s3: Rename server_messaging_context() to global_messaging_context() 2018-09-07 17:26:17 +02:00
.clang_complete
.dmallocrc
.indent.pro
Doxyfile
mainpage.dox
smbadduser.in
wscript s3/wscript: fix flex detection 2018-09-07 11:37:23 +02:00
wscript_build s3:lib: Rename server_contexts to global_contexts 2018-09-07 17:26:17 +02:00
wscript_configure_system_ncurses source3/wscript_configure_system_ncurses: update to handle waf 2.0.4 2018-09-05 06:37:24 +02:00