1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-06 13:18:07 +03:00
samba-mirror/source4/dsdb/common
Jonathon Reinhart a4ed6ada50 Remove unnecessary/incorrect talloc_steal() calls
The talloc_steal() in dsdb_enum_group_mem() is unnecessary, because
members was already allocated from the same mem_ctx.

The talloc_steal() in pdb_samba_dsdb_enum_aliasmem() is also unnecessary
for the same reason, but also incorrect, because it should be
dereferencing pmembers:

    talloc_steal(mem_ctx, *pmembers);

Furthermore, we should only assign to *pnum_members on success; otherwise
num_members is used uninitialized.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14264

Signed-off-by: Jonathon Reinhart <Jonathon.Reinhart@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Mar  5 18:40:16 UTC 2020 on sn-devel-184
2020-03-05 18:40:16 +00:00
..
tests ldb: cmocka test for empty attributes bug 2019-03-29 17:29:31 +00:00
dsdb_access.c dsdb: remove a wrong comment in dsdb_check_access_on_dn_internal() 2013-06-13 18:19:24 +02:00
dsdb_dn.c source4: Update all consumers of strtoul_err(), strtoull_err() to new API 2019-06-30 11:32:18 +00:00
dsdb_dn.h dsdb: Define syntax access point oid string as a macro 2014-12-22 00:18:09 +01:00
util_groups.c Remove a number of NT_STATUS_HAVE_NO_MEMORY_AND_FREE macros from the codebase. 2014-03-05 16:33:21 +01:00
util_links.c dsdb:util_links: count el->values with unsigned int 2019-03-04 21:41:17 +00:00
util_links.h dsdb: make get_parsed_dns_trusted() a common helper function 2019-02-13 04:15:14 +01:00
util_samr.c Remove unnecessary/incorrect talloc_steal() calls 2020-03-05 18:40:16 +00:00
util_trusts.c s4/dsdb/common: clang: Fix access results in null pointer deref. 2019-07-11 04:08:13 +00:00
util.c dsdb: Use write_data() to write to the password check script 2020-01-19 18:29:39 +00:00
util.h util: Remove unused NS_GUID_string() and NS_GUID_from_string() 2019-09-01 23:55:38 +00:00