Jeremy Allison a970d45d17 s3: libsmbclient: Fix cli_splice() fallback when reading less than a complete file. ...

We were always asking for SPLICE_BLOCK_SIZE even when the
remaining bytes we wanted were smaller than that. This works
when using cli_splice() on a complete file, as the cli_read()
terminated the read at the right place. We always have the
space to read SPLICE_BLOCK_SIZE bytes so this isn't an overflow.

Found by Bailey Berro <baileyberro@google.com>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13527

Signed-off-by: Bailey Berro <baileyberro@google.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Jul 13 14:57:14 CEST 2018 on sn-devel-144

(cherry picked from commit c9656fd2977557ab20ec4e3d87c385a9b2f1bf43)

2018-08-13 12:56:35 +02:00

..

ABI

Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

2017-12-10 04:56:23 +01:00

async_smb.c

s3: libsmb: Add uint16_t addtional_flags2 to cli_smb_req_create().

2016-08-19 20:03:12 +02:00

auth_generic.c

s3:auth_generic: add "ntlmssp_resume_ccache" backend in auth_generic_client_prepare()

2016-03-10 06:52:28 +01:00

cli_smb2_fnum.c

libsmb: Handle IO_TIMEOUT in cli_smb2_notify properly

2018-04-19 11:40:11 +02:00

cli_smb2_fnum.h

s3: libsmb: Add SMB2 calls cli_smb2_get_reparse_point_fnum_send()/cli_smb2_get_reparse_point_fnum_recv().

2017-12-06 15:02:16 +01:00

cliconnect.c

s3:cliconnect.c: remove useless ';'

2018-02-27 16:00:13 +01:00

clidfs.c

CVE-2017-12150: s3:libsmb: only fallback to anonymous if authentication was not requested

2017-09-20 13:04:10 +02:00

clidgram.c

Convert all uint32/16/8 to _t in source3/libsmb.

2015-05-13 19:11:23 +02:00

clidgram.h

Fix bug #8953 - winbind can hang as nbt_getdc() has no timeout.

2012-05-22 16:25:14 -07:00

clientgen.c

libsmb: Use smb2 tcon if conn_protocol >= SMB2_02

2018-03-07 15:15:22 +01:00

clierror.c

Convert all uint32/16/8 to _t in source3/libsmb.

2015-05-13 19:11:23 +02:00

clifile.c

s3: libsmb: Make cli_close_send()/cli_close_recv() work for SMB1 and SMB2.

2017-12-06 15:02:16 +01:00

clifsinfo.c

s3: smbclient: Implement "volume" command over SMB2.

2017-11-15 15:56:24 +01:00

clilist.c

s3: libsmb: Add return args to clistr_is_previous_version_path().

2016-08-22 19:10:22 +02:00

climessage.c

s3: libsmb: Add uint16_t additional_flags2 arg to cli_smb_send().

2016-08-19 20:03:11 +02:00

clioplock.c

s3: libsmb: Add uint16_t additional_flags2 arg to cli_smb_send().

2016-08-19 20:03:11 +02:00

cliprint.c

s3:libsmb: get rid of cli_state_server_time_zone

2012-05-28 14:49:48 +02:00

cliquota.c

cliquota: support setting file system quota via SMB2

2016-10-04 02:00:23 +02:00

clirap2.c

s3:libsmb/clirap: remove unused cli_get_server_*() functions

2016-07-06 22:41:41 +02:00

clirap.c

s3: libsmb: Add cli_smb2_setpathinfo(), to be called by cli_setpathinfo_basic().

2017-07-25 17:43:15 +02:00

clirap.h

s3:libsmb/clirap: remove unused cli_get_server_*() functions

2016-07-06 22:41:41 +02:00

clireadwrite.c

s3: libsmbclient: Fix cli_splice() fallback when reading less than a complete file.

2018-08-13 12:56:35 +02:00

clisecdesc.c

Convert all uint32/16/8 to _t in source3/libsmb.

2015-05-13 19:11:23 +02:00

clispnego.c

s3:libsmb: remove unused functions in clispnego.c

2016-03-10 06:52:30 +01:00

clistr.c

s3: libsmb: Add return args to clistr_is_previous_version_path().

2016-08-22 19:10:22 +02:00

clisymlink.c

s3: libsmb: Plumb in the new SMB2 get reparse point calls into the cli_readlink_XXXX() calls.

2017-12-06 19:05:34 +01:00

clitrans.c

s3: libsmb: Add uint16_t addtional_flags2 to cli_trans_send().

2016-08-19 20:03:12 +02:00

conncache.c

lib: Use "mem_ctx" arg in gencache_get

2013-09-05 20:09:21 +02:00

dsgetdcname.c

lib: Pass blob instead of &blob to gencache_set_data_blob

2017-11-29 16:59:16 +01:00

errormap_wbc.c

…

errormap_wbc.h

…

errormap.c

Change all uses of uint32/16/8 in proto.h to uint32_t/16_t/8_t.

2015-04-29 23:42:20 +02:00

libsmb_cache.c

Fix some blank line endings

2013-06-21 19:57:06 +02:00

libsmb_compat.c

libsmb: Implement smbc_notify

2015-07-10 09:35:13 +02:00

libsmb_context.c

CVE-2017-12151: s3:libsmb: make use of cli_state_is_encryption_on()

2017-09-20 13:04:10 +02:00

libsmb_dir.c

s3:libsmb: don't call cli_NetServerEnum() on SMB2/3 connections in SMBC_opendir_ctx()

2017-08-19 01:41:24 +02:00

libsmb_file.c

libsmbclient: Initialize written value before use.

2018-07-12 13:10:26 +02:00

libsmb_misc.c

Convert all uint32/16/8 to _t in source3/libsmb.

2015-05-13 19:11:23 +02:00

libsmb_path.c

Fix some blank line endings

2013-06-21 19:57:06 +02:00

libsmb_printjob.c

libsmb: Fix CID 1034606 Incorrect pointer comparison

2015-09-09 21:33:49 +02:00

libsmb_server.c

s3: libsmbclient: Fix hard-coded connection error return of ETIMEDOUT.

2018-05-07 14:25:28 +02:00

libsmb_setget.c

Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

2017-12-10 04:56:23 +01:00

libsmb_stat.c

Convert all uint32/16/8 to _t in source3/libsmb.

2015-05-13 19:11:23 +02:00

libsmb_thread_impl.c

…

libsmb_thread_posix.c

…

libsmb_xattr.c

libsmb: Use fstr_sprint in convert_sid_to_string

2015-06-26 22:35:02 +02:00

libsmb.h

s3:libsmb: Add in the core of the libsmb client SMB2 functions.

2013-08-15 09:07:06 +02:00

namecache.c

namecache: fix uninitialised pointer returns

2014-09-13 03:21:39 +02:00

namequery_dc.c

s3-kerberos: remove unused kdc_name from create_local_private_krb5_conf_for_domain().

2014-03-07 18:43:57 +01:00

namequery.c

Use talloc_stackframe() not talloc_tos() in namequery.c

2017-11-20 21:41:15 +01:00

nmblib.c

Convert all uint32/16/8 to _t in source3/libsmb.

2015-05-13 19:11:23 +02:00

nmblib.h

…

passchange.c

s3:libsmb: Pass domain to remote_password_change()

2017-08-23 13:16:20 +02:00

proto.h

s3: libsmb: Rename cli_close_create() -> cli_smb1_close_create().

2017-12-06 15:02:16 +01:00

pylibsmb.c

CVE-2017-12150: s3:pylibsmb: make use of SMB_SIGNING_DEFAULT for 'samba.samba3.libsmb_samba_internal'

2017-09-20 13:04:10 +02:00

reparse_symlink.c

…

samlogon_cache.c

netsamlogon_cache: Use ndr_pull_struct_blob_all

2017-11-13 23:54:46 +01:00

samlogon_cache.h

samlogon_cache: add netsamlog_cache_for_all()

2017-07-03 19:59:09 +02:00

smb_share_modes.c

Convert all uint32/16/8 to _t in source3/libsmb.

2015-05-13 19:11:23 +02:00

smbclient.pc.in

…

smberr.c

Change all uses of uint32/16/8 in proto.h to uint32_t/16_t/8_t.

2015-04-29 23:42:20 +02:00

smbsock_connect.c

s3:libsmb: remove pending requests as early as possible via a smbsock_any_connect_cleanup() hook

2015-06-12 17:08:17 +02:00

trustdom_cache.c

libsmb: Slightly simplify trustdom_cache_fetch

2017-03-14 15:22:12 +01:00

trusts_util.c

netlogon_creds_cli: Protect netlogon_creds_cli_auth by _lck

2017-09-25 09:43:13 +02:00

unexpected.c

source3/libsmb/unexpected.c set socket close on exec

2017-12-18 04:38:20 +01:00

wscript

Added smbc_SetLogCallback which lets third party code to capture libsmbclient logs

2017-12-10 04:56:23 +01:00