samba-mirror

mirror of https://github.com/samba-team/samba.git synced 2025-01-18 06:04:06 +03:00

History

Martin Schwenke 0d8084ed62 ctdb-protocol: CID 1499395: Uninitialized variables (UNINIT)

Issue is reported here:

853     	case CTDB_CONTROL_DB_VACUUM: {
854     		struct ctdb_db_vacuum db_vacuum;
855
>>>     CID 1499395:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "db_vacuum.full_vacuum_run" when calling "ctdb_db_vacuum_len".
856     		CHECK_CONTROL_DATA_SIZE(ctdb_db_vacuum_len(&db_vacuum));
857     		return ctdb_control_db_vacuum(ctdb, c, indata, async_reply);
858     	}

The problem is that ctdb_bool_len() unnecessarily dereferences its
argument, which in this case is &db_vacuum.full_vacuum_run.  Not a
security issue because the value copied by dereferencing is not used.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>

Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Feb 23 02:02:06 UTC 2022 on sn-devel-184

2022-02-23 02:02:06 +00:00

protocol_api.h

ctdb-protocol: Drop protocol client functions for recmaster controls

2022-01-17 10:21:33 +00:00

protocol_basic.c

ctdb-protocol: CID 1499395: Uninitialized variables (UNINIT)

2022-02-23 02:02:06 +00:00

protocol_basic.h

ctdb-protocol: Separate protocol-basic subsystem

2018-07-05 06:52:42 +02:00

protocol_call.c

ctdb-protocol: Fix marshalling for ctdb_reply_dmaster