1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-10 01:18:15 +03:00
samba-mirror/source3/rpc_server/samr
Andreas Schneider a0b6d18a25 s3:rpc_server: Make sure struct security_ace is initialized
Found by Covscan.

"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source3/rpc_server/samr/srv_samr_nt.c:235: var_decl: Declaring variable ""ace"" without initializer.
samba-4.20.0rc2/source3/rpc_server/samr/srv_samr_nt.c:269: uninit_use_in_call: Using uninitialized value ""*ace"". Field ""ace->object"" is uninitialized when calling ""make_sec_acl"".
  267|   	/* create the security descriptor */
  268|
  269|-> 	if ((psa = make_sec_acl(ctx, NT4_ACL_REVISION, i, ace)) == NULL)
  270|   		return NT_STATUS_NO_MEMORY;
  271|"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
2024-06-24 06:14:35 +00:00
..
srv_samr_chgpasswd.c samr_server: Avoid a DEBUGADD() 2024-01-23 23:28:31 +00:00
srv_samr_nt.c s3:rpc_server: Make sure struct security_ace is initialized 2024-06-24 06:14:35 +00:00
srv_samr_util.c s3:rpc_server: Implement SAMR SetUserInfo(2) level 32 2022-07-28 11:51:29 +00:00
srv_samr_util.h CVE-2021-20251 s3:rpc_server: Split change_oem_password() call out of samr_set_password_aes() 2022-09-12 23:07:38 +00:00