samba-mirror

mirror of https://github.com/samba-team/samba.git synced 2024-12-23 17:34:34 +03:00

https://gitlab.com/samba-team/samba is the Official GitLab mirror of https://git.samba.org/samba.git -- Merge requests should be made on GitLab (not on GitHub)

samba

Go to file

Ronnie Sahlberg aea0a724d8 In ctdb_control_end_recovery, We used to talloc_steal c (the command packet) and make it a child of the "event script state context". If we failed to create a eventscript child context for some reason, this would have talloc freed state, but at the same time it would also implicitely have freed c. Once ctdb_control_end_recovery() returns the error back to the caller, the caller would dereference both c, and also outdata which is a child of c and we would either read garbage data or segv. Change the ordering so we only talloc_steal c as a child of state IFF we have successfully created a child context for the script. BZ61068 (This used to be ctdb commit 259054c3632e42bbaa614ee7e888e6e850733d60)	2010-02-23 12:50:32 +11:00
ctdb	In ctdb_control_end_recovery,	2010-02-23 12:50:32 +11:00

Ronnie Sahlberg aea0a724d8 In ctdb_control_end_recovery,

We used to talloc_steal c (the command packet) and make it a child of the
"event script state context".
If we failed to create a eventscript child context for some reason,
this would have talloc freed state, but at the same time it would also
implicitely have freed c.
Once ctdb_control_end_recovery() returns the error back to the caller,
the caller would dereference both c, and also outdata which is a child of c
and we would either read garbage data or segv.

Change the ordering so we only talloc_steal c as a child of state IFF
we have successfully created a child context for the script.

BZ61068

(This used to be ctdb commit 259054c3632e42bbaa614ee7e888e6e850733d60)

2010-02-23 12:50:32 +11:00

ctdb

In ctdb_control_end_recovery,

2010-02-23 12:50:32 +11:00