1
0
mirror of https://github.com/samba-team/samba.git synced 2025-01-11 05:18:09 +03:00
samba-mirror/lib/ntdb/traverse.c
Rusty Russell b888bc4316 ntdb: optimize ntdb_fetch.
We access the key on lookup, then access the data in the caller.  It
makes more sense to access both at once.  We also put in a likely()
for the case where the hash is not chained.

Before:
Adding 1000 records: 3644-3724(3675) ns (129656 bytes)
Finding 1000 records: 1596-1696(1622) ns (129656 bytes)
Missing 1000 records: 1409-1525(1452) ns (129656 bytes)
Traversing 1000 records: 1636-1747(1668) ns (129656 bytes)
Deleting 1000 records: 3138-3223(3175) ns (129656 bytes)
Re-adding 1000 records: 3278-3414(3329) ns (129656 bytes)
Appending 1000 records: 5396-5529(5426) ns (253312 bytes)
Churning 1000 records: 9451-10095(9584) ns (253312 bytes)
smbtorture results (--entries=1000)
ntdb speed 183881-191112(188223) ops/sec

After:
Adding 1000 records: 3590-3701(3640) ns (129656 bytes)
Finding 1000 records: 1539-1605(1566) ns (129656 bytes)
Missing 1000 records: 1398-1440(1413) ns (129656 bytes)
Traversing 1000 records: 1629-2015(1710) ns (129656 bytes)
Deleting 1000 records: 3118-3236(3163) ns (129656 bytes)
Re-adding 1000 records: 3235-3355(3275) ns (129656 bytes)
Appending 1000 records: 5335-5444(5385) ns (253312 bytes)
Churning 1000 records: 9350-9955(9494) ns (253312 bytes)
smbtorture results (--entries=1000)
ntdb speed 180559-199981(195106) ops/sec
2012-06-19 05:38:07 +02:00

101 lines
2.7 KiB
C

/*
Trivial Database 2: traverse function.
Copyright (C) Rusty Russell 2010
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
License as published by the Free Software Foundation; either
version 3 of the License, or (at your option) any later version.
This library is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
Lesser General Public License for more details.
You should have received a copy of the GNU Lesser General Public
License along with this library; if not, see <http://www.gnu.org/licenses/>.
*/
#include "private.h"
#include <ccan/likely/likely.h>
_PUBLIC_ int64_t ntdb_traverse_(struct ntdb_context *ntdb,
int (*fn)(struct ntdb_context *,
NTDB_DATA, NTDB_DATA, void *),
void *p)
{
enum NTDB_ERROR ecode;
struct hash_info h;
NTDB_DATA k, d;
int64_t count = 0;
k.dptr = NULL;
for (ecode = first_in_hash(ntdb, &h, &k, &d.dsize);
ecode == NTDB_SUCCESS;
ecode = next_in_hash(ntdb, &h, &k, &d.dsize)) {
d.dptr = k.dptr + k.dsize;
count++;
if (fn && fn(ntdb, k, d, p)) {
ntdb->free_fn(k.dptr, ntdb->alloc_data);
return count;
}
ntdb->free_fn(k.dptr, ntdb->alloc_data);
}
if (ecode != NTDB_ERR_NOEXIST) {
return NTDB_ERR_TO_OFF(ecode);
}
return count;
}
_PUBLIC_ enum NTDB_ERROR ntdb_firstkey(struct ntdb_context *ntdb, NTDB_DATA *key)
{
struct hash_info h;
return first_in_hash(ntdb, &h, key, NULL);
}
/* We lock twice, not very efficient. We could keep last key & h cached. */
_PUBLIC_ enum NTDB_ERROR ntdb_nextkey(struct ntdb_context *ntdb, NTDB_DATA *key)
{
struct hash_info h;
struct ntdb_used_record rec;
ntdb_off_t off;
off = find_and_lock(ntdb, *key, F_RDLCK, &h, &rec, NULL);
ntdb->free_fn(key->dptr, ntdb->alloc_data);
if (NTDB_OFF_IS_ERR(off)) {
return NTDB_OFF_TO_ERR(off);
}
ntdb_unlock_hash(ntdb, h.h, F_RDLCK);
/* If we found something, skip to next. */
if (off)
h.bucket++;
return next_in_hash(ntdb, &h, key, NULL);
}
static int wipe_one(struct ntdb_context *ntdb,
NTDB_DATA key, NTDB_DATA data, enum NTDB_ERROR *ecode)
{
*ecode = ntdb_delete(ntdb, key);
return (*ecode != NTDB_SUCCESS);
}
_PUBLIC_ enum NTDB_ERROR ntdb_wipe_all(struct ntdb_context *ntdb)
{
enum NTDB_ERROR ecode;
int64_t count;
ecode = ntdb_allrecord_lock(ntdb, F_WRLCK, NTDB_LOCK_WAIT, false);
if (ecode != NTDB_SUCCESS)
return ecode;
/* FIXME: Be smarter. */
count = ntdb_traverse(ntdb, wipe_one, &ecode);
if (count < 0)
ecode = NTDB_OFF_TO_ERR(count);
ntdb_allrecord_unlock(ntdb, F_WRLCK);
return ecode;
}