mirror of
https://github.com/samba-team/samba.git
synced 2024-12-23 17:34:34 +03:00
6539f1e4cd
Call depth is not working for winbindd_list_users_send as expected, it is visible in the flow traces: -> process_request_send -> winbindd_list_users_send -> wb_query_user_list_send It should look like: -> process_request_send -> winbindd_list_users_send -> wb_query_user_list_send Tevent call depth tracking internal implementation relies on the fact that the talloc memory context has type "struct tevent_req". Then it can obtain the depth from the parent and increment it by one. The implementation of winbindd_list_users_send() is passing to wb_query_user_list_send() context of type "struct winbindd_list_users_state", and from there the parent "struct tevent_req" cannot be identified. So we will pass as TALLOC_CTX 'state' instead of 'state->domains'. After the call, we can reparent back. Signed-off-by: Pavel Filipenský <pfilipensky@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Pavel Filipensky <pfilipensky@samba.org> Autobuild-Date(master): Thu Jul 20 10:38:19 UTC 2023 on atb-devel-224
217 lines
5.7 KiB
C
217 lines
5.7 KiB
C
/*
|
|
Unix SMB/CIFS implementation.
|
|
async implementation of WINBINDD_LIST_USERS
|
|
Copyright (C) Volker Lendecke 2009
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "includes.h"
|
|
#include "winbindd.h"
|
|
#include "librpc/gen_ndr/ndr_winbind_c.h"
|
|
#include "lib/util/strv.h"
|
|
|
|
struct winbindd_list_users_domstate {
|
|
struct tevent_req *subreq;
|
|
struct winbindd_domain *domain;
|
|
char *users;
|
|
};
|
|
|
|
struct winbindd_list_users_state {
|
|
size_t num_received;
|
|
/* All domains */
|
|
size_t num_domains;
|
|
struct winbindd_list_users_domstate *domains;
|
|
};
|
|
|
|
static void winbindd_list_users_done(struct tevent_req *subreq);
|
|
|
|
struct tevent_req *winbindd_list_users_send(TALLOC_CTX *mem_ctx,
|
|
struct tevent_context *ev,
|
|
struct winbindd_cli_state *cli,
|
|
struct winbindd_request *request)
|
|
{
|
|
struct tevent_req *req;
|
|
struct winbindd_list_users_state *state;
|
|
struct winbindd_domain *domain;
|
|
size_t i;
|
|
|
|
req = tevent_req_create(mem_ctx, &state,
|
|
struct winbindd_list_users_state);
|
|
if (req == NULL) {
|
|
return NULL;
|
|
}
|
|
D_NOTICE("[%s (%u)] Winbind external command LIST_USERS start.\n"
|
|
"WBFLAG_FROM_NSS is %s, winbind enum users is %d.\n",
|
|
cli->client_name,
|
|
(unsigned int)cli->pid,
|
|
request->wb_flags & WBFLAG_FROM_NSS ? "Set" : "Unset",
|
|
lp_winbind_enum_users());
|
|
|
|
if (request->wb_flags & WBFLAG_FROM_NSS && !lp_winbind_enum_users()) {
|
|
tevent_req_done(req);
|
|
return tevent_req_post(req, ev);
|
|
}
|
|
|
|
/* Ensure null termination */
|
|
request->domain_name[sizeof(request->domain_name)-1]='\0';
|
|
|
|
D_NOTICE("Listing users for domain %s\n", request->domain_name);
|
|
if (request->domain_name[0] != '\0') {
|
|
state->num_domains = 1;
|
|
} else {
|
|
state->num_domains = 0;
|
|
for (domain = domain_list(); domain; domain = domain->next) {
|
|
state->num_domains += 1;
|
|
}
|
|
}
|
|
|
|
state->domains = talloc_array(state,
|
|
struct winbindd_list_users_domstate,
|
|
state->num_domains);
|
|
if (tevent_req_nomem(state->domains, req)) {
|
|
return tevent_req_post(req, ev);
|
|
}
|
|
|
|
if (request->domain_name[0] != '\0') {
|
|
state->domains[0].domain = find_domain_from_name_noinit(
|
|
request->domain_name);
|
|
if (state->domains[0].domain == NULL) {
|
|
tevent_req_nterror(req, NT_STATUS_NO_SUCH_DOMAIN);
|
|
return tevent_req_post(req, ev);
|
|
}
|
|
} else {
|
|
i = 0;
|
|
for (domain = domain_list(); domain; domain = domain->next) {
|
|
state->domains[i++].domain = domain;
|
|
}
|
|
}
|
|
|
|
for (i=0; i<state->num_domains; i++) {
|
|
struct winbindd_list_users_domstate *d = &state->domains[i];
|
|
/*
|
|
* Use "state" as a talloc memory context since it has type
|
|
* "struct tevent_req". This is needed to make tevent call depth
|
|
* tracking working as expected.
|
|
* After calling wb_query_user_list_send(), re-parent back to
|
|
* "state->domains" to make TALLOC_FREE(state->domains) working.
|
|
*/
|
|
d->subreq = wb_query_user_list_send(state, ev, d->domain);
|
|
d->subreq = talloc_reparent(state, state->domains, d->subreq);
|
|
if (tevent_req_nomem(d->subreq, req)) {
|
|
TALLOC_FREE(state->domains);
|
|
return tevent_req_post(req, ev);
|
|
}
|
|
tevent_req_set_callback(d->subreq, winbindd_list_users_done,
|
|
req);
|
|
}
|
|
state->num_received = 0;
|
|
return req;
|
|
}
|
|
|
|
static void winbindd_list_users_done(struct tevent_req *subreq)
|
|
{
|
|
struct tevent_req *req = tevent_req_callback_data(
|
|
subreq, struct tevent_req);
|
|
struct winbindd_list_users_state *state = tevent_req_data(
|
|
req, struct winbindd_list_users_state);
|
|
struct winbindd_list_users_domstate *d;
|
|
NTSTATUS status;
|
|
size_t i;
|
|
|
|
for (i=0; i<state->num_domains; i++) {
|
|
if (subreq == state->domains[i].subreq) {
|
|
break;
|
|
}
|
|
}
|
|
if (i == state->num_domains) {
|
|
tevent_req_nterror(req, NT_STATUS_INTERNAL_ERROR);
|
|
return;
|
|
}
|
|
|
|
d = &state->domains[i];
|
|
|
|
status = wb_query_user_list_recv(subreq, state->domains,
|
|
&d->users);
|
|
TALLOC_FREE(subreq);
|
|
if (!NT_STATUS_IS_OK(status)) {
|
|
/*
|
|
* Just skip this domain
|
|
*/
|
|
d->users = NULL;
|
|
}
|
|
|
|
state->num_received += 1;
|
|
|
|
if (state->num_received >= state->num_domains) {
|
|
tevent_req_done(req);
|
|
}
|
|
}
|
|
|
|
NTSTATUS winbindd_list_users_recv(struct tevent_req *req,
|
|
struct winbindd_response *response)
|
|
{
|
|
struct winbindd_list_users_state *state = tevent_req_data(
|
|
req, struct winbindd_list_users_state);
|
|
NTSTATUS status;
|
|
char *result;
|
|
size_t i, len;
|
|
|
|
D_NOTICE("Winbind external command LIST_USERS end.\n");
|
|
if (tevent_req_is_nterror(req, &status)) {
|
|
D_WARNING("Failed with %s.\n", nt_errstr(status));
|
|
return status;
|
|
}
|
|
|
|
result = NULL;
|
|
|
|
for (i=0; i<state->num_domains; i++) {
|
|
struct winbindd_list_users_domstate *d = &state->domains[i];
|
|
int ret;
|
|
|
|
if (d->users == NULL) {
|
|
continue;
|
|
}
|
|
|
|
ret = strv_append(state, &result, d->users);
|
|
if (ret != 0) {
|
|
return map_nt_error_from_unix(ret);
|
|
}
|
|
}
|
|
|
|
len = talloc_get_size(result);
|
|
|
|
response->extra_data.data = talloc_steal(response, result);
|
|
response->length += len;
|
|
response->data.num_entries = 0;
|
|
|
|
if (result != NULL && len >= 1) {
|
|
len -= 1;
|
|
response->data.num_entries = 1;
|
|
|
|
for (i=0; i<len; i++) {
|
|
if (result[i] == '\0') {
|
|
result[i] = ',';
|
|
response->data.num_entries += 1;
|
|
}
|
|
}
|
|
}
|
|
|
|
D_NOTICE("Got %"PRIu32" user(s):\n%s\n",
|
|
response->data.num_entries,
|
|
result);
|
|
|
|
return NT_STATUS_OK;
|
|
}
|