1
0
mirror of https://github.com/samba-team/samba.git synced 2024-12-25 23:21:54 +03:00
samba-mirror/lib/ldb
Douglas Bagnall 5e4f39ad60 ldb_controls: avoid unnecessary unchecked talloc_asprintf()s
The error paths when a control doesn't parse involved a lot of
talloc_asprintf()s and talloc_asprintf_append()s but almost no actual
printf formatting. The return values were not checked. This replaces
them with constant strings.

The one case that did use formatting looked like this:

 "invalid %s control syntax\n",  LDB_CONTROL_DIRSYNC_EX_NAME

and that has been replaced with

  "invalid dirsync_ex control syntax\n"

in line with the way it is done elsewhere.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
2016-03-22 08:00:32 +01:00
..
ABI ldb: version 1.1.26 2016-02-17 03:43:23 +01:00
common ldb_controls: avoid unnecessary unchecked talloc_asprintf()s 2016-03-22 08:00:32 +01:00
docs ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
examples ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
include ldb controls: use uint8_t* for contextID binary blob 2016-03-09 10:32:16 +01:00
ldb_ldap ldb: allow a timeout of -1 result in no timeout timer at all. 2016-02-17 03:43:22 +01:00
ldb_map Fix the O3 developer build 2015-03-03 13:14:53 +01:00
ldb_sqlite3 ldb: allow a timeout of -1 result in no timeout timer at all. 2016-02-17 03:43:22 +01:00
ldb_tdb ldb: allow a timeout of -1 result in no timeout timer at all. 2016-02-17 03:43:22 +01:00
man Fix typo in ldbrename manpage 2014-08-28 01:57:13 +02:00
modules sort: enable custom behaviour on critical control 2016-03-22 08:00:31 +01:00
nssldb ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
tests pyldb: eliminate warnings from python api test 2016-02-17 03:43:23 +01:00
tools ldb: add support for LDB_CONTROL_DIRSYNC_EX 2016-02-17 03:43:23 +01:00
web ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
_ldb_text.py pyldb: Split text/byte strings for compatibility with Python 3 2015-11-05 18:04:24 +01:00
configure ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
Doxyfile ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
examples.dox ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
ldb.pc.in ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
mainpage.dox ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
Makefile ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
pyldb_util.c pyldb: Split text/byte strings for compatibility with Python 3 2015-11-05 18:04:24 +01:00
pyldb-util.pc.in ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
pyldb.c ldb: add LDB_ATTR_FLAG_FORCE_BASE64_LDIF support 2016-02-17 03:43:23 +01:00
pyldb.h pyldb: Add warning about pyldb_MessageElement_AsMessageElement() 2016-03-08 01:58:25 +01:00
README_gcov.txt ldb: make ldb a top level library for Samba 4.0 2011-07-05 17:24:47 +10:00
wscript ldb: version 1.1.26 2016-02-17 03:43:23 +01:00