mirror of
https://github.com/samba-team/samba.git
synced 2024-12-29 11:21:54 +03:00
6259f51dd9
new open mechanism Andrew & I discussed.
config.sub:
configure: Included the QNX patch.
include/vfs.h:
smbd/vfs-wrap.c:
smbd/vfs.c: Added ftruncate vfs call (needed).
Note that we will also need locking calls in the vfs (to be added).
lib/util_unistr.c:
nmbd/nmbd_processlogon.c: Fix for NT domain logons causing nmbd to core dump.
Also fix for sidsize DOS bug.
locking/locking.c: Check value of ret before using it for memdup.
printing/printing.c: Convert print_fsp_open to return an allocated fsp.
rpc_server/srv_lsa.c: Fix for NT domain logons.
I have removed all use of lp_share_modes() from the code (although I
left the parameter in the table for backwards compatibility). It no longer makes
sense for this to exist.
smbd/close.c: Removed lp_share_modes().
smbd/fileio.c: Fixed parameters to unlock_share_entry call in panic code.
smbd/files.c: Correctly set the unix_ERR_code to ERRnofids on fsp allocation fail.
smbd/nttrans.c:
smbd/reply.c:
smbd/trans2.c: Changed all occurrences of open_file_shared/open_directory/
open_file_stat to return an fsp from the call.
smbd/open.c: Changed all occurrences of open_file_shared/open_directory/
open_file_stat to return an fsp from the call.
In addition I have fixed a long standing race condition in the deny mode
processing w.r.t. two smbd's creating a file. Andrew, please note that
your original idea of using open with O_EXCL in this case would not work
(I went over the races very carefully) and so we must re-check deny modes
*after* the open() call returns. This is because there is a race between
the open with O_EXCL and the lock of the share mode entry. Imagine the
case where the first smbd does the open with O_EXCL and a deny mode of DENY_ALL,
but is pre-empted before it locks the share modes and creates the deny
mode entry for DENY_ALL. A second smbd could then come in with O_RDONLY
and a deny mode of DENY_NONE and the two opens would be allowed.
The *only* way to fix this race is to lock the share modes after the
open and then do the deny mode checks *after* this lock in the case
where the file did not originally exist.
This code will need extensive testing but seems to initially work.
Jeremy.
(This used to be commit
|
||
|---|---|---|
| .. | ||
| .cvsignore | ||
| byteorder.h | ||
| charset.h | ||
| client.h | ||
| clitar.h | ||
| config.h.in | ||
| debug.h | ||
| dlinklist.h | ||
| hash.h | ||
| includes.h | ||
| interfaces.h | ||
| kanji.h | ||
| local.h | ||
| MacExtensions.h | ||
| msdfs.h | ||
| nameserv.h | ||
| nt_printing.h | ||
| ntdomain.h | ||
| nterr.h | ||
| profile.h | ||
| proto.h | ||
| rpc_creds.h | ||
| rpc_dce.h | ||
| rpc_lsa.h | ||
| rpc_misc.h | ||
| rpc_netlogon.h | ||
| rpc_reg.h | ||
| rpc_samr.h | ||
| rpc_secdes.h | ||
| rpc_spoolss.h | ||
| rpc_srvsvc.h | ||
| rpc_wkssvc.h | ||
| rpcclient.h | ||
| safe_string.h | ||
| smb_macros.h | ||
| smb.h | ||
| stamp-h.in | ||
| talloc.h | ||
| trans2.h | ||
| unicode_map_table1.h | ||
| unicode_map_table2.h | ||
| version.h | ||
| vfs.h | ||
| vt_mode.h | ||