mirror of
https://github.com/samba-team/samba.git
synced 2025-02-09 09:57:48 +03:00
b812ade416
During replication we may need to fallback to using DRS_GET_TGT, which means that we'll get a lot of objects more than once, the most important one it the partition root object. It means we'll also do the security descriptor propagation more than once for these objects, which is extrememly costly for the partition root objects and other objects near the root. I analyzed a domain where we collected ~ 50000 descriptor_changes registrations for the initial replication of ~ 22000 objects in the database. For that domain we spend ~ 4 hours for the security descriptor propagation in descriptor_prepare_commit(), while the replication itself was finished in less than 2 minutes. With this change we reduce the number of registered/processed descriptor_changes down to ~ 22000, while is reduces the time from ~ 4 hours to just ~ 3 minutes 20 seconds! The statitics changed from: descriptor_prepare_commit: changes: num_registered=50000 descriptor_prepare_commit: changes: num_processed=50000 descriptor_prepare_commit: objects: num_processed=12000000 to: descriptor_prepare_commit: changes: num_registrations=50000 descriptor_prepare_commit: changes: num_registered=22000 descriptor_prepare_commit: changes: num_processed=22000 descriptor_prepare_commit: objects: num_processed=80800 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>