mirror of
https://github.com/samba-team/samba.git
synced 2024-12-24 21:34:56 +03:00
004e7a1fee
On (eg) the
DC=_msdcs.X.Y,CN=MicrosoftDNS,DC=ForestDnsZones,DC=X,DC=Y
record, in domains that have had a Microsoft Windows DC an attribute:
dNSProperty:: AAAAAAAAAAAAAAAAAQAAAJIAAAAAAAAA
000000 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 >................<
000010 92 00 00 00 00 00 00 00 >........<
000018
We, until samba 4.12, would parse this as:
pull returned Success
dnsp_DnsProperty: struct dnsp_DnsProperty
wDataLength : 0x00000000 (0)
namelength : 0x00000000 (0)
flag : 0x00000000 (0)
version : 0x00000001 (1)
id : DSPROPERTY_ZONE_NS_SERVERS_DA (146)
data : union dnsPropertyData(case 0)
name : 0x00000000 (0)
dump OK
However, the wDataLength is 0. There is not anything in
[MS-DNSP] 2.3.2.1 dnsProperty to describe any special behaviour
for when the id suggests that there is a value, but wDataLength is 0.
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dnsp/445c7843-e4a1-4222-8c0f-630c230a4c80
We now fail to parse it, because we expect an entry with id DSPROPERTY_ZONE_NS_SERVERS_DA
to therefore have a valid DNS_ADDR_ARRAY (section 2.2.3.2.3).
As context we changed it in our commit
|
||
|---|---|---|
| .. | ||
| backupkey | ||
| browser | ||
| common | ||
| dnsserver | ||
| drsuapi | ||
| echo | ||
| epmapper | ||
| eventlog | ||
| lsa | ||
| netlogon | ||
| remote | ||
| samr | ||
| srvsvc | ||
| tests | ||
| unixinfo | ||
| winreg | ||
| wkssvc | ||
| dcerpc_server.c | ||
| dcerpc_server.h | ||
| dcerpc_server.pc.in | ||
| handles.c | ||
| service_rpc.c | ||
| wscript_build | ||